unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Stephen Paul Weber <singpolyma@singpolyma.net>
To: 52362@debbugs.gnu.org
Subject: bug#52362: guix import go error
Date: Tue, 11 Jan 2022 23:28:12 -0500	[thread overview]
Message-ID: <Yd5Y3KcqyWg33n+H@singpolyma-beefy.lan> (raw)
In-Reply-To: <Yd5R+fEA+Czl6HwA@singpolyma-beefy.lan>

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]

Alright, I think I have found the issue.  https://go.dev/ref/mod says:

> If a module is defined in a subdirectory within the repository, that is,
> the module subdirectory portion of the module path is not empty, then each
> tag name must be prefixed with the module subdirectory, followed by a slash.
> For example, the module golang.org/x/tools/gopls is defined in the gopls
> subdirectory of the repository with root path golang.org/x/tools. The version
> v0.4.0 of that module must have the tag named gopls/v0.4.0 in that repository.

Right now the importer code assumes that either we have a pseudo version (and
thus can extract a raw commit hash) or else that the tag will be exactly
(string-append "v" version) but this does not take into account the rule about
subdirectory packages.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-01-12  4:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-07 22:08 bug#52362: guix import go error Stephen Paul Weber
2022-01-12  3:58 ` Stephen Paul Weber
2022-01-12  4:28   ` Stephen Paul Weber [this message]
2022-01-15  1:43 ` bug#52362: [PATCH] guix: import: go: Use correct tag for go module in subdirectory Stephen Paul Weber
2022-01-15  1:56   ` Stephen Paul Weber
2022-01-16  2:56 ` bug#52362: [PATCH v2] " Stephen Paul Weber
2022-01-16  3:32 ` bug#52362: [PATCH v3] " Stephen Paul Weber
2023-05-25 16:13   ` bug#52362: guix import go error Simon Tournier
2022-02-28 23:55 ` bug#52362: [PATCH v3] guix: import: go: Use correct tag for go module in subdirectory Nicolas Goaziou
2023-05-25 14:21   ` bug#52362: guix import go error Simon Tournier
2023-05-25 18:58     ` Nicolas Goaziou
2023-05-25 19:08       ` Simon Tournier
2022-04-13 14:26 ` bug#52362: another patchset Attila Lendvai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yd5Y3KcqyWg33n+H@singpolyma-beefy.lan \
    --to=singpolyma@singpolyma.net \
    --cc=52362@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).