unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 45645@debbugs.gnu.org
Subject: bug#45645: Please revoke this commit: 7dd1a2174a8376c521dcf271e3b76f64096074fe
Date: Mon, 29 Mar 2021 16:15:00 +0300	[thread overview]
Message-ID: <YGHS1J9OHuHl+aHq@3900XT> (raw)
In-Reply-To: <86o8f69so0.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1821 bytes --]

On Fri, Mar 26, 2021 at 10:21:35AM +0100, zimoun wrote:
> Hi,
> 
> On Mon, 04 Jan 2021 at 16:14, Efraim Flashner <efraim@flashner.co.il> wrote:
> > On Mon, Jan 04, 2021 at 09:52:38AM +0800, luhux wrote:
> 
> >> ```
> >>     const gchar *stardict_data_dir = g_getenv("STARDICT_DATA_DIR");
> >>     std::string data_dir;
> >>     if (!opt_data_dir) {
> >>         if (!only_data_dir) {
> >>             if (stardict_data_dir)
> >>                 data_dir = stardict_data_dir;
> >>             else
> >>                 data_dir = "/usr/share/stardict/dic";
> >>         }
> >>     } else {
> >>         data_dir = get_impl(opt_data_dir);
> >>     }
> >>
> >> ```
> >>
> >> Please revoke the content of this commit.
> 
> I am not seeing a commit reverting
> 7dd1a2174a8376c521dcf271e3b76f64096074fe.  Am I correct?

That's right, I didn't end up reverting it.

> > Do you have an easy test case? Something like 'guix environment --ad-hoc
> > sdvc stardict-en stardict-es -- sdvc'? I'd like to get it working. What
> > is it looking for, just one directory?
> 
> Should 7dd1a2174a8376c521dcf271e3b76f64096074fe be reverted waiting a
> proper fix or is it let as it is?
> 
> In order to close this. :-)

I suppose we could revert it for now. I don't know of any dictionaries
that it would currently use and according to the bug report it isn't
working as expected. I was hoping to get it working but moved on to
other things.

> 
> Cheers,
> simon

Thanks for finding this forgotten bug. luhux, if you have any
suggestions I'd be happy to continue working on it.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-03-29 13:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04  1:52 bug#45645: Please revoke this commit: 7dd1a2174a8376c521dcf271e3b76f64096074fe luhux
2021-01-04 14:14 ` Efraim Flashner
2021-03-26  9:21   ` zimoun
2021-03-29 13:15     ` Efraim Flashner [this message]
2021-06-09 21:48       ` zimoun
2021-06-10  6:47 ` Leo Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YGHS1J9OHuHl+aHq@3900XT \
    --to=efraim@flashner.co.il \
    --cc=45645@debbugs.gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).