unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 47107-done@debbugs.gnu.org
Subject: bug#47107: libtiff/fixed uses wrong version number in 'doc' output
Date: Sun, 14 Mar 2021 16:34:08 -0400	[thread overview]
Message-ID: <YE5zQF3HMKhdWsk7@jasmine.lan> (raw)
In-Reply-To: <87v99vpc38.fsf@gnu.org>

On Sat, Mar 13, 2021 at 11:44:27AM +0100, Ludovic Courtès wrote:
> Instead of duplicating the ‘name’ and ‘arguments’ fields as done in
> 35b3ab8e5748d9911ae7a0189065d0c25392895b, one possibility is to change
> the initial ‘libtiff’ like so:
> 

> diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
> index 4f249b7622..44d2cac0fe 100644
> --- a/gnu/packages/image.scm
> +++ b/gnu/packages/image.scm
> @@ -599,7 +599,8 @@ extracting icontainer icon files.")
>      `(#:configure-flags (list (string-append "--with-docdir="
>                                               (assoc-ref %outputs "doc")
>                                               "/share/doc/"
> -                                             ,name "-" ,version)
> +                                             ,name "-"
> +                                             ,(package-version this-package))
>                                "--disable-static")))
>     (inputs `(("zlib" ,zlib)
>               ("libjpeg" ,libjpeg-turbo)))

> 
> WDTY?
> 
> Would it make sense to adopt this style also for
> <https://issues.guix.gnu.org/47108> and
> <https://issues.guix.gnu.org/47110>?

Done as b082ea9406f19f0d0c296227510256b87fe11e3c

Thanks for the suggestion!




      parent reply	other threads:[~2021-03-14 20:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12 18:55 bug#47107: libtiff/fixed uses wrong version number in 'doc' output Leo Famulari
2021-03-12 19:11 ` Leo Famulari
2021-03-13 10:44 ` Ludovic Courtès
2021-03-13 20:15   ` Leo Famulari
2021-03-14 20:34   ` Leo Famulari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YE5zQF3HMKhdWsk7@jasmine.lan \
    --to=leo@famulari.name \
    --cc=47107-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).