unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 25752@debbugs.gnu.org, Hank Donnay <hdonnay@gmail.com>
Subject: bug#25752: Acknowledgement (go incremental builds broken)
Date: Mon, 11 Jan 2021 22:01:18 +0200	[thread overview]
Message-ID: <X/yujodIHrnX0s3T@3900XT> (raw)
In-Reply-To: <86im83tzd3.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]

On Mon, Jan 11, 2021 at 01:46:48PM +0100, zimoun wrote:
> Hi Leo,
> 
> On Fri, 18 Dec 2020 at 16:31, Leo Famulari <leo@famulari.name> wrote:
> 
> > I don't think this bug has been fixed, although I have not checked.
> > Currently, Go incremental builds and library re-use is not functional in
> > Guix, unless I missed a new development.
> 
> Thanks.  Could you provide a Go example for reproducing?  Well, a
> reproducer to track what could be wrong on the grafting mechanism for
> Go.  If I understand correctly.
> 

I actually spent a bit of time on this today/yesterday. I modified the
go-build-system to copy the pkg and src folders from build to build
(instead of just the src folders) and the pkg folders were ignored.
Upstream documentation isn't clear about when the pkg folder is used and
when it is ignored.

One thing I did try was to set the pkgdir to (string-append (getenv
"GOROOT") "/pkg"), but then it didn't find the pkg folder from go:out. I
didn't try copying go:out/pkg to GOROOT/pkg to see if that would fix it;
I assumed that even if it did work we wouldn't want to propagate all of
go with the go packages.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-01-11 20:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16 15:05 bug#25752: go incremental builds broken Hank Donnay
     [not found] ` <handler.25752.B.14872575426869.ack@debbugs.gnu.org>
2017-02-24 19:50   ` bug#25752: Acknowledgement (go incremental builds broken) Hank Donnay
2017-02-25 15:58     ` Leo Famulari
2020-12-18 20:00       ` zimoun
2020-12-18 21:31         ` Leo Famulari
2021-01-11 12:46           ` zimoun
2021-01-11 20:01             ` Efraim Flashner [this message]
2021-06-09 21:38               ` zimoun
2021-11-26  1:12               ` zimoun
2021-09-14 10:43           ` bug#25752: go incremental builds broken zimoun
2022-10-26 20:42             ` zimoun
2022-10-27 10:21               ` Maxime Devos
2022-10-28  8:22                 ` zimoun
2023-10-16 22:44                   ` Simon Tournier
2017-03-07 21:50 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X/yujodIHrnX0s3T@3900XT \
    --to=efraim@flashner.co.il \
    --cc=25752@debbugs.gnu.org \
    --cc=hdonnay@gmail.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).