From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id AL3cH+2d8WIv3wAAbAwnHQ (envelope-from ) for ; Tue, 09 Aug 2022 01:36:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id +GchH+2d8WIONgAAG6o9tA (envelope-from ) for ; Tue, 09 Aug 2022 01:36:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8014037251 for ; Tue, 9 Aug 2022 01:36:12 +0200 (CEST) Received: from localhost ([::1]:50812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLCI6-0008US-Mk for larch@yhetil.org; Mon, 08 Aug 2022 19:36:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLCHy-0008UI-Bj for bug-guix@gnu.org; Mon, 08 Aug 2022 19:36:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52386) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLCHy-0000so-38 for bug-guix@gnu.org; Mon, 08 Aug 2022 19:36:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLCHx-0003wQ-VC for bug-guix@gnu.org; Mon, 08 Aug 2022 19:36:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#56799: (gnu services configuration) usage of *unspecified* is problematic Resent-From: Attila Lendvai Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 08 Aug 2022 23:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56799 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 56799@debbugs.gnu.org, Maxim Cournoyer Received: via spool by 56799-submit@debbugs.gnu.org id=B56799.166000172215092 (code B ref 56799); Mon, 08 Aug 2022 23:36:01 +0000 Received: (at 56799) by debbugs.gnu.org; 8 Aug 2022 23:35:22 +0000 Received: from localhost ([127.0.0.1]:42135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLCHJ-0003vM-Sj for submit@debbugs.gnu.org; Mon, 08 Aug 2022 19:35:22 -0400 Received: from mail-4022.proton.ch ([185.70.40.22]:42385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLCHI-0003v6-83 for 56799@debbugs.gnu.org; Mon, 08 Aug 2022 19:35:21 -0400 Date: Mon, 08 Aug 2022 23:35:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail; t=1660001713; x=1660260913; bh=Bxk3r8A0+T7PNaucpDNLwe82ptqdkuYwQEif7iC+8ek=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=UQLLKb40nWIuD58kUZbG6BhrYRUzRsYMwPANqpGXIwyd+g1itKC0CTTNMNhh2XjG+ O0yxbqQ6aL5ZsCkVtUDLMWdmyYGeenMehRgL3XzscMMWrZwlwZMocvTSMIYPQmS/4p jvECK9rIk2rgAf4BL2+j3BewJBbNgu4AAV6PC37FD1xKezm2kJOV7O+VUYVknu30AQ UZL6qZarJ3X9AfQBkBq36UCOeFBeP/eL5qnr9Mhw9urG7kvdmHP14UXlyHWjPfqqu6 9v+hnkdo1AbDbQD+DiiK3NY9AVremu/9E2hYHWpu6ingNrXzW6JlkUN6DFoP0//Ifj 3lxQPwt4YxXWg== From: Attila Lendvai Message-ID: In-Reply-To: References: <87o7xa8qxt.fsf@gmail.com> <8735egxedv.fsf@gnu.org> <87les82c2f.fsf@gmail.com> <87v8rbumnx.fsf@gnu.org> <87sfme1y8m.fsf@gmail.com> <877d3omc9c.fsf@gnu.org> Feedback-ID: 28384833:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Attila Lendvai Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660001773; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Bxk3r8A0+T7PNaucpDNLwe82ptqdkuYwQEif7iC+8ek=; b=YB138hbGSMIlctfAwxyipW88CGiRE/AhP463+tcAo1zEQLMUf7nqPbvvT4SKPIJp/2cs/J Q7ZpLGA77/foFmWg//lz9RZDYHtRH2+75y2gmIGW77BiBFaSHGpkqvdiEdrsvboXc448VB VoVovlcgZJDwSzzdGyP8Q5WP6WE96bVDhzZala9zP0+Ad7ZXzhtoxKc1HlZSU0IuSh6EkA 8TiIBVa5pM6Z28mVyEinAZwWJmNU6Vl3nQtrnwPq6k004mNok3q4BUAZa0ONKqmjAs4a7e OPizuFN62soH3pvYqESebN4pC5N+CiYNQBdOZ1tUk0/bVBIQF6XBQ9LkL3l5Ig== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660001773; a=rsa-sha256; cv=none; b=bw9inVdPjR1sZKqVoZuRnqh6bLCLn+r38Yv39qgc8D5cPtVfl6ZuL7giCd6xDP8dLy23kj S60I1U7AcQNRMRPVnWMwfodIpFIDvKy/u3LTif9BM1YsEjzJwvfRMRgzJbzrcG3LQEQk7b 81uwFaw6CX1ksTVkr6XNr1Et2VMLGjXaIACCDNUATA9K+aPF8VNw3c3AjNaqZSsGfJKogl gVYpbeKp5+k/gAA2I/DxsvpW4/azj9fANe8Y+8WvLJAx4v/y9m9u8j7/b76FOH45H+Mq3w /auLlH3glU9fg1yry7IY/Cp+Y98prWdT8z86KWLlMoDARxr/toDtG64wdfxyaw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lendvai.name header.s=protonmail header.b=UQLLKb40; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.10 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lendvai.name header.s=protonmail header.b=UQLLKb40; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8014037251 X-Spam-Score: 1.10 X-Migadu-Scanner: scn0.migadu.com X-TUID: a56486sh9LDF > i'm obviously not aware of the entire complexity here, othrwise > there wouldn't have remained a bug... but regardless of the actual > API/value used, i don't see how any of this could work without the > service code explicitly checking for the unspecified value for > fields that have a maybe type (i.e. whose type allows the value to > be unspecified). i think using a symbol instead of unspecified only > pushes the appearance of the symptoms farther away both in time and > space (otherwise there should have been a trivial fix to this > without changing unspecified back to 'unset). sorry, i was wrong/slow here^. i think i finally understand what the original issue was that triggered the= rollback: the *UNSPECIFIED* value cannot get through the GExp serialize/deserialize o= peration between the host/builder (or how do we call it?) and Shepherd. the= checks in the service code that handle the unspecified field values only h= appen when Shepeherd is executing the deserialized GExp's. the fix i would propose is to smarten up GExp serialization to handle which= ever value we use as the marker, be it 1) *UNSPECIFIED*, or 2) Nothing from= srfi-189, or 3) a record instance that we define/instantiate ourselves. i don't recommend 3). we should rather use srfi-189 then, because it sandar= dizes widely known concepts. so, would you accept a patch that implements 1) or 2) ? 2) has non-trivial uncertainties/complexities in making srfi-189 available = in all the required contexts, and not introducing any bootstrap related iss= ues in the process. because of that i would recommend getting to 2) by firs= t implementing 1) and then working towards 2) -- if we want to use srfi-189= at all, that is. -- =E2=80=A2 attila lendvai =E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39 -- =E2=80=9CWhat's done to children, they will do to society.=E2=80=9D =09=E2=80=94 Karl A. Menninger (http://psychohistory.com/)