From mboxrd@z Thu Jan  1 00:00:00 1970
From: Carl Dong <contact@carldong.me>
Subject: bug#32773: [PATCH] Fix clang libstdc++ header location search
Date: Wed, 13 Nov 2019 19:50:50 +0000
Message-ID: <E981B954-E19B-49B0-B8EE-BF49E51C3914@carldong.me>
References: <19ece273-ea75-fc9d-4e4b-aa3a68deab6d@yahoo.de>
 <20191113165516.56228-1-david.truby@arm.com>
Reply-To: Carl Dong <contact@carldong.me>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:42729)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iUygN-0001lG-7R
 for bug-guix@gnu.org; Wed, 13 Nov 2019 14:52:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iUygM-0002dw-53
 for bug-guix@gnu.org; Wed, 13 Nov 2019 14:52:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:51375)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iUygM-0002do-25
 for bug-guix@gnu.org; Wed, 13 Nov 2019 14:52:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iUygL-00053r-UC
 for bug-guix@gnu.org; Wed, 13 Nov 2019 14:52:01 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.32773.B.157367467119395@debbugs.gnu.org>
In-Reply-To: <20191113165516.56228-1-david.truby@arm.com>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: David Truby <David.Truby@arm.com>
Cc: nd <nd@arm.com>, "guix-patches@gnu.org" <guix-patches@gnu.org>

Hi David!

This patch is most welcome, I=E2=80=99m wondering if you think it=E2=80=
=99d be possible to add more details in the comments for future readers of =
the code. See below.

> On Nov 13, 2019, at 11:56 AM, David Truby <David.Truby@arm.com> wrote:
>=20
> +                            ;; Make clang look for libstdc++ in the righ=
t location
> +                            (("LibStdCXXIncludePathCandidates\\[\\] =3D =
\\{")
> +                             (string-append "LibStdCXXIncludePathCandida=
tes[] =3D { \"" gcc "/include/c++\","))
I believe the reason why clang=E2=80=99s =E2=80=9Cauto detection=E2=80=
=9D fails here is because it expects the /include dir containing c++ to be =
under the same directory as LibDir, correct? Perhaps we can note that since=
 in Guix, we put the libs in a separate output, we invalidate the aforement=
ioned expectation, and this is why we need to manually add this path.

Another point: Perhaps we can add the path on a separate line instead of it=
 being on the same line?

Otherwise, looks great!

Cheers,
Carl Dong