unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Martin Edström" <meedstrom@runbox.eu>
To: 73681@debbugs.gnu.org
Cc: "liliana.prikler" <liliana.prikler@gmail.com>
Subject: bug#73681: Maybe partly undo the patch on Elisp comp-el-to-eln-filename
Date: Mon, 07 Oct 2024 16:56:50 +0200 (CEST)	[thread overview]
Message-ID: <E1sxpAI-0003hS-Gg@rmmprod07.runbox> (raw)

Hi, I suggest to maybe amend one of the things done by this patchset:  https://issues.guix.gnu.org/67260

It undoes the hashing effect of the Elisp function `comp-el-to-eln-filename`, and that seems likely to cause issues downstream, for example in my Emacs package: https://github.com/meedstrom/org-node/issues/60.

To summarize: that function is supposed to generate a filename with a hash based not only the filename but the contents of the file.  While it makes sense in Guix to ignore the contribution of the filename, I believe it should still output a new filename when the contents change.

Otherwise there seems to be no way for a downstream package to ensure that it is using an up-to-date .eln variant of an .el file.

I may have missed something though.  Can someone in the know tell me what happens if you have not updated Emacs (which if I understand correctly, means ELN-DIR does not change), but you do update an Elisp package, whether through Guix or through Emacs' own package managers. Will Emacs then possibly load an old .eln?  

I do not believe that user options like `load-prefer-newer` would affect it. It would just rely on running the aforementioned function and counting on it to output an .eln filename that does not exist if the source is newer.



             reply	other threads:[~2024-10-07 15:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-07 14:56 Martin Edström [this message]
2024-10-07 18:02 ` bug#73681: Maybe partly undo the patch on Elisp comp-el-to-eln-filename Liliana Marie Prikler
2024-10-07 20:46   ` Martin Edström
2024-10-08  4:32     ` Liliana Marie Prikler
2024-10-08 10:41       ` Martin Edström
2024-10-08 17:33         ` Liliana Marie Prikler
2024-10-09 15:15           ` Martin Edström
2024-10-09 17:22             ` Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1sxpAI-0003hS-Gg@rmmprod07.runbox \
    --to=meedstrom@runbox.eu \
    --cc=73681@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).