unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#31302: `guix import json` doesn't handle inputs with the form 'package:output'
@ 2018-04-28 16:28 pkill9
  2020-10-14  6:12 ` Lulu
  0 siblings, 1 reply; 5+ messages in thread
From: pkill9 @ 2018-04-28 16:28 UTC (permalink / raw)
  To: 31302

For example, if you specify 'glib:bin' as an input, it will add only 'glib' as an input. (It's not recognising a specified output of a package recipe that produces multiple outputs.)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#31302: `guix import json` doesn't handle inputs with the form 'package:output'
  2018-04-28 16:28 bug#31302: `guix import json` doesn't handle inputs with the form 'package:output' pkill9
@ 2020-10-14  6:12 ` Lulu
  2020-10-15  9:57   ` zimoun
  0 siblings, 1 reply; 5+ messages in thread
From: Lulu @ 2020-10-14  6:12 UTC (permalink / raw)
  To: 31302@debbugs.gnu.org

I just checked this and failed to replicate it. It happily generates config from
`glib:doc', `glib:bin' and `glib:out' in input fields and complains if there's a
nonexistent `glib:foo' input, as of v1.1.0.

--
Lulu




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#31302: `guix import json` doesn't handle inputs with the form 'package:output'
  2020-10-14  6:12 ` Lulu
@ 2020-10-15  9:57   ` zimoun
  2020-10-25 17:12     ` Lulu
  0 siblings, 1 reply; 5+ messages in thread
From: zimoun @ 2020-10-15  9:57 UTC (permalink / raw)
  To: Lulu; +Cc: 31302@debbugs.gnu.org

Hi Lulu,

Thank you for working of this.

On Wed, 14 Oct 2020 at 09:12, Lulu <me@erkin.party> wrote:

> I just checked this and failed to replicate it. It happily generates
> config from `glib:doc', `glib:bin' and `glib:out' in input fields and
> complains if there's a nonexistent `glib:foo' input, as of v1.1.0.

Could you provide the commit (hash) of the Guix you are using?
Personally, I do “guix describe” and paste then the short hash
(58af4c9).  Then it is easier to reproduce or replicate or see if it is
fixed in which version.

Then, could you provide the sequence of commands you used for
“replication“?  And the file example you used too.  It eases the process
for confirming or not. :-)


Thanks,
simon




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#31302: `guix import json` doesn't handle inputs with the form 'package:output'
  2020-10-15  9:57   ` zimoun
@ 2020-10-25 17:12     ` Lulu
  2020-10-26 14:16       ` zimoun
  0 siblings, 1 reply; 5+ messages in thread
From: Lulu @ 2020-10-25 17:12 UTC (permalink / raw)
  To: zimoun; +Cc: 31302@debbugs.gnu.org

The version hash of Guix I tried this on was `26f6bd0403ed20c1d26eca9d4f28a0da519a56ac'.

I used the example JSON file for the `hello' package provided in
"(guix)Invoking guix import". Then, based on the given example of glib, I tried
running `guix import json' with `glib', `glib:bin', `glib:doc', `glib:out'
separately appended to the `native-inputs' array of `hello.json', in order. It
produced an appropriate SXML structure in the `native-inputs` field each time:
("glib" (@ (gnu packages glib) glib-with-documentation))
for standalone `glib' and
("glib" (@ (gnu packages glib) glib-with-documentation) "bin")
for the rest, which appears to fit the package definition syntax.

When I tried with `glib:foo', where `foo' is an erroneous output, it yielded the
following error:
guix import: error: package `glib@2.62.6' lacks output `foo'.

So, it seems like this bug was fixed somewhere along the line.

--
Lulu




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#31302: `guix import json` doesn't handle inputs with the form 'package:output'
  2020-10-25 17:12     ` Lulu
@ 2020-10-26 14:16       ` zimoun
  0 siblings, 0 replies; 5+ messages in thread
From: zimoun @ 2020-10-26 14:16 UTC (permalink / raw)
  To: Lulu; +Cc: 31302@debbugs.gnu.org

Dear,

On Sun, 25 Oct 2020 at 20:12, Lulu <me@erkin.party> wrote:

> So, it seems like this bug was fixed somewhere along the line.

Yep, the bug is fixed.  Probably by these:

7cef499bb0 * import/json: json->code: Handle files with more than one definition.
c893432320 * import/json: Use json->code.
16dd764691 * import/json: Add json->scheme-file.


You can close the bug by sending to <31302-done@debbugs.gnu.org> with
the explanations.


Thanks,
simon




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-10-26 14:22 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-28 16:28 bug#31302: `guix import json` doesn't handle inputs with the form 'package:output' pkill9
2020-10-14  6:12 ` Lulu
2020-10-15  9:57   ` zimoun
2020-10-25 17:12     ` Lulu
2020-10-26 14:16       ` zimoun

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).