unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: YOANN P <yoann_mac_donald@hotmail.com>
To: "30768@debbugs.gnu.org" <30768@debbugs.gnu.org>
Subject: bug#30768: Gettext : test-copy-file-1.sh fail if --with-store-dir=/var/tmp/xxxxx/gnu/store
Date: Sun, 11 Mar 2018 20:01:12 +0000	[thread overview]
Message-ID: <DB6P18901MB0022308B270EB51633D14D13DBDC0@DB6P18901MB0022.EURP189.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <DB6P18901MB002262D076C3BE3D6D9BAF16DBDC0@DB6P18901MB0022.EURP189.PROD.OUTLOOK.COM>


[-- Attachment #1.1: Type: text/plain, Size: 429 bytes --]

I've add "/var/tmp" into the chroot directories inside nix/libstore/build.cc with the attached patch (based on v0.14.0 tag) and the installation of gettext and the other dependencies not yet installed seem to finished correctly.


Is there someone who could validate than this patch is correct and is the correct way to solve this problem before i try to submit my the patch mailing list ? :)


Thanks,


Best regards,

[-- Attachment #1.2: Type: text/html, Size: 1330 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-writable-var-tmp-to-chroot.patch --]
[-- Type: text/x-patch; name="0001-Add-writable-var-tmp-to-chroot.patch", Size: 938 bytes --]

From d879d9fae405131a605860260f034d0d4dcc86e8 Mon Sep 17 00:00:00 2001
From: RockAndSka <yoann_mac_donald@hotmail.com>
Date: Sun, 11 Mar 2018 20:48:34 +0100
Subject: [PATCH] Add writable /var/tmp to chroot

---
 nix/libstore/build.cc | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/nix/libstore/build.cc b/nix/libstore/build.cc
index d68e8b2..ad08b3a 100644
--- a/nix/libstore/build.cc
+++ b/nix/libstore/build.cc
@@ -1849,6 +1849,11 @@ void DerivationGoal::startBuilder()
         createDirs(chrootTmpDir);
         chmod_(chrootTmpDir, 01777);
 
+        /* Create a writable /var/tmp in the chroot. */
+        Path chrootVarTmpDir = chrootRootDir + "/var/tmp";
+        createDirs(chrootVarTmpDir);
+        chmod_(chrootVarTmpDir, 01777);
+
         /* Create a /etc/passwd with entries for the build user and the
            nobody account.  The latter is kind of a hack to support
            Samba-in-QEMU. */
-- 
2.7.4


  reply	other threads:[~2018-03-11 23:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-11 16:08 bug#30768: Gettext : test-copy-file-1.sh fail if --with-store-dir=/var/tmp/xxxxx/gnu/store YOANN P
2018-03-11 20:01 ` YOANN P [this message]
2018-03-12 13:47   ` Ludovic Courtès
2018-03-12 19:18     ` YOANN P
2018-03-12 21:08       ` Ludovic Courtès
2018-03-13 23:48         ` YOANN P
2018-03-14  9:33           ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB6P18901MB0022308B270EB51633D14D13DBDC0@DB6P18901MB0022.EURP189.PROD.OUTLOOK.COM \
    --to=yoann_mac_donald@hotmail.com \
    --cc=30768@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).