unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Taiju HIGASHI <higashi@taiju.info>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 55495@debbugs.gnu.org
Subject: bug#55495: [PATCH] gnu: emacs-haskell-mode: Fix build.
Date: Sat, 21 May 2022 05:59:53 +0900	[thread overview]
Message-ID: <CB2BAAEA-E9F4-41D1-AB73-958434DE52D3@taiju.info> (raw)
In-Reply-To: <87mtfcr0la.fsf@taiju.info>

Hi Liliana,

>>> +-  "Generate a regex for searching for any occurrence of the prompt\
>>> ++  "Generate a regex for searching for any occurrence of the prompt
>> LGTM, but you might want to shorten the docstring so that the first
>> line is a synopsis.  This would make it easier for upstream to accept.
>
>>> +-  "Run a loading-ish COMMAND that wants to pick up type errors\
>>> ++  "Run a loading-ish COMMAND that wants to pick up type errors
>> As above, what is "loading-ish", are "things like that" relevant, etc.
>
>I decided not to make these corrections. Because I am not familiar with
>Haskell and am just one learner, and am not good at English.

Hmmm, you were right.
https://github.com/haskell/haskell-mode/pull/1780#issuecomment-1133107992

I will try, but I am a little apprehensive.
Is it possible for you to continue to review it here? Or should I just change the fix to change the parameters to suppress the error and resolve this issue?

Cheers




  reply	other threads:[~2022-05-20 21:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18  8:30 bug#55495: emacs-haskell-mode build fails Taiju HIGASHI
2022-05-18 13:16 ` Liliana Marie Prikler
2022-05-18 14:39   ` Taiju HIGASHI
2022-05-18 14:31 ` bug#55495: [PATCH] gnu: emacs-haskell-mode: Fix build Taiju HIGASHI
2022-05-19 19:09   ` Liliana Marie Prikler
2022-05-20  2:29     ` Taiju HIGASHI
2022-05-20  8:49       ` Taiju HIGASHI
2022-05-19 15:14 ` bug#55495: Re: emacs-haskell-mode build fails Luis Henrique Gomes Higino
2022-05-20  9:49   ` Taiju HIGASHI
2022-05-20  9:54 ` bug#55495: [PATCH] gnu: emacs-haskell-mode: Fix build Taiju HIGASHI
2022-05-20 20:59   ` Taiju HIGASHI [this message]
2022-05-20 21:57     ` Liliana Marie Prikler
2022-05-20 22:52       ` Taiju HIGASHI
2022-05-20  9:59 ` bug#55495: [PATCH v2] " Taiju HIGASHI
2022-05-21  5:23 ` bug#55495: [PATCH v3] " Taiju HIGASHI
2022-05-31 19:29 ` bug#55495: (no subject) Luis Henrique Gomes Higino
2022-06-01  3:52   ` Taiju HIGASHI
2022-06-01 14:56     ` Luis Henrique Gomes Higino
2022-06-01 15:36       ` Taiju HIGASHI
2022-06-02  3:57 ` bug#55495: [PATCH v3] gnu: emacs-haskell-mode: Fix build Taiju HIGASHI
2022-06-02  4:01   ` Taiju HIGASHI
2022-06-17 21:41 ` bug#55495: About v3 Luis Henrique Gomes Higino
2022-06-18 14:09   ` Taiju HIGASHI
2022-06-22  0:33 ` bug#55495: resolved by bug#56120 Taiju HIGASHI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB2BAAEA-E9F4-41D1-AB73-958434DE52D3@taiju.info \
    --to=higashi@taiju.info \
    --cc=55495@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).