From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jelle Licht Subject: bug#27212: [PATCH] file-systems: Improve error handling in the iso9660 case - fixes boot problem. Date: Sat, 3 Jun 2017 21:57:36 +0200 Message-ID: References: <8737bh0zvt.fsf@fastmail.com> <20170603180013.15853-1-dannym@scratchpost.org> <20170603202500.547f3d47@scratchpost.org> <20170603194555.GA23491@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHFBV-00015Q-IE for bug-guix@gnu.org; Sat, 03 Jun 2017 15:58:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHFBS-0003xt-B5 for bug-guix@gnu.org; Sat, 03 Jun 2017 15:58:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51503) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHFBS-0003xc-7C for bug-guix@gnu.org; Sat, 03 Jun 2017 15:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dHFBR-00055t-TV for bug-guix@gnu.org; Sat, 03 Jun 2017 15:58:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <20170603194555.GA23491@jasmine> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Leo Famulari Cc: 27212@debbugs.gnu.org Leo Famulari writes: > On Sat, Jun 03, 2017 at 08:25:00PM +0200, Danny Milosavljevic wrote: >> Hi, >> >> sorry for the slip-up. >> >> The error handling in 203a9455c4695152fc5d0085bffeead9ce3216c2 was improved >> for the case when there's no iso9660 primary volume descriptor anywhere and no >> terminator either. In that case the CD is broken. >> >> But if there's no iso9660 volume descriptor AT ALL (primary or not) it's not a >> fatal error for guix gnu/build/file-systems.scm - it just means we picked the >> wrong filesystem type and should try the next one. This case was not handled >> correctly and this patch addresses this. >> >> I'd like help with testing this patch. If someone with a fast computer could >> apply this patch, then run make check-system, and then, if everything worked, >> run guix system reconfigure /etc/config.scm , that would be great (my computer >> is building guix master for the last 3 days and probably needs 4 more - so no >> idea whether the patch works). > > I don't have access to a fast GuixSD system today. > > How about reverting the original change now, so that we can reduce the number of > people who hit the bug. Then we can test the revised commit afterwards. Good news! My system boots again after applying your patch and reconfiguring. The make check-system fails a network related test, but only because of an unrelated problem, as this already happened before any of these problems started. - Jelle