bug#28840: openrct2 cannot find data-path

bug#28840: openrct2 cannot find data-path

[Jelle Licht]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

The recently committed (and awesome) openrct2 built correctly,
but cannot currently find the needed language and shader files
for the game and therefore crashes. To make it work, I currently
have to invoke it via a command like
`--openrct-data-path=/gnu/store/<hash>-openrct2-0.1.1/share/openrct2/',
which imho is not optimal.

I dove into the source of openrct, and it seems there are still
some vestiges of the cmake flag we want, namely
ORCT2_RESOURCE_DIR. Sadly, support for configuring this variable
seems to have been removed about 4 months ago.

I opened an issue upstream regarding this[1], but maybe there is
an easy workaround we can use until a fix is hopefully released.
I was thinking of either a phase which calls `wrap-program', or
adding the required flag back via a short snippet.

- Jelle


[1]: https://github.com/OpenRCT2/OpenRCT2/issues/6473


p.s. Besides these rather small issues, I can confirm that OpenRCT2
works.

[-- Attachment #2: Type: text/html, Size: 1333 bytes --]

bug#28840: openrct2 cannot find data-path

[Ludovic Courtès]

Hi Jelle,

Jelle Licht <wordempire@gmail.com> skribis:

> The recently committed (and awesome) openrct2 built correctly,
> but cannot currently find the needed language and shader files
> for the game and therefore crashes. To make it work, I currently
> have to invoke it via a command like
> `--openrct-data-path=/gnu/store/<hash>-openrct2-0.1.1/share/openrct2/',
> which imho is not optimal.
>
> I dove into the source of openrct, and it seems there are still
> some vestiges of the cmake flag we want, namely
> ORCT2_RESOURCE_DIR. Sadly, support for configuring this variable
> seems to have been removed about 4 months ago.
>
> I opened an issue upstream regarding this[1], but maybe there is
> an easy workaround we can use until a fix is hopefully released.
> I was thinking of either a phase which calls `wrap-program', or
> adding the required flag back via a short snippet.

Are you talking about the game assets, or is it something different?

(Did you see the discussion at
<https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28794#8>?)

Cheers,
Ludo’.

bug#28840: openrct2 cannot find data-path

[Jelle Licht]

[-- Attachment #1: Type: text/plain, Size: 1516 bytes --]

Hi Ludo,

No, I am talking about resources such as shaders and
language packs, which seem to be included in openrct2 itself.
IOW, even *with* the data files from the proprietary rct2, our current
openrct2
does not run without the command line flags I added to my first posting :-).

Cheers,
Jelle

2017-10-20 18:01 GMT+02:00 Ludovic Courtès <ludo@gnu.org>:

> Hi Jelle,
>
> Jelle Licht <wordempire@gmail.com> skribis:
>
> > The recently committed (and awesome) openrct2 built correctly,
> > but cannot currently find the needed language and shader files
> > for the game and therefore crashes. To make it work, I currently
> > have to invoke it via a command like
> > `--openrct-data-path=/gnu/store/<hash>-openrct2-0.1.1/share/openrct2/',
> > which imho is not optimal.
> >
> > I dove into the source of openrct, and it seems there are still
> > some vestiges of the cmake flag we want, namely
> > ORCT2_RESOURCE_DIR. Sadly, support for configuring this variable
> > seems to have been removed about 4 months ago.
> >
> > I opened an issue upstream regarding this[1], but maybe there is
> > an easy workaround we can use until a fix is hopefully released.
> > I was thinking of either a phase which calls `wrap-program', or
> > adding the required flag back via a short snippet.
>
> Are you talking about the game assets, or is it something different?
>
> (Did you see the discussion at
> <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28794#8>?)
>
> Cheers,
> Ludo’.
>

[-- Attachment #2: Type: text/html, Size: 2196 bytes --]

bug#28840: openrct2 cannot find data-path

[Ludovic Courtès]

Hello,

Jelle Licht <jlicht@fsfe.org> skribis:

> No, I am talking about resources such as shaders and
> language packs, which seem to be included in openrct2 itself.
> IOW, even *with* the data files from the proprietary rct2, our current
> openrct2
> does not run without the command line flags I added to my first posting :-).

Oh, I see.  Rutger, does that ring a bell?

  https://bugs.gnu.org/28840

Thanks,
Ludo’.

bug#28840: openrct2 cannot find data-path

[Rutger Helling]

[-- Attachment #1.1: Type: text/plain, Size: 703 bytes --]

Hi Ludo and Jelle, 

I've attached a patch that fixed the issue for me by changing some
references from /usr/share to /gnu/store/<hash>-openrct2-0.1.1/share.
I can now run openrct2 without the additional parameter. 

On 2017-10-20 22:21, ludo@gnu.org wrote:

> Hello,
> 
> Jelle Licht <jlicht@fsfe.org> skribis:
> 
>> No, I am talking about resources such as shaders and
>> language packs, which seem to be included in openrct2 itself.
>> IOW, even *with* the data files from the proprietary rct2, our current
>> openrct2
>> does not run without the command line flags I added to my first posting :-).
> 
> Oh, I see.  Rutger, does that ring a bell?
> 
> https://bugs.gnu.org/28840
> 
> Thanks,
> Ludo'.

[-- Attachment #1.2: Type: text/html, Size: 1474 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-openrct2-Fix-a-few-paths.patch --]
[-- Type: text/x-diff; name=0001-gnu-openrct2-Fix-a-few-paths.patch, Size: 1139 bytes --]

From 4c2af88af74f3efe319f23e9716f9ca41f70e618 Mon Sep 17 00:00:00 2001
From: Rutger Helling <rhelling@mykolab.com>
Date: Sat, 21 Oct 2017 10:33:30 +0200
Subject: [PATCH] gnu: openrct2: Fix a few paths.

* gnu/packages/games.scm (openrct2): Fix a few paths.
---
 gnu/packages/games.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 6709f0292..657c23c4e 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -2647,6 +2647,12 @@ Transport Tycoon Deluxe.")
      `(#:tests? #f ;; no tests available
        #:phases
         (modify-phases %standard-phases
+          (add-after 'unpack 'fix-usr-share-paths
+            (lambda* (#:key make-flags outputs #:allow-other-keys)
+              ;; Fix some references to /usr/share.
+              (substitute* "src/openrct2/platform/linux.c"
+                (("/usr/share")
+                (string-append (assoc-ref %outputs "out") "/share")))))
           (add-after 'build 'fix-cmake-install-file
             (lambda _
               ;; The build system tries to download a file and compare hashes.
-- 
2.14.2

bug#28840: openrct2 cannot find data-path

[Jelle Licht]

Rutger Helling <rhelling@mykolab.com> writes:

> Hi Ludo and Jelle,
>
> I've attached a patch that fixed the issue for me by changing some
> references from /usr/share to /gnu/store/<hash>-openrct2-0.1.1/share.
> I can now run openrct2 without the additional parameter.

I can confirm that Rutger's patch works as intented.

bug#28840: openrct2 cannot find data-path

[Ludovic Courtès]

Hello,

Jelle Licht <jlicht@fsfe.org> skribis:

> Rutger Helling <rhelling@mykolab.com> writes:
>
>> Hi Ludo and Jelle,
>>
>> I've attached a patch that fixed the issue for me by changing some
>> references from /usr/share to /gnu/store/<hash>-openrct2-0.1.1/share.
>> I can now run openrct2 without the additional parameter.
>
> I can confirm that Rutger's patch works as intented.

Awesome.  Could you push it?

Thanks,
Ludo’.

bug#28840: openrct2 cannot find data-path

[Jelle Licht]

Ludovic Courtès <ludo@gnu.org> writes:

> Hello,
>
> Jelle Licht <jlicht@fsfe.org> skribis:
>
>> Rutger Helling <rhelling@mykolab.com> writes:
>>
>>> Hi Ludo and Jelle,
>>>
>>> I've attached a patch that fixed the issue for me by changing some
>>> references from /usr/share to /gnu/store/<hash>-openrct2-0.1.1/share.
>>> I can now run openrct2 without the additional parameter.
>>
>> I can confirm that Rutger's patch works as intented.
>
> Awesome.  Could you push it?

Pushed as 2e205c619334 on master.