From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4CQHDZHC02ExUQAAgWs5BA (envelope-from ) for ; Tue, 04 Jan 2022 04:44:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id kHVoCpHC02FPEQAA9RJhRA (envelope-from ) for ; Tue, 04 Jan 2022 04:44:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CC156EE25 for ; Tue, 4 Jan 2022 04:44:16 +0100 (CET) Received: from localhost ([::1]:46228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n4akB-0003CC-Qk for larch@yhetil.org; Mon, 03 Jan 2022 22:44:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4ajy-0003Bp-Em for bug-guix@gnu.org; Mon, 03 Jan 2022 22:44:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53379) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n4ajy-0007I9-6G for bug-guix@gnu.org; Mon, 03 Jan 2022 22:44:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n4ajy-00048g-3Y for bug-guix@gnu.org; Mon, 03 Jan 2022 22:44:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#52908: 'tests/guix-system.sh' fails on aarch64-linux Resent-From: Aiko Kyle Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 04 Jan 2022 03:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52908 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Chris Marusich Received: via spool by 52908-submit@debbugs.gnu.org id=B52908.164126782915881 (code B ref 52908); Tue, 04 Jan 2022 03:44:02 +0000 Received: (at 52908) by debbugs.gnu.org; 4 Jan 2022 03:43:49 +0000 Received: from localhost ([127.0.0.1]:36692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4ajl-000484-0m for submit@debbugs.gnu.org; Mon, 03 Jan 2022 22:43:49 -0500 Received: from mail-lf1-f41.google.com ([209.85.167.41]:34316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4ajh-00047o-40 for 52908@debbugs.gnu.org; Mon, 03 Jan 2022 22:43:47 -0500 Received: by mail-lf1-f41.google.com with SMTP id o12so78911311lfk.1 for <52908@debbugs.gnu.org>; Mon, 03 Jan 2022 19:43:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l+VRunWDV5E6pGoz5vX42GAZk5me7+HwUHKSlspTeUM=; b=Mgm99X96sdOhtGxTxtYswz3JavtLl7B2GNEZuZ4I7pF0wL25asN2Ka3otee4Va/jDL D6VIZ9mv/kkhjmm6lLxAzSlm4yAJb5aB/ehbJmPX4AJbLkY+92puXQI+U5WfGKhmU6x1 MChjdQnUO8ACNRWZmR7UgclefW9QI4xbVEIGQxX/QG8FxpFekio7DHc9GvInqFah9qDh TtPmna4mVvJG5mje05i1bQBHVCXCW1qS2drteA5QkvBCLEHLyywXQrPiuqpCiMkmB7HN wdXpRMLXUTIh2bzG5vMfM4d0tdI9wbgjdwAFQIXxVno+ZpXwgBQoAwDm6YaU8bWcJHGX AaDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l+VRunWDV5E6pGoz5vX42GAZk5me7+HwUHKSlspTeUM=; b=haiFzRPder48V1D+UaNw2ITNNyLUSN45Fxu8O5A8AV/cXKyzh7mtkpXjFzXczvLFl6 V3umBJv9r6W88xDNG7omQjF8OhbXa3D43iNv/UexBYsFamyu4ao63CCr3FkWg33U3xTJ XDFy3d5a5pUcnKDvpeE3XhI44DUe7ozfNgGblWniv+Z37KmI/s6bnB0FqSUotmOKAJ1y wy52zMiWgDFb3bralQKMjyAjTHra8bmyFTqc50gTE1+VOlIqt0/HW6dhOGQm8bMgJ+3u A8Q9h9wXyhUE4q4yBDM18CIJK2bJrvcltC+6kmM6OHE9ZWTYlZCgFWzBBDwQ98qJwGBM wfcA== X-Gm-Message-State: AOAM530xkFhrAYndvcI7C3sT17HNP7/NO21TFAbRLs1V+b5gz3cTKaVG LzRQMduO7Ayf3tuDdZrRMcnoevYrKmK6WLcvtw4= X-Google-Smtp-Source: ABdhPJyCi0x5/viFfJhNRqjWvxqgBksLj7284etZQYB6YlxqjzLgKENpRq3GHaTrp2mh56SQqAma84fS5AQr9VJZjg8= X-Received: by 2002:a05:6512:3182:: with SMTP id i2mr40243523lfe.673.1641267819005; Mon, 03 Jan 2022 19:43:39 -0800 (PST) MIME-Version: 1.0 References: <87wnjgqm93.fsf@gmail.com> In-Reply-To: <87wnjgqm93.fsf@gmail.com> From: Aiko Kyle Date: Mon, 3 Jan 2022 20:43:27 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 52908@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641267856; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=l+VRunWDV5E6pGoz5vX42GAZk5me7+HwUHKSlspTeUM=; b=NeMrLG44XsWaAJK07MyDTTZjAbo5Rnj62hRFDZQHFXZYRZ2sEWiN5BHxsI124H8VG1L7WL sp9GnAUb731gi8PWp/f8fTKE+SZvSJShCAscIMFhTe/D3AINHuH4IKNlhay2KdfjkXaTlW +iQmR9Sl3My2uUAdkCX3XFl81PjYhT86puvqOw5PfnmgEyevCLvEP43j5Jy1eKQ+ZqmZsS sXHsX6gY/oNOXy/g3sf6fYt3iRGnZIxtO/SgxIQIoCh+ERgMRU0QXz0BUrrHFDoDFMn8Tq 7SSLs8B21v7sRJ3TV+40lzxysa0KlwuoNT4Rf+U/6KBFBZHHOTPNV7v8GOngLQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641267856; a=rsa-sha256; cv=none; b=cIvPBo+MAiCLbhDg/fmOT/KQr+fK56HxEUux0UafF60nvw4sDsWzug1lXW5p6CgQ7Iy5TR xrXIQiBEzujEBztGk9jjxHyS6JfdiTlPZsCrx3waY5xjCaT+XaxdPk5eXf5ZMfnETulIT3 PZuipGofT4C4AJwvq0Y/Ei5Rt/EOm3wuHNfBADLK/4cUkvAGV3zeWt2cXeUJfEfFkiG+yw y3Linvj1Uq4lxAB7sN8u0kSt1Ss3fV4EBL60zc7jQoBOa76h0od+1kbj8cfZSzlpyth+54 7W5cM/wZ4J1o9FP0wf2bgIPxMxigYPSNfZZuwsxSaC5xAD6YmcrZf6q08LheMA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Mgm99X96; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.99 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Mgm99X96; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CC156EE25 X-Spam-Score: -1.99 X-Migadu-Scanner: scn1.migadu.com X-TUID: BHJIbsE03po1 On Mon, Jan 3, 2022 at 7:15 PM Chris Marusich wrote: > > Aiko's patch would indeed fix the failing test. Thank you, Aiko, for > taking the initiative to help investigate and solve the issue! However, > even though that patch would fix the test, anyone who is using > set-xorg-configuration on a non-x86_64 system would still need to change > the way they call it, which is not ideal. > > I've attached a different patch that attempts to fix the issue without > requiring callers of set-xorg-configuration to update their code. I > believe this is more consistent with the intent of Ludo's original > change in commit 49599fab564f203b8e92d32e9b28c99e99849bfb. > > You'll notice that this patch moves the (gnu services sddm) code into > (gnu services xorg) and deprecates (gnu services sddm). I did this in > order to avoid a circular dependency between the two modules. Perhaps > there's a better way. However, many of the existing display managers > already live in (gnu services xorg), so it seemed reasonable to me. > I originally tried to implement this patch, but as a relative newcomer to guix and guile scheme, I went for the easier patch of changing the tests since I wasn't sure which would be the preferred way to fix this issue. I'll defer to you and Leo for that judgment! > I've verified that the tests/guix-system.sh test passes on > powerpc64le-linux after applying this patch to current master branch (on > top of commit 9309b488ca4ceef4fcc9283546e3b05c57b16ca8). I've also > verified that the deprecation warnings are being emitted, and that the > existing bindings in (gnu services sddm) are still usable, at the REPL: > Commit 9309b48 seems to be a week old and I can't seem to apply this patch on top of the latest commit on master e6fe4e5819.