From: Aiko Kyle <aikokyle@gmail.com>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: 52908@debbugs.gnu.org
Subject: bug#52908: 'tests/guix-system.sh' fails on aarch64-linux
Date: Mon, 3 Jan 2022 20:43:27 -0700 [thread overview]
Message-ID: <CAPWcbYHDLkQxxO4Y+Z=FCC6jDprUm_NfYF1rBDaJDn40KP+Duw@mail.gmail.com> (raw)
In-Reply-To: <87wnjgqm93.fsf@gmail.com>
On Mon, Jan 3, 2022 at 7:15 PM Chris Marusich <cmmarusich@gmail.com> wrote:
>
> Aiko's patch would indeed fix the failing test. Thank you, Aiko, for
> taking the initiative to help investigate and solve the issue! However,
> even though that patch would fix the test, anyone who is using
> set-xorg-configuration on a non-x86_64 system would still need to change
> the way they call it, which is not ideal.
>
> I've attached a different patch that attempts to fix the issue without
> requiring callers of set-xorg-configuration to update their code. I
> believe this is more consistent with the intent of Ludo's original
> change in commit 49599fab564f203b8e92d32e9b28c99e99849bfb.
>
> You'll notice that this patch moves the (gnu services sddm) code into
> (gnu services xorg) and deprecates (gnu services sddm). I did this in
> order to avoid a circular dependency between the two modules. Perhaps
> there's a better way. However, many of the existing display managers
> already live in (gnu services xorg), so it seemed reasonable to me.
>
I originally tried to implement this patch, but as a relative newcomer
to guix and guile scheme, I went for the easier patch of changing the
tests since I wasn't sure which would be the preferred way to fix this
issue. I'll defer to you and Leo for that judgment!
> I've verified that the tests/guix-system.sh test passes on
> powerpc64le-linux after applying this patch to current master branch (on
> top of commit 9309b488ca4ceef4fcc9283546e3b05c57b16ca8). I've also
> verified that the deprecation warnings are being emitted, and that the
> existing bindings in (gnu services sddm) are still usable, at the REPL:
>
Commit 9309b48 seems to be a week old and I can't seem to apply this
patch on top of the latest commit on master e6fe4e5819.
next prev parent reply other threads:[~2022-01-04 3:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 23:52 bug#52908: 'tests/guix-system.sh' fails on aarch64-linux Leo Famulari
2022-01-04 2:15 ` Chris Marusich
2022-01-04 3:43 ` Aiko Kyle [this message]
2022-01-04 4:53 ` Chris Marusich
2022-01-04 5:08 ` Aiko Kyle
2022-01-05 9:58 ` Chris Marusich
2022-01-05 10:47 ` Pierre Langlois
2022-01-06 7:28 ` Chris Marusich
2022-01-05 17:34 ` Aiko Kyle
2022-01-04 17:28 ` Leo Famulari
2022-01-06 16:39 ` Ludovic Courtès
2022-01-07 4:32 ` Chris Marusich
2022-01-07 10:48 ` Maxime Devos
2022-01-09 4:42 ` Chris Marusich
2022-01-08 1:26 ` Aiko Kyle
2022-01-08 2:18 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPWcbYHDLkQxxO4Y+Z=FCC6jDprUm_NfYF1rBDaJDn40KP+Duw@mail.gmail.com' \
--to=aikokyle@gmail.com \
--cc=52908@debbugs.gnu.org \
--cc=cmmarusich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).