unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Akira Kyle <akira@akirakyle.com>
To: Leo Famulari <leo@famulari.name>
Cc: 52943@debbugs.gnu.org
Subject: bug#52943: Cannot build guix as part of guix system reconfigure after commit 224d437fb4 on aarch64
Date: Mon, 3 Jan 2022 14:38:01 -0700	[thread overview]
Message-ID: <CAPWcbYEUitbYDjfhfwwNJvysUkPmt-RLVjuNvQ=U0hRbBT=jLQ@mail.gmail.com> (raw)
In-Reply-To: <CAPWcbYEjhSWsXR41ivHUZfthUje_i0rc1P8p_8KYqw8ibtjJEg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 121 bytes --]

The attached patch fixes the failing guix-system.sh test on aarch64.
However there are now other tests that are failing.

[-- Attachment #2: 0001-tests-guix-system-Fix-on-non-x86_64-systems.patch --]
[-- Type: application/octet-stream, Size: 2913 bytes --]

From e2a6d4c4043a1e149a5eb99343fc6049ba2778bb Mon Sep 17 00:00:00 2001
From: Akira Kyle <akira@akirakyle.com>
Date: Mon, 3 Jan 2022 14:23:46 -0700
Subject: [PATCH] tests: guix-system: Fix on non-x86_64 systems

Addresses issue 52943 caused by commit 49599fab56

* gnu/system/examples/desktop.tmpl: explicitly set optional
login-manager-service-type argument

* gnu/system/examples/vm-image.tmpl: also remove sddm-service-type from
%desktop-services
---
 gnu/system/examples/desktop.tmpl  | 12 +++++++++---
 gnu/system/examples/vm-image.tmpl |  3 ++-
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/gnu/system/examples/desktop.tmpl b/gnu/system/examples/desktop.tmpl
index a209fbcb05..aec0466cb6 100644
--- a/gnu/system/examples/desktop.tmpl
+++ b/gnu/system/examples/desktop.tmpl
@@ -2,8 +2,8 @@
 ;; for a "desktop" setup with GNOME and Xfce where the
 ;; root partition is encrypted with LUKS, and a swap file.
 
-(use-modules (gnu) (gnu system nss))
-(use-service-modules desktop xorg)
+(use-modules (gnu) (gnu system nss) (guix utils))
+(use-service-modules desktop xorg sddm)
 (use-package-modules certs gnome)
 
 (operating-system
@@ -78,7 +78,13 @@
                           (service xfce-desktop-service-type)
                           (set-xorg-configuration
                            (xorg-configuration
-                            (keyboard-layout keyboard-layout))))
+                            (keyboard-layout keyboard-layout))
+                           ;; See comment in desktop-services-for-system
+                           (if (string-prefix? "x86_64"
+                                               (or (%current-target-system)
+                                                   (%current-system)))
+                               gdm-service-type
+                               sddm-service-type)))
                     %desktop-services))
 
   ;; Allow resolution of '.local' host names with mDNS.
diff --git a/gnu/system/examples/vm-image.tmpl b/gnu/system/examples/vm-image.tmpl
index a59d91587b..bd9b6b8402 100644
--- a/gnu/system/examples/vm-image.tmpl
+++ b/gnu/system/examples/vm-image.tmpl
@@ -5,7 +5,7 @@
 ;;
 
 (use-modules (gnu) (guix) (srfi srfi-1))
-(use-service-modules desktop mcron networking spice ssh xorg)
+(use-service-modules desktop mcron networking spice ssh xorg sddm)
 (use-package-modules bootloaders certs fonts nvi
                      package-management wget xorg)
 
@@ -113,6 +113,7 @@ root ALL=(ALL) ALL
                      (let ((type (service-kind service)))
                        (or (memq type
                                  (list gdm-service-type
+                                       sddm-service-type
                                        wpa-supplicant-service-type
                                        cups-pk-helper-service-type
                                        network-manager-service-type
-- 
2.34.0


  reply	other threads:[~2022-01-03 21:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-01 23:54 bug#52943: Cannot build guix as part of guix system reconfigure after commit 224d437fb4 on aarch64 Aiko Kyle
2022-01-02  2:13 ` Leo Famulari
2022-01-02  4:11   ` Aiko Kyle
2022-01-02  4:51     ` Leo Famulari
2022-01-02  6:36       ` Aiko Kyle
2022-01-03 21:38         ` Akira Kyle [this message]
2022-01-04  1:13           ` Akira Kyle
2022-01-04  1:16             ` Akira Kyle
2022-01-09  4:39 ` Chris Marusich
2022-01-15 13:27   ` Pierre Langlois
2022-01-16  1:00     ` Chris Marusich
2022-01-17  4:46       ` Chris Marusich
2022-01-17 18:51         ` Pierre Langlois
2022-01-18  5:33           ` Vagrant Cascadian
2022-01-19 19:28             ` Vagrant Cascadian
2022-01-29 18:33               ` Leo Famulari
2022-01-29 20:54                 ` Pierre Langlois
2022-01-29 21:06                   ` Leo Famulari
2022-01-29 21:35                     ` Pierre Langlois
2022-10-07  8:48                 ` Christopher Baines
2022-10-20 14:57                   ` Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPWcbYEUitbYDjfhfwwNJvysUkPmt-RLVjuNvQ=U0hRbBT=jLQ@mail.gmail.com' \
    --to=akira@akirakyle.com \
    --cc=52943@debbugs.gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).