bug#50883: Suckless packages marked as 'x11' instead of 'expat'

bug#50883: Suckless packages marked as 'x11' instead of 'expat'

[Sarah Morgensen]

Hello Guix,

It seems like some packages in suckless.scm are listed as having an
'x11' license when they are in fact 'expat' (as listed on
directory.fsf.org and confirmed by visual inspection).

I only checked three: dwm, dmenu, and st; but I suspect there are many
more.

(Perhaps at some point we should write a linter to check for potential
license discrepancies?)

--
Sarah

bug#50883: Suckless packages marked as 'x11' instead of 'expat'

[Maxim Cournoyer]

Hi Sarah,

Sarah Morgensen <iskarian@mgsn.dev> writes:

> Hello Guix,
>
> It seems like some packages in suckless.scm are listed as having an
> 'x11' license when they are in fact 'expat' (as listed on
> directory.fsf.org and confirmed by visual inspection).
>
> I only checked three: dwm, dmenu, and st; but I suspect there are many
> more.
>
> (Perhaps at some point we should write a linter to check for potential
> license discrepancies?)

Thanks for the report!

If you had time for a patch, that'd be great!

Thank you,

Maxim

bug#50883: change x11 to expat licenses

[Alex Devaure]

Hi,
I created a patch to update the licenses.
Alex

From f8e0672bbccc31f0b29c453f5f46e9b01008784e Mon Sep 17 00:00:00 2001
From: Alex Devaure <ajadevaure@gmail.com>
Date: Sun, 29 Jan 2023 18:41:28 +0000
Subject: [PATCH] suckless licenses fix

---
 gnu/packages/suckless.scm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index 8844482cc9..92a9654724 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -274,7 +274,7 @@ (define-public dwm
      "dwm is a dynamic window manager for X.  It manages windows in tiled,
 monocle and floating layouts.  All of the layouts can be applied dynamically,
 optimising the environment for the application in use and the task performed.")
-    (license license:x11)))
+    (license license:expat)))
 
 (define-public dmenu
   (package
@@ -305,7 +305,7 @@ (define-public dmenu
     (description
      "A dynamic menu for X, originally designed for dwm.  It manages large
 numbers of user-defined menu items efficiently.")
-    (license license:x11)))
+    (license license:expat)))
 
 (define-public spoon
   (package
@@ -358,7 +358,7 @@ (define-public slock
     (synopsis "Simple X session lock")
     (description
      "Simple X session lock with trivial feedback on password entry.")
-    (license license:x11)))
+    (license license:expat)))
 
 (define-public st
   (package
@@ -398,7 +398,7 @@ (define-public st
 implements 256 colors, most VT10X escape sequences, utf8, X11 copy/paste,
 antialiased fonts (using fontconfig), fallback fonts, resizing, and line
 drawing.")
-    (license license:x11)))
+    (license license:expat)))
 
 (define-public xst
   (package
@@ -527,7 +527,7 @@ (define-public surf
 display websites and follow links.  It supports the XEmbed protocol which
 makes it possible to embed it in another application.  Furthermore, one can
 point surf to another URI by setting its XProperties.")
-    (license license:x11)))
+    (license license:expat)))
 
 (define-public sent
   (package
@@ -576,7 +576,7 @@ (define-public sent
 allows you to write down the presentation for a quick lightning talk within a
 few minutes.")
     (home-page "https://tools.suckless.org/sent/")
-    (license license:x11)))
+    (license license:expat)))
 
 (define-public wmname
   (package
-- 
2.39.1

bug#50883: Suckless packages marked as 'x11' instead of 'expat'

[Арсений]

[-- Attachment #1: Type: text/html, Size: 319 bytes --]

bug#50883: Suckless packages marked as 'x11' instead of 'expat'

[Arseniy Zaostrovnykh]

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

> Hi,
> I created a patch to update the licenses.
> Alex

Hello,
It looks like the patch was never applied. Was there any issue with it?

-- 
Yours respectfully,
Arseniy(aka Necto).

[-- Attachment #2: Type: text/html, Size: 323 bytes --]