unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Cameron Chaparro <cameron@cameronchaparro.com>
To: 54150@debbugs.gnu.org
Subject: bug#54150: openvpn-shepherd-service is not writing log files
Date: Thu, 24 Feb 2022 16:11:01 -0600	[thread overview]
Message-ID: <CAN85xJm0Fv4QOgkertiBu5ZEdoz=VAqBoLrCaGH9nKzQA8D6zw@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 193 bytes --]

I noticed that the `openvpn-shepherd-service' is defining, but not
actually using, the log file when starting the client/server. I think
this patch should address that issue.

Cameron Chaparro

[-- Attachment #1.2: Type: text/html, Size: 268 bytes --]

[-- Attachment #2: 0001-gnu-Add-log-file-option-when-starting-openvpn-shephe.patch --]
[-- Type: text/x-patch, Size: 1425 bytes --]

From 372f3b8a2f2900bca5a55208a07940e6b70ddded Mon Sep 17 00:00:00 2001
Message-Id: <372f3b8a2f2900bca5a55208a07940e6b70ddded.1645740586.git.cameron@cameronchaparro.com>
From: Cameron Chaparro <cameron@cameronchaparro.com>
Date: Thu, 24 Feb 2022 15:49:15 -0600
Subject: [PATCH] gnu: Add #:log-file option when starting openvpn shepherd
 services

---
 gnu/services/vpn.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/services/vpn.scm b/gnu/services/vpn.scm
index 3e370ba4be..b24e9cffb3 100644
--- a/gnu/services/vpn.scm
+++ b/gnu/services/vpn.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2021 Raghav Gururajan <rg@raghavgururajan.name>
 ;;; Copyright © 2021 jgart <jgart@dismail.de>
 ;;; Copyright © 2021 Nathan Dehnel <ncdehnel@gmail.com>
+;;; Copyright © 2022 Cameron V Chaparro <cameron@cameronchaparro.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -494,7 +495,8 @@ (define (openvpn-shepherd-service role)
                        (list (string-append #$openvpn "/sbin/openvpn")
                              "--writepid" #$pid-file "--config" #$config-file
                              "--daemon")
-                       #:pid-file #$pid-file))
+                       #:pid-file #$pid-file
+                       #:log-file #$log-file))
              (stop #~(make-kill-destructor)))))))
 
 (define %openvpn-accounts

base-commit: 979b6a2c55fab729923d76ac9fee027d5d2d8f2b
-- 
2.34.0


                 reply	other threads:[~2022-02-24 22:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN85xJm0Fv4QOgkertiBu5ZEdoz=VAqBoLrCaGH9nKzQA8D6zw@mail.gmail.com' \
    --to=cameron@cameronchaparro.com \
    --cc=54150@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).