From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wMwAMe7e2GSX9wAASxT56A (envelope-from ) for ; Sun, 13 Aug 2023 15:47:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yN7hMO7e2GSJTQEA9RJhRA (envelope-from ) for ; Sun, 13 Aug 2023 15:47:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4815364175 for ; Sun, 13 Aug 2023 15:47:26 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=jOpDj52l; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1691934446; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=wle3iESEzPLxO955WUV9p+7OXHApKzeeWgwTMdwlskc=; b=jaf/DQDVIXQjTqJiavRNhPw4xJvscQtijZi4UIbPhEPB3d1h7LXponxPgDFDD300/ehAV0 EY1O5owocddLrrW6oRrwCn/hOj6+0uG75AQF4Cayjif6Gh/+gng2HSso21GkTV1jE1YtGG jFWT6RbjzczKLnvn8i6E+SmEngIso+2WzOzyiLVJtl6zWk9qmyT89L7LDDe0Iw5aB+mla/ c9k7iWCLlK3V/F2PFVPZQ3eEILNMjy4YcTJ89jaRbVNCAZsizFLwvNxrnUABpfnGNUW022 G8nEa5sy+8ZCKEgIGKVmO2dvOckCZAK0SdBn8uxtjbGq0SymB94rLWVUNDggzw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=jOpDj52l; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1691934446; a=rsa-sha256; cv=none; b=XrQIFfaAGxcbEPA2OP+5+JFny2/VpdEmEcg5Hn7qZZpa5oabFO9FhICh+SVnBj8jKS2g1e l4B+qHaTgSG7f/L7lU5TtieIGoY4Vsfui4/HBU1bpCt+O68PzgXKcPJ/y+gidfVx+A7TdV LddaIY5+y9snz+u/UkPktDYMMqDwYulu2cYr0tCC4gfYsLpbJy9QsQydR2wXWthAQboVUp DC+mn0z+hc0+KgRfVfjs//NwCfS8Bp7fdfZfya2VZlmhUg4vJxAHoOx+v86STQoz3Ssb2H owkB7V+K1hqJZ7FcMtf2dlcFHpSWDUnTrBBjnwoakwd5eEKTutqimpDZhjS19A== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVBQp-00023Y-UC; Sun, 13 Aug 2023 09:46:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUtND-0005G0-LI for bug-guix@gnu.org; Sat, 12 Aug 2023 14:30:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUtND-0003CT-Bp for bug-guix@gnu.org; Sat, 12 Aug 2023 14:30:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qUtNC-0004r6-RS for bug-guix@gnu.org; Sat, 12 Aug 2023 14:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#65218: emacs-orderless 1.0 shows as 0.8 due to incorrect value in package file Resent-From: Piotr =?UTF-8?Q?Kwieci=C5=84ski?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 12 Aug 2023 18:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65218 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Hilton Chain Cc: 65218@debbugs.gnu.org Received: via spool by 65218-submit@debbugs.gnu.org id=B65218.169186497618594 (code B ref 65218); Sat, 12 Aug 2023 18:30:02 +0000 Received: (at 65218) by debbugs.gnu.org; 12 Aug 2023 18:29:36 +0000 Received: from localhost ([127.0.0.1]:57429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUtMm-0004pq-7w for submit@debbugs.gnu.org; Sat, 12 Aug 2023 14:29:36 -0400 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:51538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUtMk-0004pY-6o for 65218@debbugs.gnu.org; Sat, 12 Aug 2023 14:29:35 -0400 Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2b9cd6a554cso44648631fa.3 for <65218@debbugs.gnu.org>; Sat, 12 Aug 2023 11:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691864968; x=1692469768; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wle3iESEzPLxO955WUV9p+7OXHApKzeeWgwTMdwlskc=; b=jOpDj52lZcFU+w0bskQXjAaAO0O57AXgBld8myMoCg23ZD65MIpSsJSHCCQbWXAIIv 4FjT+7Gt1qdnQECVuYzWjQAnsK2F3/Asc8szAh9lpaTQiP8BDQ8+eNrZR4uFXDqSF+a3 xy5JaaajqAemiPtg3BnwFGVvU7DzXk5zqD3OyBkp1MW5tPdoHxnKEZapBq12ahw2ZtAA PiBV6oLB81+vwYqrCYMtTilR5Gfg6uGXnDaRpL3UeDgrUog/tmTXgTHCpmQlMNVuEyQ9 GoLrW7iXgvHO2hjgT+3zqbV9jloE27tZVtzrRKDWh7oraFDLfrjceUsvunp+Ppw8ccKU CktA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691864968; x=1692469768; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wle3iESEzPLxO955WUV9p+7OXHApKzeeWgwTMdwlskc=; b=cy6loc8D/gpIc58pTqYNCuQTD/LwXR0rsrAauUdg/6Z7+gJMZB87EtHeCGWbgeclTb 9r9oO1yQvWsMfqJX9EZ8lNahukpe6HJphCIOlFcvCUFNB7F/A9XteQttzhfi/Zrj5xQe k3+xPo+kcvjBWbvawtAqMgFDQAK7XhNIo/2k6sXQBjgteTA0mw7NGKWoHdRwMmcc+DbG N+ml7UeGt1uruwCmZA9nMP1HqKc06pk1bxn5lBJwa0d9aygQVH54laQEAbm0ChvKoywH kNDc3m5CgQMwlQiGSAvuwFoVRyGETazvHvRruHAGrhNXycL6Ob+GhuqDba4BZU7zVYE/ v/aA== X-Gm-Message-State: AOJu0Yzj9YNEXYgYq1WjO9MQ187xDGXxuJ8MmZ+hF2zbAzksGCF4g3gb TPl/BPszFh9AtwdxeyND6o/kqwa4J+K8EM8wiOc= X-Google-Smtp-Source: AGHT+IEo6q4dLr3eRdLk41L3lhGk2mdmgSztkRRNu03MzpXZdxC065XqbiQsDARL7TTPgpRC/MfGE15VKz9OsJ9/C0Y= X-Received: by 2002:a05:6512:10d4:b0:4f8:7513:8cb0 with SMTP id k20-20020a05651210d400b004f875138cb0mr3976488lfg.2.1691864967499; Sat, 12 Aug 2023 11:29:27 -0700 (PDT) MIME-Version: 1.0 References: <87jzu0qmmg.wl-hako@ultrarare.space> In-Reply-To: <87jzu0qmmg.wl-hako@ultrarare.space> From: Piotr =?UTF-8?Q?Kwieci=C5=84ski?= Date: Sat, 12 Aug 2023 20:29:16 +0200 Message-ID: Content-Type: multipart/alternative; boundary="0000000000006553de0602be022a" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Sun, 13 Aug 2023 09:46:54 -0400 X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: 3.81 X-Migadu-Queue-Id: 4815364175 X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: 3.81 X-TUID: uw8BPr47B6Pa --0000000000006553de0602be022a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Hilton, thank you for your swift response and guidance. I'll attempt to send a patch. I already started to set up my local environment. On Sat, 12 Aug 2023 at 18:12, Hilton Chain wrote: > Hi Piotr, > > On Fri, 11 Aug 2023 04:18:57 +0800, > Piotr Kwieci=C5=84ski wrote: > > > > [1 ] > > [2 ] > > I have the latest version of emacs-orderless installed on using guix an= d > it shows: > > > > Status: External in > =E2=80=98/gnu/store/mp2ckcr7psy9myby262zqii36cd49yja-emacs-orderless-1.0/= share/emacs/site-lisp/orderless-1.0/=E2=80=99 > (unsigned). > > Version: 0.8 > > Summary: Completion style for matching regexps in any order > > > > This is caused by an incorrect version of a package declared in > orderless.el. > > > It seems that emacs-orderless in Guix wasn't really updated to 1.0, > only the version field was changed. > > > > I'm new to the ecosystem and I'm not familiar with the process of fixin= g > this. > > The issue was fixed by the package maintainer in commit > > > https://github.com/oantolin/orderless/commit/847694e78c12d903d5e3f6cb365a= 5d3b984db537 > > > > Would replacing commit in the package definition be enough ? Swapping > 004cee6b8e01f8eb0cb1c683d0a637b14890600f with > > 847694e78c12d903d5e3f6cb365a5d3b984db537 > > > That's not enough, the hash in (sha256 (base32 [...])) needs changing > as well. > > And when updating an untagged revision to a tagged release, we usually > drop the outer let form, and use the value from version field for > commit. > > For example, the original definition: > --8<---------------cut here---------------start------------->8--- > (define-public emacs-orderless > (let ((commit [...])) > (package > (name "emacs-orderless") > (version [...]) > (source > (origin > (method git-fetch) > (uri (git-reference > (url "https://github.com/oantolin/orderless") > (commit commit))) > (file-name (git-file-name name version)) > (sha256 > (base32 [...])))) > [...]))) > --8<---------------cut here---------------end--------------->8--- > > would be changed to: > --8<---------------cut here---------------start------------->8--- > (define-public emacs-orderless > (package > (name "emacs-orderless") > (version "1.0") > (source > (origin > (method git-fetch) > (uri (git-reference > (url "https://github.com/oantolin/orderless") > (commit version))) ; <- see here > (file-name (git-file-name name version)) > (sha256 > (base32 [...])))) ; <- hash is changed as well > [...])) > --8<---------------cut here---------------end--------------->8--- > > BTW the hash can be obtained with `guix hash' [1]: > --8<---------------cut here---------------start------------->8--- > git clone https://[...] emacs-orderless > > cd emacs-orderless > git checkout 1.0 > > guix hash -rx . > --8<---------------cut here---------------end--------------->8--- > > Would you like to get familiar with the process by going through the > way [2] to make your first contribution? ;) > > I can send a patch if you prefer, and it may take a few days to get > the change into Guix. > > Thanks > > > [1]: < > https://guix.gnu.org/en/manual/devel/en/html_node/Invoking-guix-hash.html= > > [2]: > > (Not sure why this issue isn't on the mailing list, but is available > in Debbugs. Still under moderation?) > --=20 Regards Piotr Kwiecinski --0000000000006553de0602be022a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Hilton,
thank you for your sw= ift response=C2=A0and guidance. I'll attempt to send a patch.
I already started to set up my local environment.

On Sat, 12 Aug 2023= at 18:12, Hilton Chain <hako@ul= trarare.space> wrote:
Hi Piotr,

On Fri, 11 Aug 2023 04:18:57 +0800,
Piotr Kwieci=C5=84ski wrote:
>
> [1=C2=A0 <text/plain; UTF-8 (quoted-printable)>]
> [2=C2=A0 <text/html; UTF-8 (quoted-printable)>]
> I have the latest version of emacs-orderless installed on using guix a= nd it shows:
>
>=C2=A0 Status: External in =E2=80=98/gnu/store/mp2ckcr7psy9myby262zqii3= 6cd49yja-emacs-orderless-1.0/share/emacs/site-lisp/orderless-1.0/=E2=80=99 = (unsigned).
> Version: 0.8
> Summary: Completion style for matching regexps in any order
>
> This is caused by an incorrect version of a package declared in orderl= ess.el.


It seems that emacs-orderless in Guix wasn't really updated to 1.0,
only the version field was changed.


> I'm new to the ecosystem and I'm not familiar with the process= of fixing this.
> The issue was fixed by the package maintainer in commit
> https://gi= thub.com/oantolin/orderless/commit/847694e78c12d903d5e3f6cb365a5d3b984db537=
>
> Would replacing commit in the package definition be enough ? Swapping = 004cee6b8e01f8eb0cb1c683d0a637b14890600f with
> 847694e78c12d903d5e3f6cb365a5d3b984db537


That's not enough, the hash in (sha256 (base32 [...])) needs changing as well.

And when updating an untagged revision to a tagged release, we usually
drop the outer let form, and use the value from version field for
commit.

For example, the original definition:
--8<---------------cut here---------------start------------->8---
(define-public emacs-orderless
=C2=A0 (let ((commit [...]))
=C2=A0 =C2=A0 (package
=C2=A0 =C2=A0 =C2=A0 (name "emacs-orderless")
=C2=A0 =C2=A0 =C2=A0 (version [...])
=C2=A0 =C2=A0 =C2=A0 (source
=C2=A0 =C2=A0 =C2=A0 =C2=A0(origin
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(method git-fetch)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(uri (git-reference
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(url "https://github.com/oantolin/orderless")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(commit commit))) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(file-name (git-file-name name version))<= br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(sha256
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32 [...]))))
=C2=A0 =C2=A0 =C2=A0 [...])))
--8<---------------cut here---------------end--------------->8---

would be changed to:
--8<---------------cut here---------------start------------->8---
(define-public emacs-orderless
=C2=A0 (package
=C2=A0 =C2=A0 (name "emacs-orderless")
=C2=A0 =C2=A0 (version "1.0")
=C2=A0 =C2=A0 (source
=C2=A0 =C2=A0 =C2=A0(origin
=C2=A0 =C2=A0 =C2=A0 =C2=A0(method git-fetch)
=C2=A0 =C2=A0 =C2=A0 =C2=A0(uri (git-reference
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(url "http= s://github.com/oantolin/orderless")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(commit version)))=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0; <- see here
=C2=A0 =C2=A0 =C2=A0 =C2=A0(file-name (git-file-name name version))
=C2=A0 =C2=A0 =C2=A0 =C2=A0(sha256
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32 [...]))))=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0; <- hash is changed as well
=C2=A0 =C2=A0 [...]))
--8<---------------cut here---------------end--------------->8---

BTW the hash can be obtained with `guix hash' [1]:
--8<---------------cut here---------------start------------->8---
git clone https://[...] emacs-orderless

cd emacs-orderless
git checkout 1.0

guix hash -rx .
--8<---------------cut here---------------end--------------->8---

Would you like to get familiar with the process by going through the
way [2] to make your first contribution? ;)

I can send a patch if you prefer, and it may take a few days to get
the change into Guix.

Thanks


[1]: <https://guix.gnu.o= rg/en/manual/devel/en/html_node/Invoking-guix-hash.html>
[2]: <https://guix.gnu.org/en/= manual/devel/en/html_node/Contributing.html>

(Not sure why this issue isn't on the mailing list, but is available in Debbugs.=C2=A0 Still under moderation?)


--
Regards
Piotr Kwiecinski
--0000000000006553de0602be022a--