From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 4CDAEfwN2mR3JwEASxT56A (envelope-from ) for ; Mon, 14 Aug 2023 13:20:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KK5oEfwN2mTXNAAAauVa8A (envelope-from ) for ; Mon, 14 Aug 2023 13:20:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ADDD048A99 for ; Mon, 14 Aug 2023 13:20:27 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=pJnNZ8mE; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692012028; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=k96+uMgETeGrkAKDdSQE9mQLTMEhege3CubZNSVzHHw=; b=Q+THMGZsc8sltS1AycTce8ju1dOsuhwbsE+BzlNI2MKRL5paBRa77UFr7QuCa0qTHcG9AS 8GovfKC7lTP2dr3pcMdWxCcj2Y0PW1jzfg1lcR7CIl8hkRoNRfK+bpwxdvm6kPWGj3pvON aIJnhZYYBzrtxxNGLuvSYf8iRREHUwII/td26Lqo04rsKnqRDsezmrU8Lvxy2fhlQm+5k3 kZbzeVw1H74thzrrPBfowCe1/hklOe3aUUDpz05b14tFbxdPvqvvjqyEpPxKNZkwHVm2cC HO8S+4/BqyiaTU5aVgdfPmB6B8D1XBYsCxUdNXJmWy72Pp+MzHAq70ea9mbIdQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=pJnNZ8mE; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692012028; a=rsa-sha256; cv=none; b=aSWPNpC7ITZljeHKD5tP8HW3VVwnKuYrayl96KYzIcMO8hmK3F8gJ27ruE+Q6GfSPTqnxn dAr94f2FsJsXLPZhwlWX7lTFnOBMApBo3yCVXQ+Ps/LI93ri6fAydsxQ59c848GsNJQb4a jjRW63gZHSAO0o2MPv+RdSWeBoTInbNdxsKfuHVD/0HLA5tXdPm9vAW/6JMmOu9Wm675H6 xp2FNb14zEpgSyze6zgSe7971Ad4XHmMN/4pr4x7UD7ODqCwnbuKktkYNBuSxOXX1/ruFX nx55wvIoX2QDpIpPB30buTRuic1+fFtI/xE9OU98MjkUrpl1VI16QP26HNmeUA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVVcM-0000Zb-Fw; Mon, 14 Aug 2023 07:20:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVVcF-0000Yh-M7 for bug-guix@gnu.org; Mon, 14 Aug 2023 07:20:07 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qVVcA-0007hJ-RZ for bug-guix@gnu.org; Mon, 14 Aug 2023 07:20:06 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qVVc9-0003F9-W8 for bug-guix@gnu.org; Mon, 14 Aug 2023 07:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#65218: emacs-orderless 1.0 shows as 0.8 due to incorrect value in package file Resent-From: Piotr =?UTF-8?Q?Kwieci=C5=84ski?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 14 Aug 2023 11:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65218 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Hilton Chain Cc: 65218@debbugs.gnu.org Received: via spool by 65218-submit@debbugs.gnu.org id=B65218.169201199112424 (code B ref 65218); Mon, 14 Aug 2023 11:20:01 +0000 Received: (at 65218) by debbugs.gnu.org; 14 Aug 2023 11:19:51 +0000 Received: from localhost ([127.0.0.1]:33023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVVby-0003EJ-BU for submit@debbugs.gnu.org; Mon, 14 Aug 2023 07:19:51 -0400 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]:56506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVVbv-0003Do-9b for 65218@debbugs.gnu.org; Mon, 14 Aug 2023 07:19:48 -0400 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-4fe2d152f62so6781624e87.0 for <65218@debbugs.gnu.org>; Mon, 14 Aug 2023 04:19:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692011981; x=1692616781; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=k96+uMgETeGrkAKDdSQE9mQLTMEhege3CubZNSVzHHw=; b=pJnNZ8mESu8v48LR5FkjK5WvRjj12ZAc6Z4X7i3GuZBSi3bV5nWSkSWqKqbcfNWZTm GyuhGdHn6fBA69GUkv6SFSJnbzYz19h6r8LcDzmKSAjLte47EMzZGBvmg2QY0QyYmnUp HgHkmi0ua8o48q3zhR4DZDwHgADPOzwRGO8ZzFV72MCdpKZIygHuT75jkBx3R5NKWw9g nAjVzN3bmlfgg6piQifg23CodUYX23VVSrkPgMHqCupGb4psL2mVhVMk3Gp1X+37MFIV SXYhXvaxfN9+ZWsHCVypXnUmvoRLghXjnU/yz3cvYjY4GU5ohaqbOJZhylUW7T+UiNBc XiuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692011981; x=1692616781; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k96+uMgETeGrkAKDdSQE9mQLTMEhege3CubZNSVzHHw=; b=eSeE+uE74cBktilOfQCGJSmjpc6fzZ793CHvADiIkO6o8q7MD78HgfTYMBkobPKNtU VxLPKpcTcaGPfgxWXt/+SoR7XjB29yWyjWyvy7v4cIWyHx5soFTgutYVWnlOxFBNrT8d sUpML7MdVCk31NE0T5SlUqgtweR6VtKSzBV2F6HgQThQvgffTy2mjfiyjjbXqpYy8rPw DAtgLy8JfhYHGzQGabu5WoUcn57wFH4P7w1qWolbRClYcmoPVSMvkfOMj8O2N+tavX8l uPLkmER4nS0wdoewxm6uub9Bex3tZiVxU1cLesG3MWcTjAbznds9nJ6duZgc7IjBxVXO IWug== X-Gm-Message-State: AOJu0YxjWA1WIlR1QGfZtzMz9D+jXsMo8JWWk+hUbfnA8Requliz5Y49 OdKGtO83uYSUHbYrpkD0Wb4J9u+cVesMX+roUxk= X-Google-Smtp-Source: AGHT+IFYo0D6dozYXLHyaT5jjrN3POletLJQ7KJLFjeZyNXGFOyFGiR79R3yPxYYaZAe0sYh1O74+BPJavZqZDsBfec= X-Received: by 2002:ac2:5f0b:0:b0:4fb:9129:705b with SMTP id 11-20020ac25f0b000000b004fb9129705bmr5415504lfq.6.1692011980613; Mon, 14 Aug 2023 04:19:40 -0700 (PDT) MIME-Version: 1.0 References: <87jzu0qmmg.wl-hako@ultrarare.space> In-Reply-To: From: Piotr =?UTF-8?Q?Kwieci=C5=84ski?= Date: Mon, 14 Aug 2023 13:19:29 +0200 Message-ID: Content-Type: multipart/alternative; boundary="0000000000000f6d900602e03dcd" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.08 X-Spam-Score: -5.08 X-Migadu-Queue-Id: ADDD048A99 X-Migadu-Scanner: mx2.migadu.com X-TUID: avXvMii9mly7 --0000000000000f6d900602e03dcd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Hilton, I have pushed a patch. Its tracked here: [1]: On Sat, 12 Aug 2023 at 20:29, Piotr Kwieci=C5=84ski wrote: > Hi Hilton, > thank you for your swift response and guidance. I'll attempt to send a > patch. > I already started to set up my local environment. > > On Sat, 12 Aug 2023 at 18:12, Hilton Chain wrote: > >> Hi Piotr, >> >> On Fri, 11 Aug 2023 04:18:57 +0800, >> Piotr Kwieci=C5=84ski wrote: >> > >> > [1 ] >> > [2 ] >> > I have the latest version of emacs-orderless installed on using guix >> and it shows: >> > >> > Status: External in >> =E2=80=98/gnu/store/mp2ckcr7psy9myby262zqii36cd49yja-emacs-orderless-1.0= /share/emacs/site-lisp/orderless-1.0/=E2=80=99 >> (unsigned). >> > Version: 0.8 >> > Summary: Completion style for matching regexps in any order >> > >> > This is caused by an incorrect version of a package declared in >> orderless.el. >> >> >> It seems that emacs-orderless in Guix wasn't really updated to 1.0, >> only the version field was changed. >> >> >> > I'm new to the ecosystem and I'm not familiar with the process of >> fixing this. >> > The issue was fixed by the package maintainer in commit >> > >> https://github.com/oantolin/orderless/commit/847694e78c12d903d5e3f6cb365= a5d3b984db537 >> > >> > Would replacing commit in the package definition be enough ? Swapping >> 004cee6b8e01f8eb0cb1c683d0a637b14890600f with >> > 847694e78c12d903d5e3f6cb365a5d3b984db537 >> >> >> That's not enough, the hash in (sha256 (base32 [...])) needs changing >> as well. >> >> And when updating an untagged revision to a tagged release, we usually >> drop the outer let form, and use the value from version field for >> commit. >> >> For example, the original definition: >> --8<---------------cut here---------------start------------->8--- >> (define-public emacs-orderless >> (let ((commit [...])) >> (package >> (name "emacs-orderless") >> (version [...]) >> (source >> (origin >> (method git-fetch) >> (uri (git-reference >> (url "https://github.com/oantolin/orderless") >> (commit commit))) >> (file-name (git-file-name name version)) >> (sha256 >> (base32 [...])))) >> [...]))) >> --8<---------------cut here---------------end--------------->8--- >> >> would be changed to: >> --8<---------------cut here---------------start------------->8--- >> (define-public emacs-orderless >> (package >> (name "emacs-orderless") >> (version "1.0") >> (source >> (origin >> (method git-fetch) >> (uri (git-reference >> (url "https://github.com/oantolin/orderless") >> (commit version))) ; <- see here >> (file-name (git-file-name name version)) >> (sha256 >> (base32 [...])))) ; <- hash is changed as well >> [...])) >> --8<---------------cut here---------------end--------------->8--- >> >> BTW the hash can be obtained with `guix hash' [1]: >> --8<---------------cut here---------------start------------->8--- >> git clone https://[...] emacs-orderless >> >> cd emacs-orderless >> git checkout 1.0 >> >> guix hash -rx . >> --8<---------------cut here---------------end--------------->8--- >> >> Would you like to get familiar with the process by going through the >> way [2] to make your first contribution? ;) >> >> I can send a patch if you prefer, and it may take a few days to get >> the change into Guix. >> >> Thanks >> >> >> [1]: < >> https://guix.gnu.org/en/manual/devel/en/html_node/Invoking-guix-hash.htm= l >> > >> [2]: > > >> >> (Not sure why this issue isn't on the mailing list, but is available >> in Debbugs. Still under moderation?) >> > > > -- > Regards > Piotr Kwiecinski > --=20 Regards Piotr Kwiecinski --0000000000000f6d900602e03dcd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hilton,
I have pushed a patch. Its= tracked here:

On Sat, 12 Aug 2023 at = 20:29, Piotr Kwieci=C5=84ski <piokwiecinski@gmail.com> wrote:
Hi=C2=A0Hilton,thank you for your swift response=C2=A0and guidance. I'll attempt to= send a patch.
I already started to set up my local environment.<= /div>

On Sat, 12 Aug 2023 at 18:12, Hilton Chain <hako@ultrarare.space> wrote:
<= /div>
Hi Piotr,

On Fri, 11 Aug 2023 04:18:57 +0800,
Piotr Kwieci=C5=84ski wrote:
>
> [1=C2=A0 <text/plain; UTF-8 (quoted-printable)>]
> [2=C2=A0 <text/html; UTF-8 (quoted-printable)>]
> I have the latest version of emacs-orderless installed on using guix a= nd it shows:
>
>=C2=A0 Status: External in =E2=80=98/gnu/store/mp2ckcr7psy9myby262zqii3= 6cd49yja-emacs-orderless-1.0/share/emacs/site-lisp/orderless-1.0/=E2=80=99 = (unsigned).
> Version: 0.8
> Summary: Completion style for matching regexps in any order
>
> This is caused by an incorrect version of a package declared in orderl= ess.el.


It seems that emacs-orderless in Guix wasn't really updated to 1.0,
only the version field was changed.


> I'm new to the ecosystem and I'm not familiar with the process= of fixing this.
> The issue was fixed by the package maintainer in commit
> https://gi= thub.com/oantolin/orderless/commit/847694e78c12d903d5e3f6cb365a5d3b984db537=
>
> Would replacing commit in the package definition be enough ? Swapping = 004cee6b8e01f8eb0cb1c683d0a637b14890600f with
> 847694e78c12d903d5e3f6cb365a5d3b984db537


That's not enough, the hash in (sha256 (base32 [...])) needs changing as well.

And when updating an untagged revision to a tagged release, we usually
drop the outer let form, and use the value from version field for
commit.

For example, the original definition:
--8<---------------cut here---------------start------------->8---
(define-public emacs-orderless
=C2=A0 (let ((commit [...]))
=C2=A0 =C2=A0 (package
=C2=A0 =C2=A0 =C2=A0 (name "emacs-orderless")
=C2=A0 =C2=A0 =C2=A0 (version [...])
=C2=A0 =C2=A0 =C2=A0 (source
=C2=A0 =C2=A0 =C2=A0 =C2=A0(origin
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(method git-fetch)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(uri (git-reference
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(url "https://github.com/oantolin/orderless")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(commit commit))) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(file-name (git-file-name name version))<= br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(sha256
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32 [...]))))
=C2=A0 =C2=A0 =C2=A0 [...])))
--8<---------------cut here---------------end--------------->8---

would be changed to:
--8<---------------cut here---------------start------------->8---
(define-public emacs-orderless
=C2=A0 (package
=C2=A0 =C2=A0 (name "emacs-orderless")
=C2=A0 =C2=A0 (version "1.0")
=C2=A0 =C2=A0 (source
=C2=A0 =C2=A0 =C2=A0(origin
=C2=A0 =C2=A0 =C2=A0 =C2=A0(method git-fetch)
=C2=A0 =C2=A0 =C2=A0 =C2=A0(uri (git-reference
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(url "http= s://github.com/oantolin/orderless")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(commit version)))=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0; <- see here
=C2=A0 =C2=A0 =C2=A0 =C2=A0(file-name (git-file-name name version))
=C2=A0 =C2=A0 =C2=A0 =C2=A0(sha256
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32 [...]))))=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0; <- hash is changed as well
=C2=A0 =C2=A0 [...]))
--8<---------------cut here---------------end--------------->8---

BTW the hash can be obtained with `guix hash' [1]:
--8<---------------cut here---------------start------------->8---
git clone https://[...] emacs-orderless

cd emacs-orderless
git checkout 1.0

guix hash -rx .
--8<---------------cut here---------------end--------------->8---

Would you like to get familiar with the process by going through the
way [2] to make your first contribution? ;)

I can send a patch if you prefer, and it may take a few days to get
the change into Guix.

Thanks


[1]: <https://guix.gnu.o= rg/en/manual/devel/en/html_node/Invoking-guix-hash.html>
[2]: <https://guix.gnu.org/en/= manual/devel/en/html_node/Contributing.html>

(Not sure why this issue isn't on the mailing list, but is available in Debbugs.=C2=A0 Still under moderation?)


--
Regards
Piotr Kwiecinski


--
Regards
Piotr Kwiecinski
--0000000000000f6d900602e03dcd--