unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Federico Beffa <beffa@ieee.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 21829@debbugs.gnu.org
Subject: bug#21829: guix import hackage failures
Date: Thu, 26 Nov 2015 09:28:07 +0100	[thread overview]
Message-ID: <CAKrPhPMmejAYuMje7-Y4pT2iDLyUhL=kW7cxA7z2KSU3qLsQpA@mail.gmail.com> (raw)
In-Reply-To: <87fuztda8k.fsf@gnu.org>

On Wed, Nov 25, 2015 at 10:45 PM, Ludovic Courtès <ludo@gnu.org> wrote:
> Federico Beffa <beffa@ieee.org> skribis:

[...]

>>>> +      ;; indentation based block recognition.
>>>> +      (begin (unread-char #\newline port) (read-char port) 0)
>>>
>>> Isn’t this equivalent to: 0 ?
>>
>> No. This is because at the start of a new line we check if and how
>> many indentation blocks have ended. If the last line doesn't terminate
>> this check is no done.
>
> More generally, it looks like:
>
>   (begin (do-effect!) (undo-effect!) val)
>
> which I thought reduces to:
>
>   val

Since we are doing IO, there are side effects. The key difference is
the result of '(port-column port)' and that triggers what I mentioned.

Thanks for the review.
Regards,
Fede

  reply	other threads:[~2015-11-26  8:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04 15:00 bug#21829: guix import hackage failures Paul van der Walt
2015-11-04 23:11 ` Ludovic Courtès
2015-11-10 16:40 ` Federico Beffa
2015-11-11 11:18   ` Ludovic Courtès
2015-11-11 21:29     ` Federico Beffa
2015-11-12  9:07       ` Ludovic Courtès
2015-11-12 16:54         ` Federico Beffa
2015-11-12 20:21           ` Ludovic Courtès
2015-11-13 17:08             ` Federico Beffa
2015-11-13 21:19               ` Ludovic Courtès
2015-11-14 14:37                 ` Federico Beffa
2015-11-15 20:59                   ` Ludovic Courtès
2015-11-25 16:55                     ` Federico Beffa
2015-11-25 21:45                       ` Ludovic Courtès
2015-11-26  8:28                         ` Federico Beffa [this message]
2015-11-26  8:46                           ` Ludovic Courtès
2015-11-26 17:23                         ` Federico Beffa
2015-11-26 19:56                           ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKrPhPMmejAYuMje7-Y4pT2iDLyUhL=kW7cxA7z2KSU3qLsQpA@mail.gmail.com' \
    --to=beffa@ieee.org \
    --cc=21829@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).