bug#38782: portaudio fails to build

bug#38782: portaudio fails to build

[Sergiu Marton]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

I have mpv installed, which depends on rsound, which, in turn, depends
on portaudio. Since my last guix pull, portaudio fails to build - it
fails during the build phase. I attached the build log. I tried
reading it, but I don't know what to make of it.

[-- Attachment #2: portaudio-log.bz2 --]
[-- Type: application/octet-stream, Size: 11035 bytes --]

bug#38782: portaudio fails to build

[Ricardo Wurmus]

Sergiu Marton <brown121407@gmail.com> writes:

> I have mpv installed, which depends on rsound, which, in turn, depends
> on portaudio. Since my last guix pull, portaudio fails to build - it
> fails during the build phase. I attached the build log. I tried
> reading it, but I don't know what to make of it.

I have been able to build it locally.  I suppose the problem might be
with parallel building.  Disabling parallel builds for the portaudio
package might fix this.

--
Ricardo

bug#38782: portaudio fails to build

[Sergiu Marton]

> I have been able to build it locally.  I suppose the problem might be
> with parallel building.  Disabling parallel builds for the portaudio
> package might fix this.

It built just fine with --cores=1 --max-jobs=1. Thanks!

bug#38782: portaudio fails to build

[Nicolas Goaziou]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

Hello,

Sergiu Marton <brown121407@gmail.com> writes:

>> I have been able to build it locally.  I suppose the problem might be
>> with parallel building.  Disabling parallel builds for the portaudio
>> package might fix this.
>
> It built just fine with --cores=1 --max-jobs=1. Thanks!

Would the following patch fix the issue then?

Regards,

-- 
Nicolas Goaziou

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Fix Portaudio build --]
[-- Type: text/x-diff, Size: 955 bytes --]

From 8acdc1540661bc80e8c724f29b6b162ccfb3307e Mon Sep 17 00:00:00 2001
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date: Sun, 29 Dec 2019 09:36:44 +0100
Subject: [PATCH] gnu: portaudio: Fix build.

* gnu/packages/audio.scm (portaudio)[arguments]: Build sequentially.

Fixes <https://bugs.gnu.org/38782>.  This is a follow-up to commit
1ce6bfc21ce328d787df76c6ee132f9f828d098b.
---
 gnu/packages/audio.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 204ea6acf0..a76a48d4c6 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2874,6 +2874,7 @@ portions of LAME.")
        ("pkg-config" ,pkg-config)))
     (arguments
      '(#:tests? #f                      ;no 'check' target
+       #:parallel-build? #f
        #:configure-flags '("--with-pic"
                            "--enable-cxx"
                            ;; XXX: The following prevents a build error
-- 
2.24.1

bug#38782: portaudio fails to build

[Sergiu Marton]

> Would the following patch fix the issue then?

That fixes it without requiring extra CLI arguments. Nice, thanks.

On Sun, Dec 29, 2019 at 8:44 AM Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>
> Hello,
>
> Sergiu Marton <brown121407@gmail.com> writes:
>
> >> I have been able to build it locally.  I suppose the problem might be
> >> with parallel building.  Disabling parallel builds for the portaudio
> >> package might fix this.
> >
> > It built just fine with --cores=1 --max-jobs=1. Thanks!
>
> Would the following patch fix the issue then?
>
> Regards,
>
> --
> Nicolas Goaziou

bug#38782: portaudio fails to build

[brettg]

On 29.12.2019 09:59, Sergiu Marton wrote:
>> Would the following patch fix the issue then?
> 
> That fixes it without requiring extra CLI arguments. Nice, thanks.
> 
> On Sun, Dec 29, 2019 at 8:44 AM Nicolas Goaziou 
> <mail@nicolasgoaziou.fr> wrote:
>> 
>> Hello,
>> 
>> Sergiu Marton <brown121407@gmail.com> writes:
>> 
>> >> I have been able to build it locally.  I suppose the problem might be
>> >> with parallel building.  Disabling parallel builds for the portaudio
>> >> package might fix this.
>> >
>> > It built just fine with --cores=1 --max-jobs=1. Thanks!
>> 
>> Would the following patch fix the issue then?
>> 
>> Regards,
>> 
>> --
>> Nicolas Goaziou

I would personally comment the reason for disabling parallel builds and 
affix this bug number to the commit sub-header message. I am at work 
right now, so I lack the ability to do this myself at the moment. But if 
I get home and this issue is still open, I will do it. It's up for grabs 
if somebody beats me to it.

Best,
Brett Gilio

bug#38782: portaudio fails to build

[Nicolas Goaziou]

Hello,

brettg@posteo.net writes:

> I would personally comment the reason for disabling parallel builds

You mean as a comment in the package definition? I checked other
definitions, comments in this situation, if any, are terse. E.g.,
";fails on some systems".

> and affix this bug number to the commit sub-header message.

I added the bug reference to the commit message. Do you mean it should
be moved right after the commit title (separated by a blank line)?

Regards,

-- 
Nicolas Goaziou

bug#38782: portaudio fails to build

[brettg]

On 29.12.2019 10:43, Nicolas Goaziou wrote:
> Hello,
> 
> brettg@posteo.net writes:
> 
>> I would personally comment the reason for disabling parallel builds
> 
> You mean as a comment in the package definition? I checked other
> definitions, comments in this situation, if any, are terse. E.g.,
> ";fails on some systems".
> 
>> and affix this bug number to the commit sub-header message.
> 
> I added the bug reference to the commit message. Do you mean it should
> be moved right after the commit title (separated by a blank line)?
> 
> Regards,

On a second look, your commit message is fine. And the `; fails on some 
systems` seems fine to me. Sorry, I am quite sleep deprived right now. 
:)

Best,
Brett Gilio

bug#38782: portaudio fails to build

[Nicolas Goaziou]

brettg@posteo.net writes:

> On 29.12.2019 10:43, Nicolas Goaziou wrote:
>> Hello,
>>
>> brettg@posteo.net writes:
>>
>>> I would personally comment the reason for disabling parallel builds
>>
>> You mean as a comment in the package definition? I checked other
>> definitions, comments in this situation, if any, are terse. E.g.,
>> ";fails on some systems".
>>
>>> and affix this bug number to the commit sub-header message.
>>
>> I added the bug reference to the commit message. Do you mean it should
>> be moved right after the commit title (separated by a blank line)?
>>
>> Regards,
>
> On a second look, your commit message is fine. And the `; fails on
> some systems` seems fine to me. Sorry, I am quite sleep deprived right
> now. :)

Great. I applied the patch. All the credit goes to Ricardo Wurmus for
the fix.