unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#38739: i3-gaps package is misbehaving
@ 2019-12-25  8:29 Sergiu Marton
  2019-12-25  8:34 ` Brett Gilio
  0 siblings, 1 reply; 4+ messages in thread
From: Sergiu Marton @ 2019-12-25  8:29 UTC (permalink / raw)
  To: 38739

I submitted a patch to add i3-gaps a couple days ago:

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38721

After it got merged into master with the inheritance modification (see
patch), I installed it over the one I had installed from my original
script and it seemed to work fine. But I think that's just because I
didn't reboot to restart the i3 executable.

Now that I shutdown and opened my machine again, i3-gaps specific
commands don't work... To test this, write `i3-msg gaps` in a shell.
If it does NOT work, it will output something like:

brown@121407 ~$ i3-msg gaps
ERROR: Your command: gaps
ERROR:               ^^^^
ERROR: Expected one of these tokens: <a long list of stuff that
represent valid commands>

However, it seems that gaps work if I remove the package, install it
from the original package definition (without Brett's (inherit i3-wm))
and reboot. The following output means that i3-gaps has been correctly
installed:

brown@121407 ~$ i3-msg gaps
ERROR: Your command: gaps
ERROR:
ERROR: Expected one of these tokens: 'inner', 'outer', 'horizontal',
'vertical', 'top', 'right', 'bottom', 'left'

This is strange. I still don't know enough about the packaging API to
troubleshoot this all just by having a quick look at i3-gaps'
definition. I'll try to investigate this issue but I encourage someone
more knowledgeable than me too look into this too.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#38739: i3-gaps package is misbehaving
  2019-12-25  8:29 bug#38739: i3-gaps package is misbehaving Sergiu Marton
@ 2019-12-25  8:34 ` Brett Gilio
  2019-12-25 15:40   ` Sergiu Marton
  0 siblings, 1 reply; 4+ messages in thread
From: Brett Gilio @ 2019-12-25  8:34 UTC (permalink / raw)
  To: Sergiu Marton; +Cc: 38739



Dec 25, 2019 2:30:12 AM Sergiu Marton :

> I submitted a patch to add i3-gaps a couple days ago:
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38721
>
> After it got merged into master with the inheritance modification (see
> patch), I installed it over the one I had installed from my original
> script and it seemed to work fine. But I think that's just because I
> didn't reboot to restart the i3 executable.
>
> Now that I shutdown and opened my machine again, i3-gaps specific
> commands don't work... To test this, write `i3-msg gaps` in a shell.
> If it does NOT work, it will output something like:
>
> brown@121407 ~$ i3-msg gaps
> ERROR: Your command: gaps
> ERROR: ^^^^
> ERROR: Expected one of these tokens: > represent valid commands>
>
> However, it seems that gaps work if I remove the package, install it
> from the original package definition (without Brett's (inherit i3-wm))
> and reboot. The following output means that i3-gaps has been correctly
> installed:
>
> brown@121407 ~$ i3-msg gaps
> ERROR: Your command: gaps
> ERROR:
> ERROR: Expected one of these tokens: 'inner', 'outer', 'horizontal',
> 'vertical', 'top', 'right', 'bottom', 'left'
>
> This is strange. I still don't know enough about the packaging API to
> troubleshoot this all just by having a quick look at i3-gaps'
> definition. I'll try to investigate this issue but I encourage someone
> more knowledgeable than me too look into this too.
>

Hi Sergiu,

Thank you for opening a new bug report at my request. As best as I can tell, the inherited arguments and your proposed package arguments without inheritance match 1:1. Tomorrow when I am at my computer I will introspect this further using the REPL.

If somebody else beats me to this, great! Hopefully we can get this figured out, it is probably some silly issue I just overlooked.

Thanks!

-- 
Brett M. Gilio
GNU Guix, Contributor | GNU Project, Webmaster
[DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]
< brettg@gnu.org [mailto:brettg@gnu.org] > < brettg@posteo.net [mailto:brettg@posteo.net] >

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#38739: i3-gaps package is misbehaving
  2019-12-25  8:34 ` Brett Gilio
@ 2019-12-25 15:40   ` Sergiu Marton
  2019-12-26 14:50     ` Marius Bakke
  0 siblings, 1 reply; 4+ messages in thread
From: Sergiu Marton @ 2019-12-25 15:40 UTC (permalink / raw)
  To: 38739

Tried installing i3-gaps on a fresh VM with Guix. Still the same
problem when getting it from the official sources. Gaps aren't
working. When installing from a file that has the original definition
(without inheritance), gaps work. So it's exactly the same situation.
Wanted to be sure.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#38739: i3-gaps package is misbehaving
  2019-12-25 15:40   ` Sergiu Marton
@ 2019-12-26 14:50     ` Marius Bakke
  0 siblings, 0 replies; 4+ messages in thread
From: Marius Bakke @ 2019-12-26 14:50 UTC (permalink / raw)
  To: Sergiu Marton, 38739-done

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

Sergiu Marton <brown121407@gmail.com> writes:

> Tried installing i3-gaps on a fresh VM with Guix. Still the same
> problem when getting it from the official sources. Gaps aren't
> working. When installing from a file that has the original definition
> (without inheritance), gaps work. So it's exactly the same situation.
> Wanted to be sure.

I believe this is fixed with 3ebaa635f7a4e2178b321f949e533402e3cf2987.
The problem was that the original i3-wm checksum appears to have been
copy-pasted during the refactor.

Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-12-26 14:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-25  8:29 bug#38739: i3-gaps package is misbehaving Sergiu Marton
2019-12-25  8:34 ` Brett Gilio
2019-12-25 15:40   ` Sergiu Marton
2019-12-26 14:50     ` Marius Bakke

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).