From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kLh8KyPnEWMRMQAAbAwnHQ (envelope-from ) for ; Fri, 02 Sep 2022 13:21:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id gN9vKyPnEWPMqgAA9RJhRA (envelope-from ) for ; Fri, 02 Sep 2022 13:21:07 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6CC2A39E92 for ; Fri, 2 Sep 2022 13:21:07 +0200 (CEST) Received: from localhost ([::1]:41078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oU4jS-0001Su-2B for larch@yhetil.org; Fri, 02 Sep 2022 07:21:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oU4bf-0004Ue-1y for bug-guix@gnu.org; Fri, 02 Sep 2022 07:13:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55298) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oU4be-00056U-65 for bug-guix@gnu.org; Fri, 02 Sep 2022 07:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oU4bd-0004mH-Vb for bug-guix@gnu.org; Fri, 02 Sep 2022 07:13:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks Resent-From: "Thompson, David" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 02 Sep 2022 11:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25957 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Efraim Flashner , "Thompson, David" , zimoun , 25957@debbugs.gnu.org Received: via spool by 25957-submit@debbugs.gnu.org id=B25957.166211713918311 (code B ref 25957); Fri, 02 Sep 2022 11:13:01 +0000 Received: (at 25957) by debbugs.gnu.org; 2 Sep 2022 11:12:19 +0000 Received: from localhost ([127.0.0.1]:45047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oU4ax-0004lH-8N for submit@debbugs.gnu.org; Fri, 02 Sep 2022 07:12:19 -0400 Received: from mail-lf1-f52.google.com ([209.85.167.52]:44891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oU4ap-0004kw-9E for 25957@debbugs.gnu.org; Fri, 02 Sep 2022 07:12:17 -0400 Received: by mail-lf1-f52.google.com with SMTP id g7so2747028lfe.11 for <25957@debbugs.gnu.org>; Fri, 02 Sep 2022 04:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=u16j1Rn1pzZd8LRkwYULudM4G/dhnQ9bQuiGAgBU/Q0=; b=GiMqGHjRzDm59rDxYM1iytvb2gkGPmHOnNzsE/hxznz8QsyEV5QC9qFBY98gQuxjHt 4Qfmv4C3rIDG3sYZOSUmJ90niABZbvk8aRSFg5FE57jipKViG59dWCndvNUyRLVsN0CZ E2anbit1Myu7lvW2vw5Ik0E/J6fRVjV7LTmlOk6bmlMWr6bksGLjyfcNNA708jcoWfmM ClNHnSg8l74sg4oYFwTaZbpiLSmQARKmsQe8+VNE/K7BGDAhUmog1eXJU3GmfbETfCmI q+ggr35QdHUhzeWvzJnwIbdA6pB2U2wC3Q9E9LIwQNtGcVju6wI3JGO6yVLvku7Pdndx NXsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=u16j1Rn1pzZd8LRkwYULudM4G/dhnQ9bQuiGAgBU/Q0=; b=HCQ00eWxmbCiJp2FCxuMGawjWsGa/Ob/SrMNm0soqudZ5RVB27JPnYbKIhogJ9BAMJ FoIvHlMlu1n+BmPEodVhwmj5JTR+mdqBn2DNH6b+8X8w9VgE/v9sr++Fyfrxjs/GXIma lbmC/17hbttoCxKIgGnpFFEWAj6bW7ttQtZm/qhSUrJnFlhgUyHMvdWUFg+3OEwSlOr9 ZLSEobX+2s0Su1QwNdPkHT6QR5/i5BJLcH3NmYI6ZbThn0ee/4fsSeheZkgxKZFsltmA ebPyBGxOxioQqlAzrDwRj79Oe86GYxqCAfROLDBNBgFbCFO8mnKCwJnQTzPYCCbshE+j vxBw== X-Gm-Message-State: ACgBeo2Hb3D9m5VquU0jNeNoP0eFbrF5lQvY9SpKSSjMAQC2YuUWESWN U5/HO2hmZGtHN1SSDSq0Z17Q3glhYSWPZef43Wv2Tw== X-Google-Smtp-Source: AA6agR7ecR3rln814GR6VBnHIwudiT9plDgIzKAbx3EmkY+D4RHLYbpzsv88BI7bTuZfisdd3oj+n3FCxxB4XxPebpA= X-Received: by 2002:ac2:5e8c:0:b0:494:6d14:f16e with SMTP id b12-20020ac25e8c000000b004946d14f16emr7469749lfq.316.1662117125199; Fri, 02 Sep 2022 04:12:05 -0700 (PDT) MIME-Version: 1.0 References: <20170304133242.towlmzdcm6x43hvi@abyayala> <86k0ff9has.fsf_-_@gmail.com> <8635l01x7a.fsf@gmail.com> <86lex10wwr.fsf@gmail.com> <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> In-Reply-To: From: "Thompson, David" Date: Fri, 2 Sep 2022 07:11:54 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662117667; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=u16j1Rn1pzZd8LRkwYULudM4G/dhnQ9bQuiGAgBU/Q0=; b=B92aitQp4Ft9G6tokRWeDI6Zcb7PxaaX/ZkBkwRB6TAqKxJZ1m3fTUSjqFFTFlxaH+k1Pp jkqe94OIN+a48/vUEbf6T9/2ZtC7/Bd5vRPdVHAKEQOSYQawZtMvsXcroyRoQt+MAdfRuN wDTXCnjj3c6g2UzDL5SSoMBICloPneumrhbYSOPqpN6aMbd4/RhVeQRrMj92OD8kbpHXKS xcS9g/eDHrRJ1od5uj607MIlgnDn4H6PBlNrsuapr9dQkBTcUL++8Izih9CKfJjx41GKeA e/Fd8tYC3P7TpEZX6gXtMPAuCFGrt37/0pOv+Zmee0XJS5+CVApjfd4fk/3KnA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662117667; a=rsa-sha256; cv=none; b=rbPF846+gBB3+DbdMc0p5NL3rTXM9XhbbRQ4vyI6JnnEx9nVXRBpU/B511TZihR3DyQssM Lg085cIoS+rqyBeO87D80STGZefck0HeG8FbX2VfTQbuacedV71829+evypkriILkqEly3 O0UIGuB8h2ZdNupvZepqJVf27CVZ/14mZe93aMaEvE9PgVOcfs30oy3mz7LAD/IKrGHm4s J6tijGvfesJbKXaArG/cPf7Y8b+eAUBXI96YpKGgs62dh5Xl/gNFXhvF4BW2YEQvbpWw3G F/dfe3o8I9/jI/bFz3Hnt+HZGWOYIE+aiemxL2Vjym4180smP3YxxSVqp5waNw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=worcester-edu.20210112.gappssmtp.com header.s=20210112 header.b=GiMqGHjR; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.23 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=worcester-edu.20210112.gappssmtp.com header.s=20210112 header.b=GiMqGHjR; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6CC2A39E92 X-Spam-Score: 4.23 X-Migadu-Scanner: scn1.migadu.com X-TUID: I3qwF7SljtvH On Fri, Sep 2, 2022 at 3:00 AM Efraim Flashner wrote: > > I took a look at the gitolite service finally and I hadn't realized > there wasn't a running daemon to containerize. I assumed we could do > something like: > > (start $~(make-forkexec-constructor/container > (list ...) > #:environment-variables > '("PATH=...") > #:mappings ...)) > > Given that's not the case then I'd need to look at gitolite itself to > see how it calls the other binaries it expects to be available, and if > wrapping it would be enough or if we would need to just propagate the > other packages for functionality. Gitolite simply expects tools like git to be on $PATH. It's a pretty naive system, there's nothing like a configure script that is determining the absolute file name of these tools and substituting those names into the built files. The executable is already wrapped so that coreutils, findutils, and git are on $PATH, but notably not openssh: (add-after 'install 'wrap-scripts (lambda* (#:key inputs outputs #:allow-other-keys) (let ((out (assoc-ref outputs "out")) (coreutils (assoc-ref inputs "coreutils")) (findutils (assoc-ref inputs "findutils")) (git (assoc-ref inputs "git"))) (wrap-program (string-append out "/bin/gitolite") `("PATH" ":" prefix ,(map (lambda (dir) (string-append dir "/bin")) (list out coreutils findutils git))))))) However, git and openssh are still propagated inputs. I'm going to move the propagated inputs to regular inputs, potentially add openssh to the wrapper once I remind myself what gitolite does with those tools, and test it all out on my server using the gitolite service. If that all works, we have a good starting point for adding extension support in the service. - Dave