From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wGHVDWcFV2NkWAEAbAwnHQ (envelope-from ) for ; Mon, 24 Oct 2022 23:36:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id QDC+DWcFV2N+2AAA9RJhRA (envelope-from ) for ; Mon, 24 Oct 2022 23:36:39 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8CB9238BBA for ; Mon, 24 Oct 2022 23:36:38 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1on4uW-00085w-0B; Mon, 24 Oct 2022 17:23:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1on4uU-00085T-EF for bug-guix@gnu.org; Mon, 24 Oct 2022 17:23:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1on4uU-00068s-2w for bug-guix@gnu.org; Mon, 24 Oct 2022 17:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1on4uT-0002Ji-Lo for bug-guix@gnu.org; Mon, 24 Oct 2022 17:23:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks Resent-From: "Thompson, David" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 24 Oct 2022 21:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25957 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: zimoun Cc: 25957-done@debbugs.gnu.org, Efraim Flashner , 25957@debbugs.gnu.org Received: via spool by 25957-submit@debbugs.gnu.org id=B25957.16666465348842 (code B ref 25957); Mon, 24 Oct 2022 21:23:01 +0000 Received: (at 25957) by debbugs.gnu.org; 24 Oct 2022 21:22:14 +0000 Received: from localhost ([127.0.0.1]:49648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1on4ti-0002IX-Dw for submit@debbugs.gnu.org; Mon, 24 Oct 2022 17:22:14 -0400 Received: from mail-lj1-f170.google.com ([209.85.208.170]:33330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1on4tV-0002Hg-DN for 25957@debbugs.gnu.org; Mon, 24 Oct 2022 17:22:03 -0400 Received: by mail-lj1-f170.google.com with SMTP id b8so7690515ljf.0 for <25957@debbugs.gnu.org>; Mon, 24 Oct 2022 14:22:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wlosTPTt4b9NqDuUF/RIedw6Da5Cs7G8BTcvhshYG4g=; b=jBNv+5qpHEyIlJ4XeBy0DaH/ruK6V2SKrQXynhFqviHaZ2MXpI65IvE9MmL1XvLish EKjf2t9bArqnDLvc/4crgxtVKWc8Ch3uL5rYH/jiaCFrz/iSzayTSEApAUjmpJtecm50 MmPzLP8iQEsVVyLSVkBrW9iP2eEfDNnsExZzHE82mpXtAJkJEOMo4CsCaPQJZQUi5PRJ wvycedgNbPPRlEnHHuSE8KBaspJkmWle4mdb53ZxU7R0nORtDE6WmE7BYYL6aqfpf2or H24trGAXn01vIo1bh9TogffWrwShsHsTZgv9NEN5mHT/45CLFRLcRd3TjBre40H0VSNg sl0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wlosTPTt4b9NqDuUF/RIedw6Da5Cs7G8BTcvhshYG4g=; b=Q+eawHdSv8v5XkMgZi6GESQtqVC1FrW91NWI8e3sJml76G0vnnUdEgEIrGTyyN7Aui 8VGzG1bGjHmduO2N1FbotRjCXp/P4yZtQUTmnV5WRRMxpMKsA+CVgT3BGSV5g4yHCd91 gVunlayH9N/LBcyXvQvsNw2ik2IMEkQVCyU7mgad+Mr4jMgN7WhI01h23f6SaD4qY8ZX lO5mF8uOLmBnZZRxQsjY5fW+lqpBkTFNBsD+puisOM+1EaW+n0QSldp7gv5T4nBEpdg4 X5AlLd2AKVPyrGreM5M4xL9VIu6kCY3s68/yVGYWRo22qnTQEC/Q6gNwMGS/PnaQ7OMf IbnA== X-Gm-Message-State: ACrzQf24pz7+tOtAeJ0udID7AU0zaDexsETmvXLGdbc0CH741BxF3BDy joaganMl5P+RRoViUiyl8IDlfmxAEGL4KL/XdMHOBw== X-Google-Smtp-Source: AMsMyM4C4fH9xyDwaWFvh3iaPa4K2BeHtl1jgnSgS9mHMNZpjtcZoryN0ZQq4cRmCu26HoMcA+to/94RysU3mJU3KlQ= X-Received: by 2002:a05:651c:2116:b0:277:f14:5798 with SMTP id a22-20020a05651c211600b002770f145798mr1875611ljq.42.1666646515336; Mon, 24 Oct 2022 14:21:55 -0700 (PDT) MIME-Version: 1.0 References: <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> <871qsqtewp.fsf@gmail.com> <86k05as6t3.fsf@gmail.com> In-Reply-To: From: "Thompson, David" Date: Mon, 24 Oct 2022 17:21:44 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "bug-Guix" Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666647399; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=wlosTPTt4b9NqDuUF/RIedw6Da5Cs7G8BTcvhshYG4g=; b=cK/gt/Blsc14CNRMlYO6a3e9/xQiCSI4deSKqSkslDFYAJbajMg/z2YXPEbrvgSN9VC2Ib 1OnsxAx+rTvWtrBNgzxBWWCZaWrSy4FTJxi2lyurguEA05MYaw6ds92swgu9zifnaK07OJ kqLz9dV/S4xyu3AstMek+anLJn/F09DH4UVme43Ev15OzGLkwBKocFJnSc9IKz3BXfSG+I cE7My6i+zbCFaqtmTIVyh4IuE1AWjuw2GjutMPy8BTLc2GzbTwMdrk/6FPCrDYbMacViif gkfB4fUcQ0P27H2DrGy3/3mTecAh+tVLQXvxAiJ0N6uuAB1Mi3FPM6y5ryXjqw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666647399; a=rsa-sha256; cv=none; b=mhS+DoZTeWBleiImAeIdQr/701SMRvWZR1a+9P0uV6iFHT2EK21PHDMqhE9cYHvZ3nRgcm yU5bSvw+vauYLCy/VmhB5XUJa+x8q78VKPgY30QpOtW+fudsnNumwi+HMyI+GBNvRY9nUp pV45Gl1nzWII9jvbt7wJYUJwjdKbh+VkHi//I9BpLKu71lA9jlsicA10cyeLfBy03Qeeaj 3nZzkMXpvPf+FZ70fPhN9VuOA1v5D0TZZ5WskU/aWW/MhfRgyJNgkunKlu9YW7y8yyNxcx XFUif42Vvj7PAEX8azSLgZN29zETbE6FAoPtlFtULXaYsOP7gQNS6o+sZWb4Xg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=worcester-edu.20210112.gappssmtp.com header.s=20210112 header.b=jBNv+5qp; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.09 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=worcester-edu.20210112.gappssmtp.com header.s=20210112 header.b=jBNv+5qp; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8CB9238BBA X-Spam-Score: 2.09 X-Migadu-Scanner: scn0.migadu.com X-TUID: sXEWh3m5vPMu On Sat, Oct 8, 2022 at 9:40 PM Thompson, David w= rote: > > On Sat, Oct 8, 2022 at 11:16 AM zimoun wrote: > > > > Hi Dave, > > > > On Thu, 06 Oct 2022 at 09:26, "Thompson, David" wrote: > > > > > Some news: I have updated the gitolite package to use G-expressions. > > > The package builds and the gitolite system test passes so I pushed > > > that change to master a little while ago. That patch has made the > > > (hopefully) final step in this saga easier. The attached patch > > > introduces a 'make-gitolite' procedure that can be used to add > > > arbitrary packages to the wrappers for the gitolite and gitolite-shel= l > > > programs. The return value of this procedure can be used in the > > > gitolite service configuration to enable the desired optional feature= s > > > like Redis or git-annex. The base package inputs are unchanged and > > > the gitolite system test still passes. > > > > Thank you for working on this! Neat. > > > > Well, your proposal LGTM although I do not see the difference between > > =E2=80=99make-gitolite=E2=80=99 and a simple =E2=80=99inherent=E2=80=99= for building a package variant. > > Yeah, this make-gitolite is probably more handy. > > The reason for the constructor is so that extra packages can be easily > added to the gexp that calls wrap-program. It would be much harder to > modify the package in this way without a helper procedure. Pushed as commit 966118da711506b04c11fbfcac9483d59ed2d912. This bug can finally be closed! - Dave