unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Thompson, David" <dthompson2@worcester.edu>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 25957-done@debbugs.gnu.org,
	Efraim Flashner <efraim@flashner.co.il>,
	25957@debbugs.gnu.org
Subject: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks
Date: Mon, 24 Oct 2022 17:21:44 -0400	[thread overview]
Message-ID: <CAJ=RwfZfRHz0Fx4hnzd5C9eQzjnvuWZDCM2EPnsznJgJTqqbZw@mail.gmail.com> (raw)
In-Reply-To: <CAJ=Rwfb84PaCjJYRHKavSxKMTxDPbekAK-a58nSvO=NGxyH4zA@mail.gmail.com>

On Sat, Oct 8, 2022 at 9:40 PM Thompson, David <dthompson2@worcester.edu> wrote:
>
> On Sat, Oct 8, 2022 at 11:16 AM zimoun <zimon.toutoune@gmail.com> wrote:
> >
> > Hi Dave,
> >
> > On Thu, 06 Oct 2022 at 09:26, "Thompson, David" <dthompson2@worcester.edu> wrote:
> >
> > > Some news: I have updated the gitolite package to use G-expressions.
> > > The package builds and the gitolite system test passes so I pushed
> > > that change to master a little while ago.  That patch has made the
> > > (hopefully) final step in this saga easier. The attached patch
> > > introduces a 'make-gitolite' procedure that can be used to add
> > > arbitrary packages to the wrappers for the gitolite and gitolite-shell
> > > programs.  The return value of this procedure can be used in the
> > > gitolite service configuration to enable the desired optional features
> > > like Redis or git-annex.  The base package inputs are unchanged and
> > > the gitolite system test still passes.
> >
> > Thank you for working on this!  Neat.
> >
> > Well, your proposal LGTM although I do not see the difference between
> > ’make-gitolite’ and a simple ’inherent’ for building a package variant.
> > Yeah, this make-gitolite is probably more handy.
>
> The reason for the constructor is so that extra packages can be easily
> added to the gexp that calls wrap-program.  It would be much harder to
> modify the package in this way without a helper procedure.

Pushed as commit 966118da711506b04c11fbfcac9483d59ed2d912.  This bug
can finally be closed!

- Dave




  reply	other threads:[~2022-10-24 21:36 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03 21:58 bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks ng0
     [not found] ` <handler.25957.B.14885741929377.ack@debbugs.gnu.org>
2017-03-03 22:27   ` bug#25957: Acknowledgement (gitolite broken: created repositories keep references to /usr/bin for hooks) ng0
2017-03-04 13:32     ` ng0
2017-03-04 15:43       ` Danny Milosavljevic
2017-03-04 17:33         ` ng0
2022-01-05  0:07       ` bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks zimoun
2022-01-12 18:07         ` Efraim Flashner
2022-02-03  2:49           ` zimoun
2022-03-23 10:45             ` zimoun
2022-03-23 12:44               ` Maxime Devos
2022-03-28  6:49                 ` Efraim Flashner
2022-09-01 13:59                   ` bug#25957: [EXT] " Thompson, David
2022-09-01 14:20                     ` Efraim Flashner
2022-09-01 14:41                       ` bug#25957: [EXT] " Thompson, David
2022-09-01 17:00                         ` zimoun
2022-09-02  6:56                         ` Efraim Flashner
2022-09-02 11:11                           ` Thompson, David
2022-09-02 12:41                             ` Efraim Flashner
2022-09-02 12:50                               ` bug#25957: [EXT] " Thompson, David
2022-09-02 19:58                                 ` Thompson, David
2022-09-04  7:26                                   ` Efraim Flashner
2022-09-04 13:26                                     ` Thompson, David
2022-09-05  8:16                                       ` zimoun
2022-09-06 13:50                                         ` Thompson, David
2022-10-06 13:26                                         ` Thompson, David
2022-10-06 13:42                                           ` Thompson, David
2022-10-08 14:56                                           ` zimoun
2022-10-09  1:40                                             ` Thompson, David
2022-10-24 21:21                                               ` Thompson, David [this message]
2022-10-25  9:58                                                 ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ=RwfZfRHz0Fx4hnzd5C9eQzjnvuWZDCM2EPnsznJgJTqqbZw@mail.gmail.com' \
    --to=dthompson2@worcester.edu \
    --cc=25957-done@debbugs.gnu.org \
    --cc=25957@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).