unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Thompson, David" <dthompson2@worcester.edu>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 57467@debbugs.gnu.org
Subject: bug#57467: [EXT] Re: bug#57467: 'guix shell' does not honor default behavior when given a specific command to run
Date: Mon, 29 Aug 2022 08:48:17 -0400	[thread overview]
Message-ID: <CAJ=RwfYpTUTHLTdXknakJ9LDN-CUy03CUp+e1uc-rpyV_-MQzQ@mail.gmail.com> (raw)
In-Reply-To: <e17e9232-c813-4cc7-40a2-107a0768231b@telenet.be>

[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]

Hi Maxime,

On Mon, Aug 29, 2022 at 6:29 AM Maxime Devos <maximedevos@telenet.be> wrote:

> On 29-08-2022 03:28, Thompson, David wrote:
>
> Hi again,
>
> I decided to just implement the fix and see what people think of it.
> Simply removing a check for non-interactive invocation solves the issue and
> now 'guix shell' and 'guix shell -- make' act exactly the same except for
> which command they run.  Patch attached.
>
> The interactive check is a feature, not a bug:
>
Could you please explain why it's a feature? I've provided an example that
shows how it is confusing and unexpected.

> https://issues.guix.gnu.org/50960#69:
> [...]
> Agreed. The automatic reading of guix.scm/manifest.scm, if we keep it,
> should only happen in interactive use; I’ll double-check and make sure
> this is the case.
>
> It might still be possible to solve 57467, but I don't think this patch is
> the solution.
>

Could you propose an alternate solution?  What are the next steps here?
Right now all I know is that you don't like my patch.

- Dave

[-- Attachment #2: Type: text/html, Size: 2074 bytes --]

  reply	other threads:[~2022-08-29 12:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-28 21:58 bug#57467: 'guix shell' does not honor default behavior when given a specific command to run Thompson, David
2022-08-29  1:28 ` Thompson, David
2022-08-29 10:29   ` Maxime Devos
2022-08-29 12:48     ` Thompson, David [this message]
2022-08-30 13:24       ` bug#57467: [EXT] " Maxime Devos
2022-08-30 13:39         ` bug#57467: [EXT] " Thompson, David
2022-08-30 14:33           ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2022-08-30 16:22             ` bug#57467: [EXT] " Thompson, David
2022-08-30 19:26 ` bug#57467: [EXT] " Thompson, David
2022-09-05 13:06   ` Ludovic Courtès
2022-09-05 17:23     ` Thompson, David
2022-09-05 19:53     ` Maxime Devos
2022-09-06  7:18       ` Ludovic Courtès
2022-09-06 11:03         ` Maxime Devos
2022-09-06 11:33 ` Thompson, David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ=RwfYpTUTHLTdXknakJ9LDN-CUy03CUp+e1uc-rpyV_-MQzQ@mail.gmail.com' \
    --to=dthompson2@worcester.edu \
    --cc=57467@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).