From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cPzzIa54016/UQAA0tVLHw (envelope-from ) for ; Sun, 31 May 2020 09:28:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QN3THa540172dgAA1q6Kng (envelope-from ) for ; Sun, 31 May 2020 09:28:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 184E894014C for ; Sun, 31 May 2020 09:28:14 +0000 (UTC) Received: from localhost ([::1]:36254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfKGJ-0003Iy-L2 for larch@yhetil.org; Sun, 31 May 2020 05:28:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfKGA-0003Ij-Kx for bug-guix@gnu.org; Sun, 31 May 2020 05:28:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48184) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jfKGA-0000dZ-Br for bug-guix@gnu.org; Sun, 31 May 2020 05:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jfKGA-0003Jn-8h for bug-guix@gnu.org; Sun, 31 May 2020 05:28:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#41607: Deleted store items are not actually deleted Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 31 May 2020 09:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41607 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Chris Marusich Received: via spool by 41607-submit@debbugs.gnu.org id=B41607.159091727512742 (code B ref 41607); Sun, 31 May 2020 09:28:02 +0000 Received: (at 41607) by debbugs.gnu.org; 31 May 2020 09:27:55 +0000 Received: from localhost ([127.0.0.1]:59730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfKG2-0003JR-RD for submit@debbugs.gnu.org; Sun, 31 May 2020 05:27:55 -0400 Received: from mail-qk1-f176.google.com ([209.85.222.176]:41723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfKG1-0003JF-6K for 41607@debbugs.gnu.org; Sun, 31 May 2020 05:27:53 -0400 Received: by mail-qk1-f176.google.com with SMTP id n11so6377805qkn.8 for <41607@debbugs.gnu.org>; Sun, 31 May 2020 02:27:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=f53ZsjlL7W40Aav5nctiA6CYInhbMfOqkVpCCZ2r4wU=; b=vSLTjaDWL+dXtWWIR9Fjg7hcWXzfai+KGsC9NcPo/oDp3tYZmo+0VxXoBWIb3L6Nf+ dua2qlI8Eb/ruHS20PkeWrSITXRANnaKMSINtTEBno4+RViEAlh6UVgJUZ5dorp5Q/RV Lvxoy58ws7ozENPgFF6jsL1YcpC+UupLPEAKD4NDDO10dwBw9KzL0wrnnkR2JvV/TdsP nRmoe28vu3EiNOhl+4caFCmxXIBBAJL3g2Mdxp1Y2AV9q6V99z5f8QHvOPpQ7SWpldkW UCUo+HmkEhbQ+KQwTlULjxrFccejERMFHMgteoIwGX8xh+fAVypojAv1TJpYIgTcKkEV 80wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f53ZsjlL7W40Aav5nctiA6CYInhbMfOqkVpCCZ2r4wU=; b=RSEwy1igbEoEMCDbj8S+QY7qqDb5K0xBfOnfHCiSYepuTMY5X7ZLraxeMj9MjSke3P UUzkTgZUGhiC0/lanSj2xtpxX34nI/A/Mcoj88HsmC3CPdTKSY+aonhI7mwJyr5pRhNW gIniDyUPPAVmydp3nJT706lZTYnt1MSpmfqV6bYVPYZT+4SYd91kX8pwu/XQLuGIjaig aqdNTo3jN28ku7VkS8/6WljrdLZx9J58u9aD/An7hg+0kU87IeFCZbwLEboEkTUbU38B 3ASE/Fd773poF7HNSd+SVhJZfaniAHRcrfAF3kROUT5oHOFaCgWgY6rnbk4t8lUkkyJw ljew== X-Gm-Message-State: AOAM53352jrA5Z1/AGM7xd5uCqgSbcJu0UI0Wvn8Fv1hkLMVgji8li2t xOOvoWDf1/GAE274LIBaWeQwRSH74YVqXKZkOtQ= X-Google-Smtp-Source: ABdhPJydBuFFohP7KZzK9hEE7RnuO+5TKsLWwsB40pHxFO8t8UPpF+o5ZLFP+VqqrDPGoXkqUwJruEvBZYIMgwVn1/Y= X-Received: by 2002:ae9:f214:: with SMTP id m20mr15093941qkg.232.1590917267674; Sun, 31 May 2020 02:27:47 -0700 (PDT) MIME-Version: 1.0 References: <20200528181043.GC23745@jasmine.lan> <20200529170820.GA30828@jasmine.lan> <20200529180245.GA3754@jasmine.lan> <20200529190942.GA8440@jasmine.lan> <87r1v0k8hl.fsf@gmail.com> In-Reply-To: <87r1v0k8hl.fsf@gmail.com> From: zimoun Date: Sun, 31 May 2020 11:27:36 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 41607@debbugs.gnu.org, Stephen Scheck Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=vSLTjaDW; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: 4n8rWbDROw4f Hi Chris, Thank you for the detailed explanations. On Sun, 31 May 2020 at 06:57, Chris Marusich wrote: > The trash directory is on the "top layer" because it gets created in the > running container. However, in practice many store items from lower > layers are made dead when Stephen's script runs "guix pull" and deletes > the old profiles. If any of those store items were directories, > guix-daemon will fail to GC them because of an XDEV error. If this is > confusing to you, I suggest you experiment with Docker a little bit, and > look closely at the steps that Stephen's script is running. I outlined > this in the email I accidentally deleted, but I'm a little too tired to > reproduce it all a second time. I hope you'll understand. > > Should Guix do anything about this? We could change guix-daemon to take > correct action in the face of an XDEV error. We could also improve the > logging, since currently it silently swallows the XDEV error. What is the correct action? Because somehow these items cannot be removed of the Docker chained images. However, the logging could report the ``error", e.g., "guix gc" lists all the items and their size and currently it says "[0MiB] deleting" so instead it could say "[XDEV error] not valid" with some words about that in the manual, section "Invking guix gc". WDYT? Cheers, simon