From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gDguN9uWPl+dZgAA0tVLHw (envelope-from ) for ; Thu, 20 Aug 2020 15:29:31 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id eHIFM9uWPl/sRgAAB5/wlQ (envelope-from ) for ; Thu, 20 Aug 2020 15:29:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A10269403A9 for ; Thu, 20 Aug 2020 15:29:29 +0000 (UTC) Received: from localhost ([::1]:32954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8mVM-00012I-J0 for larch@yhetil.org; Thu, 20 Aug 2020 11:29:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8mIM-00056R-Ks for bug-guix@gnu.org; Thu, 20 Aug 2020 11:16:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60247) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k8mIM-0007hD-AZ for bug-guix@gnu.org; Thu, 20 Aug 2020 11:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k8mIM-0007H5-60 for bug-guix@gnu.org; Thu, 20 Aug 2020 11:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#42948: (wrap-program) bug Resent-From: Prafulla Giri Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 20 Aug 2020 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42948 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Julien Lepiller Received: via spool by 42948-submit@debbugs.gnu.org id=B42948.159793655027254 (code B ref 42948); Thu, 20 Aug 2020 15:16:02 +0000 Received: (at 42948) by debbugs.gnu.org; 20 Aug 2020 15:15:50 +0000 Received: from localhost ([127.0.0.1]:43560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8mI9-00074c-9m for submit@debbugs.gnu.org; Thu, 20 Aug 2020 11:15:50 -0400 Received: from mail-pj1-f47.google.com ([209.85.216.47]:51196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8mI6-0006xM-OS for 42948@debbugs.gnu.org; Thu, 20 Aug 2020 11:15:47 -0400 Received: by mail-pj1-f47.google.com with SMTP id e4so1107920pjd.0 for <42948@debbugs.gnu.org>; Thu, 20 Aug 2020 08:15:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3sZKY3tLdrmni6SxOi3bIQu8W8oCb9VdiWGvpKWCObU=; b=lExGWAz5kGufunlGN0/VmB0bs1QRaB4ixZzs09GQswgOzqSwFTM6B6p4pRDDAxlj09 axUWIfqMsOuL7gQ2ZCS2SVNcmWJnfFbRDJhlgx9Hb+EWOm9q1rMRqGj2FWVUf10Snt4a n41ZM+YnY49oCcEl59B1MmhNeuHh3Zdc2ZLTkVE61BVUFpklOeTZD1jDFO22GM/i81KM I4xHZfVZIvPQ70OldF5rcsshsq7i14v2sd2hW/sWd+/Fivi3udAHlSFA0p9nrD83bPP9 FE3X5rYQyhOhHuJyZBxozo4gYxeSr5go0C46S3D6otFA9GqXyWP7tRvvhSyFlTXV6gxc KaEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3sZKY3tLdrmni6SxOi3bIQu8W8oCb9VdiWGvpKWCObU=; b=beaiL38gCPSJbW8AheykUNekiE5dcoLH+YzYQ0SYXXOi5xsWxe/zNu3rK/W5mLLemz V824O+gqdBy6WFFadWUyDhGo9rOgzPz8JS8n7WtOL/vWSIN10mQPtKmdLA2Av6i8c6Ay kAr1vLbShem3DD7CnaZ4gCC1FtKIbeWz95y8CXabSkhst9SUbhtmFMZp0DdroRFj6toR ihx0jsn5Eb22pTug4fYOt1qVmkA+Dq8kX7jX/I+B0FOKXog/7CGc9c0u/zLdyAvqP8pD NPDDX2ZkZJhXHmko2KiRU4/l857YcVJ0wQbQHntbAicw440yIKGZfrIqAg0JGgcr1X6D FCWQ== X-Gm-Message-State: AOAM5321RUWUPoUNAEPxPQ7ccqGidUydNZtXt6xGBDrY1JdAqUiCQATN dyLrLZSXPr4sJ0CMWbi1YU7fU1BKaME2wb5dgZMkIJ5ox2U= X-Google-Smtp-Source: ABdhPJzWudHHIjGnLPH1lazcWAvY6Ey84FI4RoGg77t+cUnIGvHivM/inpGvrwOpq+LkKsWEKj35xDcL2f1J5nkrWhg= X-Received: by 2002:a17:90a:4fe2:: with SMTP id q89mr3061162pjh.70.1597936540676; Thu, 20 Aug 2020 08:15:40 -0700 (PDT) MIME-Version: 1.0 References: <20200820143158.51e8b321@tachikoma.lepiller.eu> In-Reply-To: <20200820143158.51e8b321@tachikoma.lepiller.eu> From: Prafulla Giri Date: Thu, 20 Aug 2020 21:00:29 +0545 Message-ID: Content-Type: multipart/mixed; boundary="000000000000e1924d05ad5097fd" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 42948@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=gmail.com header.s=20161025 header.b=lExGWAz5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 1.19 X-TUID: nKSH7cL1YFgx --000000000000e1924d05ad5097fd Content-Type: multipart/alternative; boundary="000000000000e1924b05ad5097fb" --000000000000e1924b05ad5097fb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes, you are correct. This turned out to be a false alarm. I poked around with the definition, and, just like you said, everything works. `ronn` not running was a gempspec issue that I have resolved in the package definition (patch attached). Thank you very much for clearing the matter out! On Thu, Aug 20, 2020 at 6:17 PM Julien Lepiller wrote: > Le Thu, 20 Aug 2020 17:44:01 +0545, > Prafulla Giri a =C3=A9crit : > > > Esteemed maintainers, > > > > It seems that (wrap-program ...) over-writes the previous wrapping of > > a package done by the build system. > > > > This does not happen for many (wrap-programs) called in the > > modify-phases section of the package definition itself. > > > > Attached is a package definition for ruby-ronn-ng, that demonstrates > > this issue. The custom (wrap-program)-s > > called from the package definition seem to over-write the definitions > > of GEM_ENV as made by the 'wrap %standard-phase > > of the ruby-build system. > > The wrappings made by 'wrap %standard-phase can be seen during the > > custom 'DEBUG phase. The subsequent 'wrap-program1 > > and 'wrap-program2 add more environment variables to the wrapping, > > but on checking the contents of `which ronn`, once > > it is installed (using `less $(which ronn)`), it can be verified that > > the GEM_ENV package definitions have been overwritten. > > > > This may just be a ruby-build-system issue. Or perhaps it might be > > something that permeates over a few more build systems. > > That still remains to be tested. > > > > Attached are a few different versions of the package definitions for > > ruby-ronn-ng for the ease of those who would like to > > verify this. > > 1. ruby-ronn-ng-standalone.scm : To be tested using `guix > > time-machine -- build --verbosity=3D2 > > --file=3Druby-ronn-ng-standalone.scm`[1] 2. ruby-ronn-ng.scm : To be > > appended to the end of the gnu/packages/ruby.scm file in local guix > > checkout, and be tested using the local version > > 3. ruby-ronn-ng.patch : To be applied to local guix checkout > > > > [1] - This package definition needs ruby-mustache, which has only > > recently been added to guix. Hence, the time-machine. > > > > NOTE: `ronn` does not work even with `propagated-inputs`. See this > > patch as to why: > > > https://aur.archlinux.org/cgit/aur.git/tree/0001-allow-mustache-1.0.patch= ?h=3Druby-ronn-ng > > Hi, > > From what I see, there is no issue here (unless I'm missing something). > In the built package, I see bin/ronn is a shell wrapper that defines > the PATH and FOO environment variables and calls bin/.ronn-real. > bin/.ronn-real itself is a ruby script that defines GEM_PATH and calls > bin/.real/ronn, which is the actual program. > > I don't see anything wrong with that, but I'm not a ruby expert. In > fact, when running ronn (from its store path directly), I see the > following error: > > > /gnu/store/9yqh0g1p5bmxar8dlfp84j4py3j631jv-ruby-2.6.5/lib/ruby/2.6.0/rub= ygems/dependency.rb:313:in > `to_specs': Could not find 'mustache' (>=3D 0.7.0, ~> 0.7) - did find: > [mustache-1.1.1] (Gem::MissingSpecVersionError) Checked in > > 'GEM_PATH=3D/gnu/store/l8jicf1ibzrgff754mvbc5k14fa62s7a-ruby-ronn-ng-0.9.= 1/lib/ruby/vendor_ruby:/gnu/store/9yqh0g1p5bmxar8dlfp84j4py3j631jv-ruby-2.6= .5/lib/ruby/vendor_ruby:/gnu/store/w1a9ndhvvbw76g19fgx4j78kx3aghi4k-ruby-kr= amdown-2.3.0/lib/ruby/vendor_ruby:/gnu/store/jfbzrfd7i8x46q9c8sw26av6kx7jyr= 3c-ruby-mustache-1.1.1/lib/ruby/vendor_ruby:/gnu/store/0wsy4yymr5m0wzms0qv5= ak5q21g8c6hs-ruby-nokogiri-1.10.9/lib/ruby/vendor_ruby:/gnu/store/7ncf7v5pr= hv4ir8bgdlxa1rz8ph5mlry-ruby-pkg-config-1.2.5/lib/ruby/vendor_ruby:/gnu/sto= re/924np2k8f04lfjr6l9hzic7drah8bgbb-ruby-mini-portile-2.4.0/lib/ruby/vendor= _ruby:/gnu/store/9yqh0g1p5bmxar8dlfp84j4py3j631jv-ruby-2.6.5/lib/ruby/gems/= 2.6.0', > execute `gem env` for more information > > which suggests that the GEM_PATH is set correctly (after all it found > mustache), but the dependencies do not have the expected version. Does > that make sense? > --000000000000e1924b05ad5097fb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, you are correct. This turned out to be a false a= larm. I poked around with the definition, and, just like you said, everythi= ng works.

`ronn` not running was a gempspec issue = that I have resolved in the package definition (patch attached).
=
Thank you very much for clearing the matter out!

On= Thu, Aug 20, 2020 at 6:17 PM Julien Lepiller <julien@lepiller.eu> wrote:
Le Thu, 20 Aug 2020 17:44:01 +0545,
Prafulla Giri <pratheblackdiamond@gmail.com> a =C3=A9crit :

> Esteemed maintainers,
>
> It seems that (wrap-program ...) over-writes the previous wrapping of<= br> > a package done by the build system.
>
> This does not happen for many (wrap-programs) called in the
> modify-phases section of the package definition itself.
>
> Attached is a package definition for ruby-ronn-ng, that demonstrates > this issue. The custom (wrap-program)-s
> called from the package definition seem to over-write the definitions<= br> > of GEM_ENV as made by the 'wrap %standard-phase
> of the ruby-build system.
> The wrappings made by 'wrap %standard-phase can be seen during the=
> custom 'DEBUG phase. The subsequent 'wrap-program1
> and 'wrap-program2 add more environment variables to the wrapping,=
> but on checking the contents of `which ronn`, once
> it is installed (using `less $(which ronn)`), it can be verified that<= br> > the GEM_ENV package definitions have been overwritten.
>
> This may just be a ruby-build-system issue. Or perhaps it might be
> something that permeates over a few more build systems.
> That still remains to be tested.
>
> Attached are a few different versions of the package definitions for > ruby-ronn-ng for the ease of those who would like to
> verify this.
> 1. ruby-ronn-ng-standalone.scm : To be tested using `guix
> time-machine -- build --verbosity=3D2
> --file=3Druby-ronn-ng-standalone.scm`[1] 2. ruby-ronn-ng.scm : To be > appended to the end of the gnu/packages/ruby.scm file in local guix > checkout, and be tested using the local version
> 3. ruby-ronn-ng.patch : To be applied to local guix checkout
>
> [1] - This package definition needs ruby-mustache, which has only
> recently been added to guix. Hence, the time-machine.
>
> NOTE: `ronn` does not work even with `propagated-inputs`. See this
> patch as to why:
> https= ://aur.archlinux.org/cgit/aur.git/tree/0001-allow-mustache-1.0.patch?h=3Dru= by-ronn-ng

Hi,

>From what I see, there is no issue here (unless I'm missing something).=
In the built package, I see bin/ronn is a shell wrapper that defines
the PATH and FOO environment variables and calls bin/.ronn-real.
bin/.ronn-real itself is a ruby script that defines GEM_PATH and calls
bin/.real/ronn, which is the actual program.

I don't see anything wrong with that, but I'm not a ruby expert. In=
fact, when running ronn (from its store path directly), I see the
following error:

/gnu/store/9yqh0g1p5bmxar8dlfp84j4py3j631jv-ruby-2.6.5/lib/ruby/2.6.0/rubyg= ems/dependency.rb:313:in
`to_specs': Could not find 'mustache' (>=3D 0.7.0, ~> 0.7= ) - did find:
[mustache-1.1.1] (Gem::MissingSpecVersionError) Checked in
'GEM_PATH=3D/gnu/store/l8jicf1ibzrgff754mvbc5k14fa62s7a-ruby-ronn-ng-0.= 9.1/lib/ruby/vendor_ruby:/gnu/store/9yqh0g1p5bmxar8dlfp84j4py3j631jv-ruby-2= .6.5/lib/ruby/vendor_ruby:/gnu/store/w1a9ndhvvbw76g19fgx4j78kx3aghi4k-ruby-= kramdown-2.3.0/lib/ruby/vendor_ruby:/gnu/store/jfbzrfd7i8x46q9c8sw26av6kx7j= yr3c-ruby-mustache-1.1.1/lib/ruby/vendor_ruby:/gnu/store/0wsy4yymr5m0wzms0q= v5ak5q21g8c6hs-ruby-nokogiri-1.10.9/lib/ruby/vendor_ruby:/gnu/store/7ncf7v5= prhv4ir8bgdlxa1rz8ph5mlry-ruby-pkg-config-1.2.5/lib/ruby/vendor_ruby:/gnu/s= tore/924np2k8f04lfjr6l9hzic7drah8bgbb-ruby-mini-portile-2.4.0/lib/ruby/vend= or_ruby:/gnu/store/9yqh0g1p5bmxar8dlfp84j4py3j631jv-ruby-2.6.5/lib/ruby/gem= s/2.6.0',
execute `gem env` for more information

which suggests that the GEM_PATH is set correctly (after all it found
mustache), but the dependencies do not have the expected version. Does
that make sense?
--000000000000e1924b05ad5097fb-- --000000000000e1924d05ad5097fd Content-Type: text/x-patch; charset="US-ASCII"; name="ronn-ng-working.patch" Content-Disposition: attachment; filename="ronn-ng-working.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ke2y5ahp0 ZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9ydWJ5LnNjbSBiL2dudS9wYWNrYWdlcy9ydWJ5LnNj bQppbmRleCAwMTAwMjgwODJhLi4wYTI0NTg1NWVlIDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMv cnVieS5zY20KKysrIGIvZ251L3BhY2thZ2VzL3J1Ynkuc2NtCkBAIC0xMTY1OSwzICsxMTY1OSw0 NiBAQCB3aGljaCBzbmFwc2hvdHMgdG8gY29uc2lkZXIgYW5kIHdoYXQgZmlsZXMgdG8gaW5jbHVk ZS4iKQogZGVmaW5lZCBpbiBAZmlsZXsudHJhdmlzLnltbH0gb24geW91ciBsb2NhbCBtYWNoaW5l LCB1c2luZyBAY29kZXtydm19LAogQGNvZGV7cmJlbnZ9LCBvciBAY29kZXtjaHJ1Ynl9IHRvIHRl c3QgZGlmZmVyZW50IHZlcnNpb25zIG9mIFJ1YnkuIikKICAgICAobGljZW5zZSBsaWNlbnNlOmV4 cGF0KSkpCisKKyhkZWZpbmUtcHVibGljIHJ1Ynktcm9ubi1uZworICAocGFja2FnZQorICAgIChu YW1lICJydWJ5LXJvbm4tbmciKQorICAgICh2ZXJzaW9uICIwLjkuMSIpCisgICAgKHNvdXJjZQor ICAgICAob3JpZ2luCisgICAgICAgKG1ldGhvZCB1cmwtZmV0Y2gpCisgICAgICAgKHVyaSAocnVi eWdlbXMtdXJpICJyb25uLW5nIiB2ZXJzaW9uKSkKKyAgICAgICAoc2hhMjU2CisgICAgICAgIChi YXNlMzIKKyAgICAgICAgICIxc2x4Zmc1N2NhYm1oOThmdzUwN3o0a2E2bHdxMXB2YnJxd3BwZmx4 dzY3MDBwaTh5a2ZoIikpKSkKKyAgICAoYnVpbGQtc3lzdGVtIHJ1YnktYnVpbGQtc3lzdGVtKQor ICAgIChhcmd1bWVudHMKKyAgICAgYCgjOnBoYXNlcworICAgICAgIChtb2RpZnktcGhhc2VzICVz dGFuZGFyZC1waGFzZXMKKyAgICAgICAgIChhZGQtYWZ0ZXIKKyAgICAgICAgICAgICAnZXh0cmFj dC1nZW1zcGVjICdmaXgtZ2Vtc3BlYy1tdXN0YWNoZQorICAgICAgICAgICAobGFtYmRhIF8KKyAg ICAgICAgICAgICAoc3Vic3RpdHV0ZSogInJvbm4tbmcuZ2Vtc3BlYyIKKyAgICAgICAgICAgICAg ICgoIig8bXVzdGFjaGU+LmZyZWV6ZS4qfj4pLiooXCIuKiQpIiBhbGwgc3RhcnQgZW5kKQorICAg ICAgICAgICAgICAgIChzdHJpbmctYXBwZW5kIHN0YXJ0ICIgMS4wIiBlbmQpKSkKKyAgICAgICAg ICAgICAjdCkpCisgICAgICAgICAoYWRkLWFmdGVyCisgICAgICAgICAgICAgJ3dyYXAgJ3dyYXAt cHJvZ3JhbQorICAgICAgICAgICAobGFtYmRhKiAoIzprZXkgb3V0cHV0cyAjOmFsbG93LW90aGVy LWtleXMpCisgICAgICAgICAgICAgKGxldCAoKHByb2cgKHN0cmluZy1hcHBlbmQgKGFzc29jLXJl ZiAlb3V0cHV0cyAib3V0IikgIi9iaW4vcm9ubiIpKSkKKyAgICAgICAgICAgICAgIChiZWdpbiAo ZGlzcGxheSAlYnVpbGQtaW5wdXRzKShuZXdsaW5lKSkKKyAgICAgICAgICAgICAgICh3cmFwLXBy b2dyYW0gcHJvZworICAgICAgICAgICAgICAgICBgKCJQQVRIIiAiOiIgc3VmZml4ICwobWFwIChs YW1iZGEgKGV4cF9pbnB0KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKHN0cmluZy1hcHBlbmQgKGFzc29jLXJlZiAlYnVpbGQtaW5wdXRzIGV4cF9pbnB0KSAi L2JpbiIpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcoInJ1 Ynkta3JhbWRvd24iICJydWJ5LW11c3RhY2hlIiAicnVieS1ub2tvZ2lyaSIpKSkpKQorICAgICAg ICAgICAgICN0KSkgKSkpCisgICAgKGlucHV0cworICAgICBgKCgicnVieS1rcmFtZG93biIgLHJ1 Ynkta3JhbWRvd24pCisgICAgICAgKCJydWJ5LW11c3RhY2hlIiAscnVieS1tdXN0YWNoZSkKKyAg ICAgICAoInJ1Ynktbm9rb2dpcmkiICxydWJ5LW5va29naXJpKSkpCisgICAgKHN5bm9wc2lzCisg ICAgICJSb25uLU5HIGJ1aWxkcyBtYW51YWxzIGluIEhUTUwgYW5kIFVuaXggbWFuIHBhZ2UgZm9y bWF0IGZyb20gTWFya2Rvd24uIikKKyAgICAoZGVzY3JpcHRpb24KKyAgICAgIlJvbm4tTkcgYnVp bGRzIG1hbnVhbHMgaW4gSFRNTCBhbmQgVW5peCBtYW4gcGFnZSBmb3JtYXQgZnJvbSBNYXJrZG93 bi4iKQorICAgIChob21lLXBhZ2UgImh0dHBzOi8vZ2l0aHViLmNvbS9hcGphbmtlL3Jvbm4tbmci KQorICAgIChsaWNlbnNlIGxpY2Vuc2U6ZXhwYXQpKSkK --000000000000e1924d05ad5097fd--