unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#75559: gnupg update to 2.4.7 causing guix build -K seahorse to fail
@ 2025-01-14 16:52 Rostislav Svoboda
  2025-01-14 20:45 ` Leo Famulari
  2025-01-15 17:14 ` bug#75589: python-pytorch build failure due to libgpg-error update Rostislav Svoboda
  0 siblings, 2 replies; 7+ messages in thread
From: Rostislav Svoboda @ 2025-01-14 16:52 UTC (permalink / raw)
  To: 75559, ludo

Hello,

I believe the commit:
  64d95c78e3 2024-12-29 gnu: gnupg: Update to 2.4.7.
causes guix build --keep-failed seahorse to fail. The build log shows:

../seahorse-43.0/meson.build:52:22: ERROR: Command
`/tmp/guix-build-seahorse-43.0.drv-0/seahorse-43.0/build-aux/gpg_check_version.py
/gnu/store/bsp4vbhqpzajsdmg2k21l1lalainqasd-gnupg-2.4.7/bin/gpg 2.2.0
2.3.0` failed with status 1.

When rerun on my system, I get:
/tmp/guix-build-seahorse-43.0.drv-0/seahorse-43.0/build-aux/gpg_check_version.py
/gnu/store/bsp4vbhqpzajsdmg2k21l1lalainqasd-gnupg-2.4.7/bin/gpg 2.2.0
2.3.0
2.4.7

From casually looking at gpg_check_version.py, it appears to check
whether the available GPG version is between 2.2.0 and 2.3.0, so 2.4.7
fails that check.

Cheers
Bost




^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#75559: gnupg update to 2.4.7 causing guix build -K seahorse to fail
  2025-01-14 16:52 bug#75559: gnupg update to 2.4.7 causing guix build -K seahorse to fail Rostislav Svoboda
@ 2025-01-14 20:45 ` Leo Famulari
  2025-01-15  1:10   ` Rostislav Svoboda
  2025-01-15 17:14 ` bug#75589: python-pytorch build failure due to libgpg-error update Rostislav Svoboda
  1 sibling, 1 reply; 7+ messages in thread
From: Leo Famulari @ 2025-01-14 20:45 UTC (permalink / raw)
  To: Rostislav Svoboda; +Cc: 75559, ludo

On Tue, Jan 14, 2025 at 05:52:46PM +0100, Rostislav Svoboda wrote:
> I believe the commit:
>   64d95c78e3 2024-12-29 gnu: gnupg: Update to 2.4.7.
> causes guix build --keep-failed seahorse to fail. The build log shows:

Thanks for the report!

> From casually looking at gpg_check_version.py, it appears to check
> whether the available GPG version is between 2.2.0 and 2.3.0, so 2.4.7
> fails that check.

I cloned the seahorse Git repository:

https://gitlab.gnome.org/GNOME/seahorse

Then, I grepped for the string "2.3.0". The only match is in
'meson.build'.

Guix includes seahorse version 43.0. I checked the Git log of
Seahorse's 'meson.build' since version 43.0, and found this interesting
commit:

------
$ git log 43.0..HEAD meson.build
[...]
commit 9260c74779be3d7a378db0671af862ffa3573d42
Author: Xi Ruoyao <xry111@xry111.site>
Date:   Wed Dec 21 20:58:26 2022 +0800

    Allow building with GnuPG-2.4.x
------

This commit is included in Seahorse 47.0 and later versions. Hopefully
that helps!




^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#75559: gnupg update to 2.4.7 causing guix build -K seahorse to fail
  2025-01-14 20:45 ` Leo Famulari
@ 2025-01-15  1:10   ` Rostislav Svoboda
  2025-01-15 19:05     ` Leo Famulari
  0 siblings, 1 reply; 7+ messages in thread
From: Rostislav Svoboda @ 2025-01-15  1:10 UTC (permalink / raw)
  To: Leo Famulari; +Cc: 75559, ludo

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

> This commit is included in Seahorse 47.0 and later versions. Hopefully
> that helps!

Thanks Leo. In theory, the fix should be straightforward (see
attachment). However, we need to be careful:

$ guix search ^seahorse\$ | grep synopsis
synopsis: Manage encryption keys and passwords in the GNOME keyring

Cheers,
Bost

[-- Attachment #2: 0001-gnu-seahorse-Update-to-47.0.1.patch --]
[-- Type: text/x-patch, Size: 1392 bytes --]

From 08e0448224bb2db53facaa58b4cac14c055655ab Mon Sep 17 00:00:00 2001
Message-ID: <08e0448224bb2db53facaa58b4cac14c055655ab.1736902490.git.Rostislav.Svoboda@gmail.com>
From: Rostislav Svoboda <Rostislav.Svoboda@gmail.com>
Date: Wed, 15 Jan 2025 01:50:36 +0100
Subject: [PATCH] gnu: seahorse: Update to 47.0.1.

This fixes <https://issues.guix.gnu.org/75559>.

* gnu/packages/gnome.scm (seahorse): Update to 47.0.1.

Change-Id: I30095f0e3b67d0dfcc263e72bc48f4cd9a1ec7e8
---
 gnu/packages/gnome.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 30038379f5..f24a6b2aa8 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -4500,7 +4500,7 @@ (define-public drawing
 (define-public seahorse
   (package
     (name "seahorse")
-    (version "43.0")
+    (version "47.0.1")
     (source
      (origin
        (method url-fetch)
@@ -4508,7 +4508,7 @@ (define-public seahorse
                            (version-major version) "/" name "-"
                            version ".tar.xz"))
        (sha256
-        (base32 "0bc3xbjzwa4245m6nqzl3v6hzp9hyfbf50iwgwi5hdjglzxin7av"))))
+        (base32 "1k6avgd58v853nchp226qc3fgz0pwxnf7744hyvynzqzlvj1f6cw"))))
     (build-system meson-build-system)
     (arguments
      '(#:glib-or-gtk? #t

base-commit: 7ba52cb34be061d9ce5be1ec6f84770f098321d3
-- 
2.47.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* bug#75589: python-pytorch build failure due to libgpg-error update
  2025-01-14 16:52 bug#75559: gnupg update to 2.4.7 causing guix build -K seahorse to fail Rostislav Svoboda
  2025-01-14 20:45 ` Leo Famulari
@ 2025-01-15 17:14 ` Rostislav Svoboda
  1 sibling, 0 replies; 7+ messages in thread
From: Rostislav Svoboda @ 2025-01-15 17:14 UTC (permalink / raw)
  To: 75589, ludo

[-- Attachment #1: Type: text/plain, Size: 2872 bytes --]

Hello, the following commit:
    eec2c5d6a7 2024-12-29 gnu: libgpg-error: Update to 1.51.
causes guix build python-pytorch to fail. Below are the last few lines
from the build log; the full build log is attached.

Cheers,
Bost


cd /tmp/guix-build-eigen-3.4.0.drv-0/build/test &&
/gnu/store/78wn2hb9q46xg5pa4m2zvigs3n4nqznw-cmake-minimal-3.24.2/bin/cmake
-E cmake_link_script CMakeFiles/mixingtypes_6.dir/link.txt --verbose=1
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/bin/c++
-std=c++03 -pedantic -Wall -Wextra -Wundef -Wcast-align
-Wchar-subscripts -Wnon-virtual-dtor -Wunused-local-typedefs
-Wpointer-arith -Wwrite-strings -Wformat-security -Wlogical-op
-Wenum-conversion -Wdouble-promotion -Wshadow -Wno-psabi
-Wno-variadic-macros -Wno-long-long -fno-check-new -fno-common
-fstrict-aliasing -ansi -O3 -DNDEBUG
CMakeFiles/mixingtypes_6.dir/mixingtypes.cpp.o -o mixingtypes_6
make[3]: Leaving directory '/tmp/guix-build-eigen-3.4.0.drv-0/build'
[ 21%] Built target mixingtypes_6
[ 21%] Linking CXX executable mixingtypes_3
cd /tmp/guix-build-eigen-3.4.0.drv-0/build/test &&
/gnu/store/78wn2hb9q46xg5pa4m2zvigs3n4nqznw-cmake-minimal-3.24.2/bin/cmake
-E cmake_link_script CMakeFiles/mixingtypes_3.dir/link.txt --verbose=1
/gnu/store/86fc8bi3mciljxz7c79jx8zr4wsx7xw8-gcc-11.4.0/bin/c++
-std=c++03 -pedantic -Wall -Wextra -Wundef -Wcast-align
-Wchar-subscripts -Wnon-virtual-dtor -Wunused-local-typedefs
-Wpointer-arith -Wwrite-strings -Wformat-security -Wlogical-op
-Wenum-conversion -Wdouble-promotion -Wshadow -Wno-psabi
-Wno-variadic-macros -Wno-long-long -fno-check-new -fno-common
-fstrict-aliasing -ansi -O3 -DNDEBUG
CMakeFiles/mixingtypes_3.dir/mixingtypes.cpp.o -o mixingtypes_3
make[3]: Leaving directory '/tmp/guix-build-eigen-3.4.0.drv-0/build'
[ 21%] Built target mixingtypes_3
make[2]: Leaving directory '/tmp/guix-build-eigen-3.4.0.drv-0/build'
make[1]: *** [CMakeFiles/Makefile2:3501: CMakeFiles/buildtests.dir/rule] Error 2
make[1]: Leaving directory '/tmp/guix-build-eigen-3.4.0.drv-0/build'
make: *** [Makefile:182: buildtests] Error 2
error: in phase 'check': uncaught exception:
%exception #<&invoke-error program: "make" arguments: ("buildtests"
"-j24") exit-status: 2 term-signal: #f stop-signal: #f>
phase `check' failed after 92.2 seconds
command "make" "buildtests" "-j24" failed with status 2
build process 18 exited with status 256
builder for `/gnu/store/1dcg3vfmib2f63jib57g4hvj2k6cbf8i-eigen-3.4.0.drv'
failed with exit code 1
build of /gnu/store/1dcg3vfmib2f63jib57g4hvj2k6cbf8i-eigen-3.4.0.drv failed
View build log at
'/var/log/guix/drvs/1d/cg3vfmib2f63jib57g4hvj2k6cbf8i-eigen-3.4.0.drv.gz'.
cannot build derivation
`/gnu/store/92k9v3rdympz3djzayr67riah6axd5qq-python-pytorch-2.4.0.drv':
1 dependencies couldn't be built
guix build: error: build of
`/gnu/store/92k9v3rdympz3djzayr67riah6axd5qq-python-pytorch-2.4.0.drv'
failed

[-- Attachment #2: cg3vfmib2f63jib57g4hvj2k6cbf8i-eigen-3.4.0.drv.gz --]
[-- Type: application/gzip, Size: 41937 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#75559: gnupg update to 2.4.7 causing guix build -K seahorse to fail
  2025-01-15  1:10   ` Rostislav Svoboda
@ 2025-01-15 19:05     ` Leo Famulari
  2025-01-16 11:24       ` Rostislav Svoboda
  0 siblings, 1 reply; 7+ messages in thread
From: Leo Famulari @ 2025-01-15 19:05 UTC (permalink / raw)
  To: Rostislav Svoboda; +Cc: 75559, ludo

On Wed, Jan 15, 2025 at 02:10:41AM +0100, Rostislav Svoboda wrote:
> Thanks Leo. In theory, the fix should be straightforward (see
> attachment). However, we need to be careful:
> 
> $ guix search ^seahorse\$ | grep synopsis
> synopsis: Manage encryption keys and passwords in the GNOME keyring

Can you check if the new version of Seahorse provided by your patch
works on your GNOME system?  Sometimes GNOME software is very tightly
coupled, sometimes it might work to update things like this.

And if it doesn't work, we can try just relaxing the version
constraints. There are no relevant code changes in Seahorse before they relaxed
the GnuPG version constraint. They simply released version 43.0,
aupdated some translations, adjusted some variable names related to SSH,
and then allowed GnuPG 2.4.*:

------
$ git log 43.0..9260c747 --oneline
9260c747 Allow building with GnuPG-2.4.x
8e43721e Update Russian translation
3c33ab1f Update Belarusian translation
6170a9bc Add Interlingue translation
d12f2330 Update Dutch translation
6d673637 ssh: avoid stdout and stderr variable names
------

There's actually very few code changes between Seahorse 43 and 47,
overall.




^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#75559: gnupg update to 2.4.7 causing guix build -K seahorse to fail
  2025-01-15 19:05     ` Leo Famulari
@ 2025-01-16 11:24       ` Rostislav Svoboda
  2025-01-16 11:34         ` Liliana Marie Prikler
  0 siblings, 1 reply; 7+ messages in thread
From: Rostislav Svoboda @ 2025-01-16 11:24 UTC (permalink / raw)
  To: Leo Famulari; +Cc: 75559, ludo, Liliana Marie Prikler

> Can you check if the new version of Seahorse provided by your patch
> works on your GNOME system?

The ship has sailed:

6576487c29 2025-01-16 gnu: seahorse: Update to 47.0.1. (4 hours ago)
Liliana Marie Prikler

Please somebody close this bug.

Cheers,
Bost




^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#75559: gnupg update to 2.4.7 causing guix build -K seahorse to fail
  2025-01-16 11:24       ` Rostislav Svoboda
@ 2025-01-16 11:34         ` Liliana Marie Prikler
  0 siblings, 0 replies; 7+ messages in thread
From: Liliana Marie Prikler @ 2025-01-16 11:34 UTC (permalink / raw)
  To: Rostislav Svoboda, Leo Famulari; +Cc: 75559-done, ludo

Am Donnerstag, dem 16.01.2025 um 12:24 +0100 schrieb Rostislav Svoboda:
> > Can you check if the new version of Seahorse provided by your patch
> > works on your GNOME system?
> 
> The ship has sailed:
> 
> 6576487c29 2025-01-16 gnu: seahorse: Update to 47.0.1. (4 hours ago)
> Liliana Marie Prikler
> 
> Please somebody close this bug.
Consider it done.

I independently (re)discovered this and made sure that it runs in my
current GNOME desktop :)

Cheers




^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2025-01-16 11:35 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-14 16:52 bug#75559: gnupg update to 2.4.7 causing guix build -K seahorse to fail Rostislav Svoboda
2025-01-14 20:45 ` Leo Famulari
2025-01-15  1:10   ` Rostislav Svoboda
2025-01-15 19:05     ` Leo Famulari
2025-01-16 11:24       ` Rostislav Svoboda
2025-01-16 11:34         ` Liliana Marie Prikler
2025-01-15 17:14 ` bug#75589: python-pytorch build failure due to libgpg-error update Rostislav Svoboda

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).