From: Rostislav Svoboda <rostislav.svoboda@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 68333-done@debbugs.gnu.org
Subject: bug#68333: Time bomb in icedtea/openjdk
Date: Wed, 10 Jan 2024 22:00:16 +0100 [thread overview]
Message-ID: <CAEtmmeySTMKr-EyX3=NjGZXKn8+gbzMB-7k6uK_6Y1FwhqibMg@mail.gmail.com> (raw)
In-Reply-To: <87zfxdrw1e.fsf@gnu.org>
Hi,
> What do you think of the attached patch? The difference is that it
> patches code at its root (in the actual source tarball rather than after
> it’s been copied), it does so for IcedTea 7 and 8, and there are patch
> files that are slightly clearer than a substitution pattern.
That's clearly a much better solution than that substitution pattern of mine.
Besides, I missed the path difference:
jdk-3.19.0-2d5d2c77faa3:
/make/src/classes/build/tools/generatecurrencydata/GenerateCurrencyData.java
jdk-2.6.13-68b6bb380175:
/make/tools/src/build/tools/generatecurrencydata/GenerateCurrencyData.java
Speaking of which, I'd go for e.g.:
jdk-3.19.0-currency-time-bomb.patch
jdk-2.6.13-currency-time-bomb.patch
instead of:
jdk-currency-time-bomb.patch
jdk-currency-time-bomb2.patch
Yeah naming is hard ;-)
Also, changing the error string from:
time is more than 10 years from present
to:
time is more than 10 years from \"present\"
i.e. adding double quotes will slightly complicate googling for that
error message in the future.
> Pushed as 5c0f77f4241c9beac0c82deae946bfdc70b49ff0.
Thanks
> Let’s hope there’s no similar time bomb elsewhere in the Java stack.
I'm looking aaaand... I haven't found anything so far.
Cheers Bost
next prev parent reply other threads:[~2024-01-10 21:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-07 23:02 bug#68333: Time bomb in icedtea/openjdk Julien Lepiller
2024-01-09 9:51 ` Ludovic Courtès
2024-01-09 11:55 ` Rostislav Svoboda
2024-01-09 21:00 ` Rostislav Svoboda
2024-01-10 14:35 ` Ludovic Courtès
2024-01-10 16:30 ` Ludovic Courtès
2024-01-10 21:00 ` Rostislav Svoboda [this message]
2024-01-18 11:10 ` Simon Tournier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEtmmeySTMKr-EyX3=NjGZXKn8+gbzMB-7k6uK_6Y1FwhqibMg@mail.gmail.com' \
--to=rostislav.svoboda@gmail.com \
--cc=68333-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).