bug#38544: gparted segfaults

bug#38544: gparted segfaults

[Ricardo Wurmus]

This segfaults:

    sudo /gnu/store/yzxyxnxja4y1riwh3mrqrvb7h4vhxlqb-gparted-1.0.0/bin/gparted

--8<---------------cut here---------------start------------->8---
…
(gpartedbin:5364): Gdk-CRITICAL **: 11:06:10.219: gdk_cairo_surface_create_from_pixbuf: assertion 'GDK_IS_PIXBUF (pixbuf)' failed

(gpartedbin:5364): GLib-GObject-CRITICAL **: 11:06:10.219: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

(gpartedbin:5364): Gtk-WARNING **: 11:06:10.273: Error loading theme icon 'drive-harddisk' for stock: Icon 'drive-harddisk' not present in theme Adwaita

(gpartedbin:5364): Gtk-WARNING **: 11:06:10.273: Error loading theme icon 'image-missing' for stock: Failed to load /org/gtk/libgtk/icons/24x24/status/image-missing.png: Unrecognized image file format
/gnu/store/yzxyxnxja4y1riwh3mrqrvb7h4vhxlqb-gparted-1.0.0/bin/gparted: line 202:  5364 Segmentation fault      $BASE_CMD--8<---------------cut here---------------end--------------->8---

This does not segfault:

    sudo -E /gnu/store/yzxyxnxja4y1riwh3mrqrvb7h4vhxlqb-gparted-1.0.0/bin/gparted

The problem here is that when run as root but without the environment of
the current user gparted fails to find the image loader modules.

--
Ricardo

bug#38544: gparted segfaults

[Gábor Boskovits]

Hello,

Ricardo Wurmus <rekado@elephly.net> ezt írta (időpont: 2019. dec. 9., H, 11:11):
>
> This segfaults:
>
>     sudo /gnu/store/yzxyxnxja4y1riwh3mrqrvb7h4vhxlqb-gparted-1.0.0/bin/gparted
>
> --8<---------------cut here---------------start------------->8---
> …
> (gpartedbin:5364): Gdk-CRITICAL **: 11:06:10.219: gdk_cairo_surface_create_from_pixbuf: assertion 'GDK_IS_PIXBUF (pixbuf)' failed
>
> (gpartedbin:5364): GLib-GObject-CRITICAL **: 11:06:10.219: g_object_unref: assertion 'G_IS_OBJECT (object)' failed
>
> (gpartedbin:5364): Gtk-WARNING **: 11:06:10.273: Error loading theme icon 'drive-harddisk' for stock: Icon 'drive-harddisk' not present in theme Adwaita
>
> (gpartedbin:5364): Gtk-WARNING **: 11:06:10.273: Error loading theme icon 'image-missing' for stock: Failed to load /org/gtk/libgtk/icons/24x24/status/image-missing.png: Unrecognized image file format
> /gnu/store/yzxyxnxja4y1riwh3mrqrvb7h4vhxlqb-gparted-1.0.0/bin/gparted: line 202:  5364 Segmentation fault      $BASE_CMD--8<---------------cut here---------------end--------------->8---
>
> This does not segfault:
>
>     sudo -E /gnu/store/yzxyxnxja4y1riwh3mrqrvb7h4vhxlqb-gparted-1.0.0/bin/gparted
>
> The problem here is that when run as root but without the environment of
> the current user gparted fails to find the image loader modules.

Yes, I concur.

I believe this affects multiple packages, but as it is rarely needed
to run them with sudo this did not become apparent. Question is what
needs to be done here. I would say if it is ok to run these with sudo
-E, then we could work it around by documenting this, but the proper
solution would be to ensure that these modules are found.

>
> --
> Ricardo
>
>
>
>

Best regards,
g_bor
-- 
OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:2506:A96C:CF63:0B21

bug#38544: gparted segfaults

[raingloom]

On Mon, 2019-12-09 at 11:10 +0100, Ricardo Wurmus wrote:
> This segfaults:
> 
>     sudo /gnu/store/yzxyxnxja4y1riwh3mrqrvb7h4vhxlqb-gparted-
> 1.0.0/bin/gparted
> 
> --8<---------------cut here---------------start------------->8---
> …
> (gpartedbin:5364): Gdk-CRITICAL **: 11:06:10.219:
> gdk_cairo_surface_create_from_pixbuf: assertion 'GDK_IS_PIXBUF
> (pixbuf)' failed
> 
> (gpartedbin:5364): GLib-GObject-CRITICAL **: 11:06:10.219:
> g_object_unref: assertion 'G_IS_OBJECT (object)' failed
> 
> (gpartedbin:5364): Gtk-WARNING **: 11:06:10.273: Error loading theme
> icon 'drive-harddisk' for stock: Icon 'drive-harddisk' not present in
> theme Adwaita
> 
> (gpartedbin:5364): Gtk-WARNING **: 11:06:10.273: Error loading theme
> icon 'image-missing' for stock: Failed to load
> /org/gtk/libgtk/icons/24x24/status/image-missing.png: Unrecognized
> image file format
> /gnu/store/yzxyxnxja4y1riwh3mrqrvb7h4vhxlqb-gparted-
> 1.0.0/bin/gparted: line 202:  5364 Segmentation fault      $BASE_CMD-
> -8<---------------cut here---------------end--------------->8---
> 
> This does not segfault:
> 
>     sudo -E /gnu/store/yzxyxnxja4y1riwh3mrqrvb7h4vhxlqb-gparted-
> 1.0.0/bin/gparted
> 
> The problem here is that when run as root but without the environment
> of
> the current user gparted fails to find the image loader modules.
> 
> --
> Ricardo


I tried fixing this by adding the wrapper step from glib-or-gtk but
that didn't do anything.

bug#38544: [PATCH] gnu: gparted: Use the Glib-or-GTK build system.

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

Fixes <https://issues.guix.gnu.org/38544>.

* gnu/packages/disk.scm (gparted)[build-system]: Use
glib-or-gtk-build-system.
---

raingloom 写道：
> I tried fixing this by adding the wrapper step from glib-or-gtk but
> that didn't do anything.

Strange, this works for me (after a pointless detour writing a custom wrap phase with shared-mime-info et al):

 gnu/packages/disk.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index a5278d8c8c..6d812f560c 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -78,6 +78,7 @@
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xorg)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system go)
   #:use-module (guix build-system python)
   #:use-module (guix build-system trivial)
@@ -432,7 +433,7 @@ and can dramatically shorten the lifespan of the drive if left unchecked.")
                            version "/gparted-" version ".tar.gz"))
        (sha256
         (base32 "092rgwjh1825fal6v3yafq2wr0i61hh0a2n0j4296zn0zdx7pzp2"))))
-    (build-system gnu-build-system)
+    (build-system glib-or-gtk-build-system)
     (arguments
       ;; Tests require access to paths outside the build container, such
       ;; as '/dev/disk/by-id'
-- 
2.27.0

bug#38544: [PATCH] gnu: gparted: Use the Glib-or-GTK build system.

[Ludovic Courtès]

Hi,

Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix@gnu.org>
skribis:

> Fixes <https://issues.guix.gnu.org/38544>.
>
> * gnu/packages/disk.scm (gparted)[build-system]: Use
> glib-or-gtk-build-system.

Makes sense, LGTM!

Ludo’.

bug#38544: [PATCH] gnu: gparted: Use the Glib-or-GTK build system.

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

Ludovic Courtès 写道：
>> Fixes <https://issues.guix.gnu.org/38544>.
>>
>> * gnu/packages/disk.scm (gparted)[build-system]: Use
>> glib-or-gtk-build-system.
>
> Makes sense, LGTM!

Thanks!  Pushed.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]