From: "Gábor Boskovits" <boskovits@gmail.com>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 32661@debbugs.gnu.org
Subject: bug#32661: modify-phases: detect invalid phase addition
Date: Mon, 10 Sep 2018 10:38:39 +0200 [thread overview]
Message-ID: <CAE4v=phrpqog=3nQfXbwbrZjCFU3Acst_+k4aBRHNfPgE4NzBA@mail.gmail.com> (raw)
In-Reply-To: <877ejxm0z9.fsf@elephly.net>
[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]
Ricardo Wurmus <rekado@elephly.net> ezt írta (időpont: 2018. szept. 7., P
23:51):
> It is possible to add a build phase to a non-existing phase without an
> error. The new build phase will simply not be executed.
>
> This is problematic when an inherited package augments the original
> package’s phases and the original package is changed. Imagine that the
> parent package’s “pre-configure” phase is removed:
>
> ((#:phases original-phases)
> `(modify-phases ,original-phases
> (add-after 'pre-configure 'patch-this
> (lambda _ …))))
>
> This would cause the “patch-this” phase in the child package to be
> skipped without warning.
>
> This kind of thing can be especially confusing in the bootstrap, which
> makes heavy use of inheritance.
>
It would be nice to fix this. Also I have noticed that it is easier to make
mistakes when inheritance is involved, but these tend to only break derived
packages. I am not aware of a facility to make it easier to build all
derived packages. Am I missing something? I guess this would be a useful
tool, but not sure about implementation.
>
> --
> Ricardo
>
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 1670 bytes --]
prev parent reply other threads:[~2018-09-10 8:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 21:50 bug#32661: modify-phases: detect invalid phase addition Ricardo Wurmus
2018-09-10 8:38 ` Gábor Boskovits [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE4v=phrpqog=3nQfXbwbrZjCFU3Acst_+k4aBRHNfPgE4NzBA@mail.gmail.com' \
--to=boskovits@gmail.com \
--cc=32661@debbugs.gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).