From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kF6RKml3zV7jWwAA0tVLHw (envelope-from ) for ; Tue, 26 May 2020 20:09:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iA5/Jml3zV7IXAAAB5/wlQ (envelope-from ) for ; Tue, 26 May 2020 20:09:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2B29E94066D for ; Tue, 26 May 2020 20:09:12 +0000 (UTC) Received: from localhost ([::1]:44814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdfss-0004gt-7Z for larch@yhetil.org; Tue, 26 May 2020 16:09:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdfsl-0004ce-2t for bug-guix@gnu.org; Tue, 26 May 2020 16:09:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34874) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdfsk-0004F3-NQ for bug-guix@gnu.org; Tue, 26 May 2020 16:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jdfsk-0003cu-GF for bug-guix@gnu.org; Tue, 26 May 2020 16:09:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#41546: Shepherd network activation failures on armhf Resent-From: Jesse Dowell Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 26 May 2020 20:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 41546 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 41546@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159052373713927 (code B ref -1); Tue, 26 May 2020 20:09:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 May 2020 20:08:57 +0000 Received: from localhost ([127.0.0.1]:46420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdfsf-0003cZ-AM for submit@debbugs.gnu.org; Tue, 26 May 2020 16:08:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:41120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdfmM-0003Ta-Gn for submit@debbugs.gnu.org; Tue, 26 May 2020 16:02:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdfmM-0000pd-6B for bug-guix@gnu.org; Tue, 26 May 2020 16:02:26 -0400 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]:37959) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdfmL-0007Lh-2c for bug-guix@gnu.org; Tue, 26 May 2020 16:02:25 -0400 Received: by mail-lj1-x230.google.com with SMTP id m18so26085240ljo.5 for ; Tue, 26 May 2020 13:02:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=tHTVRcYYxzF8qsQJeJDlMUphzO2KuVQ9K2DoOjiGeKk=; b=Ppv50K0FpZEgHNAwlAUIntTNTq4dTuqqPWIOdK1readQXLsPamBpDqKlG6Wd9c/4h8 MdhlTn8Zsu6k2ka9pZpzUIfJO2qeRIqvbUDlIyGNh+f3XmVYJL1l0dDtfz+9zceaD8KH DX+e4SOUmRDmELgNfHBVBz5/T2dkkRyZcOdg36g6AKmsTlg7VXNBo6es2Z9DPLqWD6fg 2np6quM9eoNeBIKm9en4wMuGjrSBXMNM8IYW/BxFsTqX4jLp0Ut+9PGKfF+MqldhX5BY 3/UMruZn2SVNaO85VL9u2Bdb4bzTjgomarwllI80a9jy00fH305zvfc3qrS1ocYR1P2y 39tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=tHTVRcYYxzF8qsQJeJDlMUphzO2KuVQ9K2DoOjiGeKk=; b=I47ufDYEr0HwOrSwP7AcSNgXMXFRXJjwFkXJ/lbZeA4SNZk7PrTvoIXQ0kwhzWySdl nkjXvTF6w0bK4RLmCg0A/xT53Ca5IR8nbljvuja4xf56++Knn7HeIQg+aUCapx18Bq7Q PE2HIIy3J9iaXHRA210f50bE10uwaIKys5BXnnzXXrySmpYOswlPdQDF04+Kh8b1A0DG eaqObU3iKl1IrhdJob0j6sjw2whbvXWbcPl7qeIbKqxCtozAXAI6A74gXvRsMmxfdegt m9v+BBdhH2S8eEIwgdhKJ1mVnhiKH7QaDRIvWHeur6qeIFRCxl74IYd/jO3LGAiDkueJ LxrQ== X-Gm-Message-State: AOAM533DPIwETBfyZatP8htOq49a/UZb8zScOHF+lI9/oQIe7nP/ehAx jGEal6jHMZaWta3fgKss6Uw2bXEyzEizIVDxa0/+FjEv X-Google-Smtp-Source: ABdhPJxol9gdMbUEV92jwDLa1KBPlFP0rUhqSua1I7cQ7AdvNarePshpqR0u/7oKKSYkiMDiYYwCl4tAzxrOGIqFqJA= X-Received: by 2002:a2e:994b:: with SMTP id r11mr1246314ljj.331.1590523341958; Tue, 26 May 2020 13:02:21 -0700 (PDT) MIME-Version: 1.0 From: Jesse Dowell Date: Tue, 26 May 2020 16:02:10 -0400 Message-ID: Content-Type: multipart/alternative; boundary="000000000000cdf1ae05a692921c" Received-SPF: pass client-ip=2a00:1450:4864:20::230; envelope-from=jesse.dowell@gmail.com; helo=mail-lj1-x230.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Mailman-Approved-At: Tue, 26 May 2020 16:08:55 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.3 (--) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=Ppv50K0F; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: WzQQG+YMU1da --000000000000cdf1ae05a692921c Content-Type: text/plain; charset="UTF-8" Hello, I recently experienced a problem with the latest master branch code on an armhf device. I was able to track down and fix the issue but it required changes to guix/build/syscalls.scm. My system previously booted correctly but after a recent 'guix pull' and 'guix system reconfigure' my device would fail to activate all networking related services on boot including loopback. The error message on failure in the terminal when trying to 'herd start networking' was unhelpful but manual management of the network interfaces could be completed successfully so it seemed to be an issue specific to the way Shepherd was activating the loopback interface. I was able to track my issue down to recently introduced code in guix/build/syscalls.scm related to the GNU Hurd. The following patch fixes the problem for me. The core of the issue is that the new Hurd related checks use string-suffix? rather than string-contains like the code elsewhere in the module. Whan string-suffix? is used it doesn't match my system %host-type which is "arm-unknown-linux-gnueabihf" and the xxxx-socket-address!/hurd branch is taken rather than xxxx-socket-address!/linux. I don't know if this is only a problem on my unsupported device. I'm running guix system on a Raspberry Pi 4b. Here's the patch that fixes the issue for me. ------------------------- diff --git a/guix/build/syscalls.scm b/guix/build/syscalls.scm index 8070c5546f..6be322d68f 100644 --- a/guix/build/syscalls.scm +++ b/guix/build/syscalls.scm @@ -1404,7 +1404,7 @@ bytevector BV at INDEX." (error "unsupported socket address" sockaddr))))) (define write-socket-address! - (if (string-suffix? "linux-gnu" %host-type) + (if (string-contains %host-type "linux-gnu") write-socket-address!/linux write-socket-address!/hurd)) @@ -1436,7 +1436,7 @@ bytevector BV at INDEX." (vector family))))) (define read-socket-address - (if (string-suffix? "linux-gnu" %host-type) + (if (string-contains %host-type "linux-gnu") read-socket-address/linux read-socket-address/hurd)) --------------------------- Best Regards, Jesse --000000000000cdf1ae05a692921c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

I recently experienced a problem= with the latest master branch code on an armhf device. I was able to track= down and fix the issue but it required changes to guix/build/syscalls.scm.=

My system previously booted correctly but after a= recent=C2=A0'guix pull' and 'guix system reconfigure' my d= evice would fail to activate all networking related services on boot includ= ing loopback.

The error message on failure in the = terminal when trying to 'herd start networking' was unhelpful but m= anual management of the network interfaces could be completed successfully = so it seemed to be an issue specific to the way Shepherd was activating the= loopback interface.

I was able to track my issue = down to recently introduced code in guix/build/syscalls.scm related to the = GNU Hurd.

The following patch fixes the problem fo= r me. The core of the issue is that the new Hurd related=C2=A0 checks use s= tring-suffix? rather than string-contains like the code elsewhere in the mo= dule.=C2=A0

Whan string-suffix? is used it doesn&#= 39;t match my system %host-type which is "arm-unknown-linux-gnueabihf&= quot; and the xxxx-socket-address!/hurd branch is taken rather than xxxx-so= cket-address!/linux.

I don't know if this is o= nly a problem on my unsupported device. I'm running guix system on a Ra= spberry Pi 4b.

Here's the patch that fixes the= issue for me.
-------------------------
diff --git a/g= uix/build/syscalls.scm b/guix/build/syscalls.scm
index 8070c5546f..6be32= 2d68f 100644
--- a/guix/build/syscalls.scm
+++ b/guix/build/syscalls.= scm
@@ -1404,7 +1404,7 @@ bytevector BV at INDEX."
=C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 (error "unsupported socket address" = sockaddr)))))
=C2=A0
=C2=A0(define write-socket-address!
- =C2=A0(= if (string-suffix? "linux-gnu" %host-type)
+ =C2=A0(if (string= -contains %host-type "linux-gnu")
=C2=A0 =C2=A0 =C2=A0 =C2=A0w= rite-socket-address!/linux
=C2=A0 =C2=A0 =C2=A0 =C2=A0write-socket-addre= ss!/hurd))
=C2=A0
@@ -1436,7 +1436,7 @@ bytevector BV at INDEX."=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (vector family)))))
=C2=A0=
=C2=A0(define read-socket-address
- =C2=A0(if (string-suffix? "= linux-gnu" %host-type)
+ =C2=A0(if (string-contains %host-type &quo= t;linux-gnu")
=C2=A0 =C2=A0 =C2=A0 =C2=A0read-socket-address/linux<= br>=C2=A0 =C2=A0 =C2=A0 =C2=A0read-socket-address/hurd))
=C2=A0---------= ------------------

Best Regards,
Jes= se

--000000000000cdf1ae05a692921c--