unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Nikita Karetnikov <nikita.karetnikov@gmail.com>
To: bug-guix@gnu.org
Subject: Re: Add GNU fdisk
Date: Mon, 26 Nov 2012 16:35:09 +0300	[thread overview]
Message-ID: <CAD15K4sWV7T6pceALm0oFEJTt7H8O0nU03nvudp8R1cfkAkM7g@mail.gmail.com> (raw)
In-Reply-To: <87pq31xm3s.fsf@gnu.org>

Hi,

Jason, could you also fix the following?

1. Split the description into several lines. (I usually use Emacs'
'ESC q' for this purpose.)

2. Fix the typo in the description (i.e. "GNU fdisk GNU fdisk").

3. Remove the trailing space from the description.

4. Change the formatting according to this [1] example.

5. Remove the dot from the synopsis.

6. Add a copyright notice.

I have some doubts regarding this line:

(arguments '(#:configure-flags '("CC=gcc")))

Ludo, is it needed?

Ludo is right. 'parted' is the next thing I'm going to package. It may
take a little bit longer than usually because 'parted' has its own
deps which are not available in Guix.

Nikita

[1] https://lists.gnu.org/archive/html/bug-guix/2012-11/msg00032.html

  reply	other threads:[~2012-11-26 13:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-25 22:25 Add GNU fdisk Jason Self
2012-11-26  0:07 ` Ludovic Courtès
2012-11-26 13:35   ` Nikita Karetnikov [this message]
2012-11-26 16:23     ` Ludovic Courtès
2012-11-26 18:47     ` Jason Self
2012-11-26 20:22       ` Ludovic Courtès
2012-11-27 18:29         ` Nikita Karetnikov
2012-11-27 19:15         ` Jason Self
2012-11-27 20:18           ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAD15K4sWV7T6pceALm0oFEJTt7H8O0nU03nvudp8R1cfkAkM7g@mail.gmail.com \
    --to=nikita.karetnikov@gmail.com \
    --cc=bug-guix@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).