attr: No rule to make target `check'.

attr: No rule to make target `check'.

[Nikita Karetnikov]

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]

Hi,

This file raises the following error.

./pre-inst-env guix-build -K attr

[...]

make[1]: Leaving directory
`/tmp/nix-build-2s04qsfn1a8lg3h1h9iwix5f0hzaw0v3-attr-2.4.46.drv-0/attr-2.4.46'
starting phase `check'
make: *** No rule to make target `check'.  Stop.
note: keeping build directory
`/tmp/nix-build-2s04qsfn1a8lg3h1h9iwix5f0hzaw0v3-attr-2.4.46.drv-0'
builder for `/nix/store/2s04qsfn1a8lg3h1h9iwix5f0hzaw0v3-attr-2.4.46.drv'
failed with exit code 1
@ build-failed /nix/store/2s04qsfn1a8lg3h1h9iwix5f0hzaw0v3-attr-2.4.46.drv
/nix/store/7jzhvz82pd8san1iwmvi4sn7xfk6n12h-attr-2.4.46 1 builder for
`/nix/store/2s04qsfn1a8lg3h1h9iwix5f0hzaw0v3-attr-2.4.46.drv' failed
with exit code 1
error: build failed: build of
`/nix/store/2s04qsfn1a8lg3h1h9iwix5f0hzaw0v3-attr-2.4.46.drv' failed

Nikita

[-- Attachment #2: attr.scm --]
[-- Type: application/octet-stream, Size: 1659 bytes --]

;;; Guix --- Nix package management from Guile.         -*- coding: utf-8 -*-
;;; Copyright (C) 2012 Nikita Karetnikov <nikita@karetnikov.org>
;;;
;;; This file is part of Guix.
;;;
;;; Guix is free software; you can redistribute it and/or modify it
;;; under the terms of the GNU General Public License as published by
;;; the Free Software Foundation; either version 3 of the License, or (at
;;; your option) any later version.
;;;
;;; Guix is distributed in the hope that it will be useful, but
;;; WITHOUT ANY WARRANTY; without even the implied warranty of
;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
;;; GNU General Public License for more details.
;;;
;;; You should have received a copy of the GNU General Public License
;;; along with Guix.  If not, see <http://www.gnu.org/licenses/>.

(define-module (distro packages attr)
  #:use-module (distro packages gettext)
  #:use-module (guix packages)
  #:use-module (guix download)
  #:use-module (guix build-system gnu))

(define-public attr
  (package
    (name "attr")
    (version "2.4.46")
    (source
     (origin
      (method url-fetch)
      (uri (string-append "mirror://savannah/attr/attr-"
                          version ".src.tar.gz"))
      (sha256
       (base32
        "07qf6kb2zk512az481bbnsk9jycn477xpva1a726n5pzlzf9pmnw"))))
    (build-system gnu-build-system)
    (inputs `(("gettext" ,gettext)))
    (home-page
     "http://savannah.nongnu.org/projects/attr/")
    (synopsis
     "Library and tools for manipulating extended attributes")
    (description
     "Library and tools for manipulating extended attributes.")
    (license '("GPLv2+" "LGPLv2.1+"))))

Re: attr: No rule to make target `check'.

[Ludovic Courtès]

Hi,

Nikita Karetnikov <nikita.karetnikov@gmail.com> skribis:

> starting phase `check'
> make: *** No rule to make target `check'.  Stop.

Two cases:

  - if there’s not test suite at all, just add:
    (arguments '(#:tests? #f)).

  - if there is a test suite, but under a different ‘make’ target, or
    that has to be run by some script, then you should replace the
    ‘check’ phase by one that DTRT:

    (arguments '(#:phases (alist-replace 'check
                                         (lambda _
                                           (zero? (system* "./run-the-tests")))
                                          %standard-phases)))

Thanks,
Ludo’.

Re: attr: No rule to make target `check'.

[Nikita Karetnikov]

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]

I've attached the patch. We have to change it to call 'make
install-dev' because of 'acl'. How to do it?

# ./pre-inst-env guix-build -K acl

[...]

checking attr/xattr.h usability... no
checking attr/xattr.h presence... no
checking for attr/xattr.h... no

FATAL ERROR: attr/xattr.h does not exist.
Install the extended attributes (attr) development package.
Alternatively, run "make install-dev" from the attr source.
note: keeping build directory
`/tmp/nix-build-b25ama3yvyh1lj8mmrzx6f1yasivh6gl-acl-2.2.51.drv-0'
builder for `/nix/store/b25ama3yvyh1lj8mmrzx6f1yasivh6gl-acl-2.2.51.drv'
failed with exit code 1
@ build-failed /nix/store/b25ama3yvyh1lj8mmrzx6f1yasivh6gl-acl-2.2.51.drv
/nix/store/83cb7g0rn5wv3l3zgyg3rpfgz0nsr53g-acl-2.2.51 1 builder for
`/nix/store/b25ama3yvyh1lj8mmrzx6f1yasivh6gl-acl-2.2.51.drv' failed
with exit code 1
error: build failed: build of
`/nix/store/b25ama3yvyh1lj8mmrzx6f1yasivh6gl-acl-2.2.51.drv' failed

Also, should we place 'attr' and 'acl' in the same file? What name should I use?

[-- Attachment #2: 0001-distro-Add-Attr.patch --]
[-- Type: text/x-diff, Size: 3028 bytes --]

From 3b7cc13f4876d95467940a9cdaf140f8fb441048 Mon Sep 17 00:00:00 2001
From: Nikita Karetnikov <nikita@karetnikov.org>
Date: Wed, 5 Dec 2012 15:47:13 +0000
Subject: [PATCH] distro: Add Attr.

* distro/packages/attr.scm: New file.
* Makefile.am (MODULES): Add it.
---
 Makefile.am              |    1 +
 distro/packages/attr.scm |   50 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 51 insertions(+), 0 deletions(-)
 create mode 100644 distro/packages/attr.scm

diff --git a/Makefile.am b/Makefile.am
index fab85ae..822d82d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -42,6 +42,7 @@ MODULES =					\
   guix/snix.scm					\
   guix.scm					\
   distro.scm					\
+  distro/packages/attr.scm			\
   distro/packages/autotools.scm			\
   distro/packages/base.scm			\
   distro/packages/bash.scm			\
diff --git a/distro/packages/attr.scm b/distro/packages/attr.scm
new file mode 100644
index 0000000..566214d
--- /dev/null
+++ b/distro/packages/attr.scm
@@ -0,0 +1,50 @@
+;;; Guix --- Nix package management from Guile.         -*- coding: utf-8 -*-
+;;; Copyright (C) 2012 Nikita Karetnikov <nikita@karetnikov.org>
+;;;
+;;; This file is part of Guix.
+;;;
+;;; Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (distro packages attr)
+  #:use-module ((distro packages gettext)
+                #:renamer (symbol-prefix-proc 'guix:))
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu))
+
+(define-public attr
+  (package
+    (name "attr")
+    (version "2.4.46")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "mirror://savannah/attr/attr-"
+                          version ".src.tar.gz"))
+      (sha256
+       (base32
+        "07qf6kb2zk512az481bbnsk9jycn477xpva1a726n5pzlzf9pmnw"))))
+    (build-system gnu-build-system)
+    (arguments '(#:phases (alist-replace 'check
+                                         (lambda _
+                                           (zero? (system* "test/run")))
+                                         %standard-phases)))
+    (inputs `(("gettext" ,guix:gettext)))
+    (home-page
+     "http://savannah.nongnu.org/projects/attr/")
+    (synopsis
+     "Library and tools for manipulating extended attributes")
+    (description
+     "Library and tools for manipulating extended attributes.")
+    (license '("GPLv2+" "LGPLv2.1+"))))
\ No newline at end of file
-- 
1.7.5.4

Re: attr: No rule to make target `check'.

[Ludovic Courtès]

Nikita Karetnikov <nikita.karetnikov@gmail.com> skribis:

> I've attached the patch. We have to change it to call 'make
> install-dev' because of 'acl'. How to do it?

Likewise, replace the ‘install’ phase:

  (arguments
    '(#:phases
       (alist-replace 'install
                      (lambda _
                        (zero? (system* "make" "install-dev")))
                      (alist-replace 'check
                                      ...))))

I realize it’d be more convenient to have #:test-target and
#:install-target arguments.  We should add that eventually.

Thanks,
Ludo’.

Re: attr: No rule to make target `check'.

[Nikita Karetnikov]

[-- Attachment #1: Type: text/plain, Size: 999 bytes --]

How to patch it?

# ./pre-inst-env guix-build -K acl

[...]

gcc: error: /nix/store/iwvgjdll9yw44sixry38z003n1bzikz7-attr-2.4.46/lib/libattr.so:
No such file or directory
make[2]: *** [libacl.la] Error 1
make[2]: Leaving directory
`/tmp/nix-build-k7515033a3ramdqzsgj231gyp60kmnn9-acl-2.2.51.drv-1/acl-2.2.51/libacl'
make[1]: *** [libacl] Error 2
make[1]: Leaving directory
`/tmp/nix-build-k7515033a3ramdqzsgj231gyp60kmnn9-acl-2.2.51.drv-1/acl-2.2.51'
make: *** [default] Error 2
note: keeping build directory
`/tmp/nix-build-k7515033a3ramdqzsgj231gyp60kmnn9-acl-2.2.51.drv-1'
builder for `/nix/store/k7515033a3ramdqzsgj231gyp60kmnn9-acl-2.2.51.drv'
failed with exit code 1
@ build-failed /nix/store/k7515033a3ramdqzsgj231gyp60kmnn9-acl-2.2.51.drv
/nix/store/xk17p6kya207hhyvfla8nvaiv18wcf1l-acl-2.2.51 1 builder for
`/nix/store/k7515033a3ramdqzsgj231gyp60kmnn9-acl-2.2.51.drv' failed
with exit code 1
error: build failed: build of
`/nix/store/k7515033a3ramdqzsgj231gyp60kmnn9-acl-2.2.51.drv' failed

[-- Attachment #2: attr.scm --]
[-- Type: application/octet-stream, Size: 2216 bytes --]

;;; Guix --- Nix package management from Guile.         -*- coding: utf-8 -*-
;;; Copyright (C) 2012 Nikita Karetnikov <nikita@karetnikov.org>
;;; Copyright (C) 2012 Ludovic Courtès <ludo@gnu.org>
;;;
;;; This file is part of Guix.
;;;
;;; Guix is free software; you can redistribute it and/or modify it
;;; under the terms of the GNU General Public License as published by
;;; the Free Software Foundation; either version 3 of the License, or (at
;;; your option) any later version.
;;;
;;; Guix is distributed in the hope that it will be useful, but
;;; WITHOUT ANY WARRANTY; without even the implied warranty of
;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
;;; GNU General Public License for more details.
;;;
;;; You should have received a copy of the GNU General Public License
;;; along with Guix.  If not, see <http://www.gnu.org/licenses/>.

(define-module (distro packages attr)
  #:use-module ((distro packages gettext)
                #:renamer (symbol-prefix-proc 'guix:))
  #:use-module (guix packages)
  #:use-module (guix download)
  #:use-module (guix build-system gnu))

(define-public attr
  (package
    (name "attr")
    (version "2.4.46")
    (source
     (origin
      (method url-fetch)
      (uri (string-append "mirror://savannah/attr/attr-"
                          version ".src.tar.gz"))
      (sha256
       (base32
        "07qf6kb2zk512az481bbnsk9jycn477xpva1a726n5pzlzf9pmnw"))))
    (build-system gnu-build-system)
    (arguments '(#:phases
                 (alist-replace 'install
                                (lambda _
                                  (zero? (system* "make" "install-dev")))
                                (alist-replace 'check
                                               (lambda _
                                                 (zero? (system* "test/run")))
                                               %standard-phases))))
    (inputs `(("gettext" ,guix:gettext)))
    (home-page
     "http://savannah.nongnu.org/projects/attr/")
    (synopsis
     "Library and tools for manipulating extended attributes")
    (description
     "Library and tools for manipulating extended attributes.")
    (license '("GPLv2+" "LGPLv2.1+"))))

[-- Attachment #3: acl.scm --]
[-- Type: application/octet-stream, Size: 1769 bytes --]

;;; Guix --- Nix package management from Guile.         -*- coding: utf-8 -*-
;;; Copyright (C) 2012 Nikita Karetnikov <nikita@karetnikov.org>
;;;
;;; This file is part of Guix.
;;;
;;; Guix is free software; you can redistribute it and/or modify it
;;; under the terms of the GNU General Public License as published by
;;; the Free Software Foundation; either version 3 of the License, or (at
;;; your option) any later version.
;;;
;;; Guix is distributed in the hope that it will be useful, but
;;; WITHOUT ANY WARRANTY; without even the implied warranty of
;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
;;; GNU General Public License for more details.
;;;
;;; You should have received a copy of the GNU General Public License
;;; along with Guix.  If not, see <http://www.gnu.org/licenses/>.

(define-module (distro packages acl)
  #:use-module (distro packages attr)
  #:use-module ((distro packages gettext)
                #:renamer (symbol-prefix-proc 'guix:))
  #:use-module (guix packages)
  #:use-module (guix download)
  #:use-module (guix build-system gnu))

(define-public acl
  (package
    (name "acl")
    (version "2.2.51")
    (source
     (origin
      (method url-fetch)
      (uri (string-append "mirror://savannah/acl/acl-"
                          version ".src.tar.gz"))
      (sha256
       (base32
        "09aj30m49ivycl3irram8c3givc0crivjm3ymw0nhfaxrwhlb186"))))
    (build-system gnu-build-system)
    (inputs `(("attr" ,attr) ("gettext" ,guix:gettext)))
    (home-page
     "http://savannah.nongnu.org/projects/acl")
    (synopsis
     "Library and tools for manipulating access control lists")
    (description
     "Library and tools for manipulating access control lists.")
    (license '("GPLv2+" "LGPLv2.1+"))))

Re: attr: No rule to make target `check'.

[Ludovic Courtès]

Nikita Karetnikov <nikita.karetnikov@gmail.com> skribis:

> gcc: error: /nix/store/iwvgjdll9yw44sixry38z003n1bzikz7-attr-2.4.46/lib/libattr.so:
> No such file or directory
> make[2]: *** [libacl.la] Error 1

You could check whether libattr was built with --enable-shared.  It
should have installed libattr.la, libattr.so, and possibly libattr.a.

Ludo’.

Re: attr: No rule to make target `check'.

[Nikita Karetnikov]

> You could check whether libattr was built with --enable-shared.  It
> should have installed libattr.la, libattr.so, and possibly libattr.a.

# ls /nix/store/iwvgjdll9yw44sixry38z003n1bzikz7-attr-2.4.46/lib
libattr.a  libattr.la  libattr.so

Re: attr: No rule to make target `check'.

[Ludovic Courtès]

Nikita Karetnikov <nikita.karetnikov@gmail.com> skribis:

> # ls /nix/store/iwvgjdll9yw44sixry38z003n1bzikz7-attr-2.4.46/lib
> libattr.a  libattr.la  libattr.so

Could it be that libattr.so is a dangling symlink?  Try ‘ls -l’.

Ludo’.

Re: attr: No rule to make target `check'.

[Nikita Karetnikov]

2012/12/6, Ludovic Courtès <ludo@gnu.org>:
> Nikita Karetnikov <nikita.karetnikov@gmail.com> skribis:
>
>> # ls /nix/store/iwvgjdll9yw44sixry38z003n1bzikz7-attr-2.4.46/lib
>> libattr.a  libattr.la  libattr.so
>
> Could it be that libattr.so is a dangling symlink?  Try ‘ls -l’.
>
> Ludo’.
>

Re: attr: No rule to make target `check'.

[Nikita Karetnikov]

> Could it be that libattr.so is a dangling symlink?  Try ‘ls -l’.

You're right.

# ls -l /nix/store/l2flx95wgcf0i7nlivgz7p4z8h8qfkak-attr-2.4.46/lib
total 8
libattr.a -> /nix/store/l2flx95wgcf0i7nlivgz7p4z8h8qfkak-attr-2.4.46/libexec/libattr.a
libattr.la -> /nix/store/l2flx95wgcf0i7nlivgz7p4z8h8qfkak-attr-2.4.46/libexec/libattr.la
libattr.so -> libattr.so.1

The following didn't help.

(arguments
  `(#:configure-flags
    '("--enable-shared") ...))

Re: attr: No rule to make target `check'.

[Ludovic Courtès]

Hi,

Nikita Karetnikov <nikita.karetnikov@gmail.com> skribis:

>> Could it be that libattr.so is a dangling symlink?  Try ‘ls -l’.
>
> You're right.
>
> # ls -l /nix/store/l2flx95wgcf0i7nlivgz7p4z8h8qfkak-attr-2.4.46/lib
> total 8
> libattr.a -> /nix/store/l2flx95wgcf0i7nlivgz7p4z8h8qfkak-attr-2.4.46/libexec/libattr.a
> libattr.la -> /nix/store/l2flx95wgcf0i7nlivgz7p4z8h8qfkak-attr-2.4.46/libexec/libattr.la
> libattr.so -> libattr.so.1

Yes, Nixpkgs[0] has this:

  installTargets = "install install-lib install-dev";

Meaning that “make install” alone isn’t enough.  So I’d recommend doing
the same, basically.  :-)

When in doubt, checking how others do it is often helpful (not always,
because sometimes they were just as clueless ;-)).

HTH,
Ludo’.

PS: IRC may be more appropriate for this kind of debugging.  I’m often
    on #guix and #guile on Freenode, if that’s an option for you.

[0] https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/libraries/attr/default.nix

Re: attr: No rule to make target `check'.

[Nikita Karetnikov]

The hashes are different.

# ./pre-inst-env guix-build -K attr

[...]

stripping binaries in
"/nix/store/iwvgjdll9yw44sixry38z003n1bzikz7-attr-2.4.46/lib" with
flags ("--strip-debug")
strip: '/nix/store/iwvgjdll9yw44sixry38z003n1bzikz7-attr-2.4.46/lib/libattr.so':
No such file
strip:/nix/store/iwvgjdll9yw44sixry38z003n1bzikz7-attr-2.4.46/lib/libattr.la:
File format not recognized
stripping binaries in
"/nix/store/iwvgjdll9yw44sixry38z003n1bzikz7-attr-2.4.46/libexec" with
flags ("--strip-debug")
strip: '/nix/store/iwvgjdll9yw44sixry38z003n1bzikz7-attr-2.4.46/libexec/libattr.so':
No such file
strip:/nix/store/iwvgjdll9yw44sixry38z003n1bzikz7-attr-2.4.46/libexec/libattr.la:
File format not recognized
@ build-succeeded
/nix/store/kqzpbzr07yjfqa48kc7l8g2mampqm06n-attr-2.4.46.drv
/nix/store/iwvgjdll9yw44sixry38z003n1bzikz7-attr-2.4.46
/nix/store/iwvgjdll9yw44sixry38z003n1bzikz7-attr-2.4.46

# ./pre-inst-env guix-build -S attr

[...]

/nix/store/3hjm6k2zq0f2yvjgr61q7zs7386fyhpr-attr-2.4.46.src.tar.gz

Re: attr: No rule to make target `check'.

[Nikita Karetnikov]

> The hashes are different.

Oops, it's supposed to be like that.