unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Greg Hogan <code@greghogan.com>
To: Andy Tai <atai@atai.org>
Cc: 63526@debbugs.gnu.org
Subject: bug#63526: [PATCH] gnu: hubbub: Disable building tests
Date: Thu, 25 May 2023 09:02:44 -0400	[thread overview]
Message-ID: <CA+3U0ZnSpb-Rdws3AuFtf5=NAZYKjs0J7wc-Wyh0gg6iWffRQQ@mail.gmail.com> (raw)
In-Reply-To: <0b33a2a18cd178f84c55db0b295b0d0010d3cbd1.1684737820.git.atai@atai.org>

On Mon, May 22, 2023 at 2:46 AM Andy Tai <atai@atai.org> wrote:
>
> Fix for https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63526
>
> * gnu/packages/web.scm (hubbub): [arguments] (tests): Set to #f to disable test build
> ---
>  gnu/packages/web.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
> index fe52f673e2..203e3283cf 100644
> --- a/gnu/packages/web.scm
> +++ b/gnu/packages/web.scm
> @@ -5252,7 +5252,9 @@ (define-public hubbub
>             perl))
>      (propagated-inputs
>       (list libparserutils)) ;for libhubbub.pc
> -    (arguments netsurf-buildsystem-arguments)
> +    (arguments
> +     `(#:tests? #f  ;build error in building tests with gcc 11; skip for now
> +       ,@netsurf-buildsystem-arguments))
>      (home-page "https://www.netsurf-browser.org/projects/hubbub/")
>      (synopsis "HTML5 compliant parsing library")
>      (description
>
> base-commit: 3abcf1663b86bc075e29563140698d8bfae44992
> --
> 2.40.1

Hi Andy,

Disabling tests should be a last resort, especially without a process
to evaluate re-enabling tests in the future.

Based on the error, can we instead add
"-Wno-error=maybe-uninitialized" to the configure-flags?

Greg




  reply	other threads:[~2023-05-25 13:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-15 19:24 bug#63526: hubbub build failure when doing guix package -u Andy Tai
2023-05-22  6:44 ` bug#63526: [PATCH] gnu: hubbub: Disable building tests Andy Tai
2023-05-25 13:02   ` Greg Hogan [this message]
2023-05-25 13:35     ` Bruno Victal
2023-05-25 17:54       ` Andy Tai
2023-05-27  7:29 ` bug#63526: [PATCH v2] gnu (hubbub): Fix build Andy Tai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+3U0ZnSpb-Rdws3AuFtf5=NAZYKjs0J7wc-Wyh0gg6iWffRQQ@mail.gmail.com' \
    --to=code@greghogan.com \
    --cc=63526@debbugs.gnu.org \
    --cc=atai@atai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).