From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mOK5G8rtW2CafwEAgWs5BA (envelope-from ) for ; Thu, 25 Mar 2021 02:56:26 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id ODU1F8rtW2AnOQAAbx9fmQ (envelope-from ) for ; Thu, 25 Mar 2021 01:56:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A0A901B3F6 for ; Thu, 25 Mar 2021 02:56:25 +0100 (CET) Received: from localhost ([::1]:49280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPFEW-00037r-1f for larch@yhetil.org; Wed, 24 Mar 2021 21:56:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPFEB-00035y-0r for bug-guix@gnu.org; Wed, 24 Mar 2021 21:56:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53393) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPFEA-0000uh-PL for bug-guix@gnu.org; Wed, 24 Mar 2021 21:56:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lPFEA-0001tM-OF for bug-guix@gnu.org; Wed, 24 Mar 2021 21:56:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#47375: guix test failure: tests/print Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 25 Mar 2021 01:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47375 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: =?UTF-8?Q?L=C3=A9o?= Le Bouter , 47375@debbugs.gnu.org Received: via spool by 47375-submit@debbugs.gnu.org id=B47375.16166373087187 (code B ref 47375); Thu, 25 Mar 2021 01:56:02 +0000 Received: (at 47375) by debbugs.gnu.org; 25 Mar 2021 01:55:08 +0000 Received: from localhost ([127.0.0.1]:36702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPFDI-0001rr-4r for submit@debbugs.gnu.org; Wed, 24 Mar 2021 21:55:08 -0400 Received: from lepiller.eu ([89.234.186.109]:41974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPFDF-0001rg-W3 for 47375@debbugs.gnu.org; Wed, 24 Mar 2021 21:55:07 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 52c9d556; Thu, 25 Mar 2021 01:55:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date :in-reply-to:references:mime-version:content-type :content-transfer-encoding:subject:to:from:message-id; s=dkim; bh=tpqNPFFUYl9NEm2LmJgFBj/DsuoojJ6YzZ5zxIEOQK0=; b=RoLiIZ/PVmxd cCg26L5Zke7YKMeu477yc5SQUbAkYuw+m3SfYt6je7kNQohvwG0YLbCQbnCr2dL1 AId5gB4dyTgGpMsB1LDAYCZQQQNx7fUClE6/lbVFhycPLYUHBdGAbBfvvtFkeuJg PqShCae2BosAsp7nwwLHe6Q5QaLEdt4FaHGw0LaD5A5kopBLpIrKluI9ZE1lrTX9 tD9UYawQFpcK01VP4jmUOujHRotUjq03qeaqvT4HQeZafzUhe32N3+lzKpMa8+Q/ u2kwTZ20qq2jpL7Vo4/b1ca3cn62UT5aJ7aVxlhkV/+wMTyV4oFDKoZ38cnnOxyn LwJ2ZWRH7w== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id b7f4c5a0 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Thu, 25 Mar 2021 01:55:02 +0000 (UTC) Date: Wed, 24 Mar 2021 21:54:48 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <818412ea23ae7ce27a673afd1dfe3bb9d758c340.camel@zaclys.net> References: <818412ea23ae7ce27a673afd1dfe3bb9d758c340.camel@zaclys.net> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----DOP79KM1ABWVQNN2LO4H1IRUT0GHMF" Content-Transfer-Encoding: 7bit From: Julien Lepiller Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616637386; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=gitNzQvNnSrImCkBh7BuYD4DFKhxJL+iBlLZK0B+V9Q=; b=BzTZGJ+vNAgpG4qJzavbIcNhvqfWhQ89qIw/o+AReuNDKF1sJRzWVO8E2CrMiHkHWlibew xAYGIp6h88DL14b5VMxWCt3PY8n6WArMYc8jbfNR4W9iXyWHONoJnBHtjSdRe5oPZ53vpd BETw3RW1tI28brw9z+ecTjTq6QnD345TDG3jPJZ7iwuP7FApDWBmdy2Eo+Rvfz8w5T0AFh Ss7Wp7q3LupKJJhduxq2cp7hxiohGraa3SdUZK2yeSsrLf9R+f6dT6TQlEocrgLnZOQ9GT JF4EuQ2yFvzSuLMD6ZDJG+SubpqnDkrgfX0i8fCmzhY8v9eRiHkj11PNnk3cnw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616637386; a=rsa-sha256; cv=none; b=MOeVGR2YE9SBLYJHmBqkb3HqoOcQmiWH2VKnPsaytbsnPFP6fkWYGFxdIewbnIHiwOiTSP OZGmNk+yrMG9ihnYXNVsAsmIxF8sl+g5YR6CrGKH6ZIspjNYuUQRjQmY/7bOuZJT/swxg8 Od1eh56b5ejMySy385ANvA1Nr/sfLTdpJ6bmcDMUNQJFnieIGouwMQaxRj9KpcUP6bBMRt dX0GKAlLro61Xd+mMkay0fzn70DiQR/a8Zer6KYOJf2Bo/JUlp53hDrCsI1RPTlWrKGAp/ rrXbqHHJE+V1NzYG8zKlxOKficFDMBrA+m/YCXufY2CAhIF0XpbnD+R7xr6rbA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="RoLiIZ/P"; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: 0.18 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="RoLiIZ/P"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: A0A901B3F6 X-Spam-Score: 0.18 X-Migadu-Scanner: scn0.migadu.com X-TUID: wc2oVPmWKf3L ------DOP79KM1ABWVQNN2LO4H1IRUT0GHMF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I don't think this is the right fix=2E Now you define packages with the inc= orrect url-fetch, so the test passes, but package->code would still not wor= k as intended on actual packages that are properly defined=2E It seems that the issue is package->code uses the internal name url-fetch*= whereas it should be the exported name url-fetch=2E I think this is a legi= timate bug in package->code and your patch incorrectly hides it=2E Le 24 mars 2021 21:44:37 GMT-04:00, "L=C3=A9o Le Bouter via Bug reports fo= r GNU Guix" a =C3=A9crit : >FAIL: tests/print >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >test-name: simple package >location: /tmp/guix-build-guix-1=2E2=2E0-18=2E86dd54f=2Edrv- >0/source/tests/print=2Escm:70 >source: >+ (test-equal >+ "simple package" >+ `(define-public test ,pkg-source) >+ (package->code pkg)) >expected-value: (define-public test (package (name "test") (version >"1=2E2=2E3") (source (origin (method url-fetch) (uri (string-append >"file:///tmp/test-" version "=2Etar=2Egz")) (sha256 (base32 >"070pwb7brdcn1mfvplkd56vjc7lbz4iznzkqvfsakvgbv68k71ah")))) (build- >system (@ (guix build-system gnu) gnu-build-system)) (home-page " >http://gnu=2Eorg") (synopsis "Dummy") (description "This is a dummy >package=2E") (license license:gpl3+))) >actual-value: (define-public test (package (name "test") (version >"1=2E2=2E3") (source (origin (method url-fetch*) (uri (string-append >"file:///tmp/test-" version "=2Etar=2Egz")) (sha256 (base32 >"070pwb7brdcn1mfvplkd56vjc7lbz4iznzkqvfsakvgbv68k71ah")))) (build- >system (@ (guix build-system gnu) gnu-build-system)) (home-page " >http://gnu=2Eorg") (synopsis "Dummy") (description "This is a dummy >package=2E") (license license:gpl3+))) >result: FAIL > >test-name: package with inputs >location: /tmp/guix-build-guix-1=2E2=2E0-18=2E86dd54f=2Edrv- >0/source/tests/print=2Escm:74 >source: >+ (test-equal >+ "package with inputs" >+ `(define-public test ,pkg-with-inputs-source) >+ (package->code pkg-with-inputs)) >expected-value: (define-public test (package (name "test") (version >"1=2E2=2E3") (source (origin (method url-fetch) (uri (string-append >"file:///tmp/test-" version "=2Etar=2Egz")) (sha256 (base32 >"070pwb7brdcn1mfvplkd56vjc7lbz4iznzkqvfsakvgbv68k71ah")))) (build- >system (@ (guix build-system gnu) gnu-build-system)) (inputs >(quasiquote (("coreutils" (unquote (@ (gnu packages base) coreutils))) >("glibc" (unquote (@ (gnu packages base) glibc)) "debug")))) (home-page > >"http://gnu=2Eorg") (synopsis "Dummy") (description "This is a dummy >package=2E") (license license:gpl3+))) >actual-value: (define-public test (package (name "test") (version >"1=2E2=2E3") (source (origin (method url-fetch*) (uri (string-append >"file:///tmp/test-" version "=2Etar=2Egz")) (sha256 (base32 >"070pwb7brdcn1mfvplkd56vjc7lbz4iznzkqvfsakvgbv68k71ah")))) (build- >system (@ (guix build-system gnu) gnu-build-system)) (inputs >(quasiquote (("coreutils" (unquote (@ (gnu packages base) coreutils))) >("glibc" (unquote (@ (gnu packages base) glibc)) "debug")))) (home-page > >"http://gnu=2Eorg") (synopsis "Dummy") (description "This is a dummy >package=2E") (license license:gpl3+))) >result: FAIL > >Full log: https://ci=2Eguix=2Egnu=2Eorg/build/117996/log/raw > >Seems related to f7008ca71351e5368a7c1c5bc3fe88fb80b01298 > >This patch fixes the issue but I am not sure it retains the test's >original intent: > >diff --git a/tests/print=2Escm b/tests/print=2Escm >index 3386590d3a=2E=2E85735cf9ae 100644 >--- a/tests/print=2Escm >+++ b/tests/print=2Escm >@@ -19,7 +19,7 @@ > (define-module (test-print) > #:use-module (guix import print) > #:use-module (guix build-system gnu) >- #:use-module (guix download) >+ #:use-module (guix build download) > #:use-module (guix packages) > #:use-module ((guix licenses) #:prefix license:) > #:use-module (srfi srfi-64)) > >Let me know! > >Thank you ------DOP79KM1ABWVQNN2LO4H1IRUT0GHMF Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable I don't think this is the right fix=2E Now you def= ine packages with the incorrect url-fetch, so the test passes, but package-= >code would still not work as intended on actual packages that are prope= rly defined=2E

It seems that the issue is package->code uses the = internal name url-fetch* whereas it should be the exported name url-fetch= =2E I think this is a legitimate bug in package->code and your patch inc= orrectly hides it=2E

Le 24 mars 2021 21:4= 4:37 GMT-04:00, "L=C3=A9o Le Bouter via Bug reports for GNU Guix" <bug-g= uix@gnu=2Eorg> a =C3=A9crit :
FAIL: tests/print
test-name: simple package
lo=
cation: /tmp/guix-build-guix-1=2E2=2E0-18=2E86dd54f=2Edrv-
0/source/test=
s/print=2Escm:70
source:
+ (test-equal
+   "simple package"
+  =
 `(define-public test ,pkg-source)
+   (package->code pkg))
expect=
ed-value: (define-public test (package (name "test") (version
"1=2E2=2E3=
") (source (origin (method url-fetch) (uri (string-append
"file:///tmp/t=
est-" version "=2Etar=2Egz")) (sha256 (base32
"070pwb7brdcn1mfvplkd56vjc=
7lbz4iznzkqvfsakvgbv68k71ah")))) (build-
system (@ (guix build-system gn=
u) gnu-build-system)) (home-page "
http://g=
nu=2Eorg") (synopsis "Dummy") (description "This is a dummy
package=
=2E") (license license:gpl3+)))
actual-value: (define-public test (packa=
ge (name "test") (version
"1=2E2=2E3") (source (origin (method url-fetch=
*) (uri (string-append
"file:///tmp/test-" version "=2Etar=2Egz")) (sha2=
56 (base32
"070pwb7brdcn1mfvplkd56vjc7lbz4iznzkqvfsakvgbv68k71ah")))) (b=
uild-
system (@ (guix build-system gnu) gnu-build-system)) (home-page "<=
br>http://gnu=2Eorg") (synopsis "Dummy") (=
description "This is a dummy
package=2E") (license license:gpl3+)))
r=
esult: FAIL

test-name: package with inputs
location: /tmp/guix-bu=
ild-guix-1=2E2=2E0-18=2E86dd54f=2Edrv-
0/source/tests/print=2Escm:74
=
source:
+ (test-equal
+   "package with inputs"
+   `(define-publi=
c test ,pkg-with-inputs-source)
+   (package->code pkg-with-inputs))<=
br>expected-value: (define-public test (package (name "test") (version
"=
1=2E2=2E3") (source (origin (method url-fetch) (uri (string-append
"file=
:///tmp/test-" version "=2Etar=2Egz")) (sha256 (base32
"070pwb7brdcn1mfv=
plkd56vjc7lbz4iznzkqvfsakvgbv68k71ah")))) (build-
system (@ (guix build-=
system gnu) gnu-build-system)) (inputs
(quasiquote (("coreutils" (unquot=
e (@ (gnu packages base) coreutils)))
("glibc" (unquote (@ (gnu packages=
 base) glibc)) "debug")))) (home-page 
"http://gnu=2Eorg") (synopsis "Du=
mmy") (description "This is a dummy
package=2E") (license license:gpl3+)=
))
actual-value: (define-public test (package (name "test") (version
=
"1=2E2=2E3") (source (origin (method url-fetch*) (uri (string-append
"fi=
le:///tmp/test-" version "=2Etar=2Egz")) (sha256 (base32
"070pwb7brdcn1m=
fvplkd56vjc7lbz4iznzkqvfsakvgbv68k71ah")))) (build-
system (@ (guix buil=
d-system gnu) gnu-build-system)) (inputs
(quasiquote (("coreutils" (unqu=
ote (@ (gnu packages base) coreutils)))
("glibc" (unquote (@ (gnu packag=
es base) glibc)) "debug")))) (home-page 
"http://gnu=2Eorg") (synopsis "=
Dummy") (description "This is a dummy
package=2E") (license license:gpl3=
+)))
result: FAIL

Full log: https://ci=2Eguix=2Egnu=2Eorg/build/117996/log/ra=
w

Seems related to f7008ca71351e5368a7c1c5bc3fe88fb80b01298
<=
br>This patch fixes the issue but I am not sure it retains the test's
or=
iginal intent:

diff --git a/tests/print=2Escm b/tests/print=2Escmindex 3386590d3a=2E=2E85735cf9ae 100644
--- a/tests/print=2Escm
+++ =
b/tests/print=2Escm
@@ -19,7 +19,7 @@
 (define-module (test-print)   #:use-module (guix import print)
   #:use-module (guix build-system =
gnu)
-  #:use-module (guix download)
+  #:use-module (guix build down=
load)
   #:use-module (guix packages)
   #:use-module ((guix licenses=
) #:prefix license:)
   #:use-module (srfi srfi-64))

Let me know!=


Thank you
------DOP79KM1ABWVQNN2LO4H1IRUT0GHMF--