From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id Yg9mJE89EF8RCAAA0tVLHw (envelope-from ) for ; Thu, 16 Jul 2020 11:43:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id mC3UH089EF+1GwAA1q6Kng (envelope-from ) for ; Thu, 16 Jul 2020 11:43:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0C896940703 for ; Thu, 16 Jul 2020 11:43:11 +0000 (UTC) Received: from localhost ([::1]:34168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jw2I9-0006sa-IU for larch@yhetil.org; Thu, 16 Jul 2020 07:43:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jw2I2-0006sA-4J for bug-guix@gnu.org; Thu, 16 Jul 2020 07:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43269) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jw2I1-0000zK-SH for bug-guix@gnu.org; Thu, 16 Jul 2020 07:43:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jw2I1-0002Vb-Ql for bug-guix@gnu.org; Thu, 16 Jul 2020 07:43:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#42289: recursive import does not dort alphabetically Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 16 Jul 2020 11:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42289 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: zimoun , Hartmut Goebel , Leo Famulari Received: via spool by 42289-submit@debbugs.gnu.org id=B42289.15948997349586 (code B ref 42289); Thu, 16 Jul 2020 11:43:01 +0000 Received: (at 42289) by debbugs.gnu.org; 16 Jul 2020 11:42:14 +0000 Received: from localhost ([127.0.0.1]:54815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw2HG-0002UY-2Z for submit@debbugs.gnu.org; Thu, 16 Jul 2020 07:42:14 -0400 Received: from lepiller.eu ([89.234.186.109]:45038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw2HE-0002UP-8W for 42289@debbugs.gnu.org; Thu, 16 Jul 2020 07:42:13 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id eb11a6e4; Thu, 16 Jul 2020 11:42:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date :in-reply-to:references:mime-version:content-type :content-transfer-encoding:subject:to:cc:from:message-id; s= dkim; bh=8fA5T3cf1hBTjy/EsO0iS4Br8NBr4QFYA73QofNfBdk=; b=a1+6/+S M5om5F5FBkNkEYArDrfhIxhqtGB50fMz0zt4lokj+bsCUwD7j+U+TvThBnlRFD0i HRoUkiEElDwn563h6H7+sY7dGMRqlE3T/05302QpTHYX5qHHGTkomjfWaMDQcWbt mBnFTCmE2KSUQwqjbyfcpTumooFkezCCMrZaGYfeWn65hJL+PAsHF9hYk05QVxDP e/maOgff9kh1iQ+KQkoUisSOQk1nc/okW0FQPIU5J3nJmBrSQ+ojZU9jUBuePsKN tI2XukApksptG1VncR5b3qAos5gUezyw6wYLJ+bH/7NTxecSerVPUkdKgEvzqFL4 pIkvH53FDjik2/A== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 09b4db43 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Thu, 16 Jul 2020 11:42:09 +0000 (UTC) Date: Thu, 16 Jul 2020 07:41:58 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <86wo33y9ok.fsf@gmail.com> References: <86zh89av3c.fsf@gmail.com> <87692d5d-0650-c2bd-1533-54b38677d97e@crazy-compilers.com> <20200709173955.GA22616@jasmine.lan> <86wo33y9ok.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Julien Lepiller Message-ID: X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 42289@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=lepiller.eu header.s=dkim header.b=a1+6/+S ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 1.59 X-TUID: b0bK3qAG8BET Le 16 juillet 2020 07:35:23 GMT-04:00, zimoun a =C3=A9crit : >Dear Hartmut, > >On Wed, 15 Jul 2020 at 21:10, Hartmut Goebel > wrote > >> Many modules are sorted and some packages even contain a comment >asking >> for being sorted=2E So I had the impression this is good practice=2E > >I am not sure by the "many"=2E :-) >Even gnu/packages/crate-io=2Escm which explicitly asks: > >;;; Please: Try to add new module packages in alphabetic order=2E > >and it is not really sorted=2E :-) > > cat crates-io=2Escm | grep 'define-public' | sort --check > sort: -:6: disorder: (define-public rust-afl-0=2E5 > > >> Also scanning through the file is easier for humans if packages are >> sorted - depends on personal work style=2E > >It appears to me as a "good practise" too=2E On the other hand, >personally I always scan the packages with "ag" (inside Emacs)=2E > > >However, it is not the point since your initial request is about >alphabetical sort of "guix import"; which seems better than arbitrary >order (dependency order)=2E Whatever if gnu/packages/foo=2Escm is sorted >or >not=2E The advantage of dependency-sorting is that it makes it easier to add pack= ages one by one without breaking anything=2E If they are alphabetically sor= ted, which package do you add first? What if the first one depends on anoth= er imported package? Your first commit will be broken because of a referenc= e to an unexisting package=2E > >If "guix import" returns an alphanumerical sorted list, it is easier >and >it does not bother the unsorted modules since the packages are new=2E > >All the best, >simon