From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GGEDFQn7h2JAuwAAbAwnHQ (envelope-from ) for ; Fri, 20 May 2022 22:33:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id QE/3FAn7h2IkbwEAauVa8A (envelope-from ) for ; Fri, 20 May 2022 22:33:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C207179CD for ; Fri, 20 May 2022 22:33:12 +0200 (CEST) Received: from localhost ([::1]:44786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ns9J9-000274-Ej for larch@yhetil.org; Fri, 20 May 2022 16:33:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ns9J0-000269-My for bug-guix@gnu.org; Fri, 20 May 2022 16:33:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46278) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ns9J0-0000h7-EV for bug-guix@gnu.org; Fri, 20 May 2022 16:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ns9J0-0001g6-Ah for bug-guix@gnu.org; Fri, 20 May 2022 16:33:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#55406: WIP: Image API support for fat16 partitions References: <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> In-Reply-To: <3078A40B-22B0-4492-BFD2-72D725F31689@gmail.com> Resent-From: Pavel Shlyak Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 20 May 2022 20:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55406 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 55406@debbugs.gnu.org Received: via spool by 55406-submit@debbugs.gnu.org id=B55406.16530787656425 (code B ref 55406); Fri, 20 May 2022 20:33:02 +0000 Received: (at 55406) by debbugs.gnu.org; 20 May 2022 20:32:45 +0000 Received: from localhost ([127.0.0.1]:40175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ns9If-0001fV-KG for submit@debbugs.gnu.org; Fri, 20 May 2022 16:32:45 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:58629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ns8i9-0000hH-A9 for 55406@debbugs.gnu.org; Fri, 20 May 2022 15:54:58 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 413D6320096C for <55406@debbugs.gnu.org>; Fri, 20 May 2022 15:54:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 20 May 2022 15:54:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1653076490; x=1653162890; bh=O4VdmWTmofyZC1gQkQS/C+2XhToW2ndFtaW 2uYVubpQ=; b=ah5JDnKGmT2Uh9pamEum60F714iWqgt4z7Joq9RrmsgNjEt+1/i fnjw05LQkyrXkEZH7pBaWnuebB5lu4OLgbu1w7aH+wWGA/24w4+Dz3h2MMRwb8a0 7TZKYoDQEFbpnBbBXg6Wstq5v3PyLN9arZlmpZHpLzeFQEB46zGee/eK03ajOprm sVdRvc7VGu6qC2Sd0mFvwfOMDAsGR7dkrnGhyumN0CxB14BQRuP4fsf80R0lFxN+ uTRh/4EBUAvf06/jPF0a3JaR446xYewGa+bMcQ1okvA9LbwOI21FC8KjTDQpTnaU INDyRx2D8hYDvOffeHZoj3IFK/ihrBQTDHQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653076490; x= 1653162890; bh=O4VdmWTmofyZC1gQkQS/C+2XhToW2ndFtaW2uYVubpQ=; b=S dCtQozNMxlzMIKgOU1O4/pFCYnCYyUexbukQsrjmipYgZDu0njePPTNxPktFVuXs LiXdV2PJXFLONLvVJukuDZoHmuvTdBPOWFC/4V2M3CLu6nTMX2LApQKwgnZPuRJy Oml5tw9DOvoQ97ER8lvJPVXGKsqMR4cGsFTFgwXXeg5iOwedLJQsLkvwYQKmYbpE wRwcp2broOXTBXfUDIWmctUxv/urMJB8Tz9uhjQL1sLRh7QYzTlzoGfb8zOLgkC4 5qZx6/SWbPbjikMPFGZupocFsEeiG/o1+t3EguLnGr/IyIVWNz4nHR0AJyzLDPF0 TGV4sgDByAIE2QGDzAKMg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrieefgddugedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhtggguffkfffvofesmhdtmherhh dtvdenucfhrhhomheprfgrvhgvlhcuufhhlhihrghkuceophdrshhhlhihrghksehprghn thhhvghrgidrohhrgheqnecuggftrfgrthhtvghrnhepjeeiheefieevtefghfegveefhe duffekfeegkeegkefghfefleeljeegvdfhledunecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomhepphdrshhhlhihrghksehprghnthhhvghrgidroh hrgh X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <55406@debbugs.gnu.org>; Fri, 20 May 2022 15:54:50 -0400 (EDT) From: Pavel Shlyak Content-Type: multipart/mixed; boundary="Apple-Mail=_3E4E0DCA-B609-474E-A9E2-3E49666CC6CC" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Message-Id: Date: Fri, 20 May 2022 22:54:47 +0300 X-Mailer: Apple Mail (2.3696.100.31) X-Mailman-Approved-At: Fri, 20 May 2022 16:32:41 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653078793; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=O4VdmWTmofyZC1gQkQS/C+2XhToW2ndFtaW2uYVubpQ=; b=dMAREC3rNKNy+SUsuIywBKZbX+YK8+dbQqhtHCP4NEtHlKX7ZBvBu6znlDfKiZlEOBwwIf +I5gQK9GndDg5yRPrKrLHtjCgfxVz/mfLXlimYj4fVZnW+X3Ps1L4a8MIMGqsGeSz4sIBk eyFac8DfHKUhtJQ+cPua3aZEy2YIcNUK2hRB7tPr+CFFKV1jnl0LzKcKS4+mrp3Mnx6sQx o1JHkhgR7Hx6JPRqPsMW73M91awtrl8iSPUJZv/QE4FpaOamTLlEqD7vLpn1SL/L2fZypm GoFiBLSghwqPRbS4m13o2in2Gx9QH/R702fFDVGFiXVp9IvCSy5FxpI4guIamw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653078793; a=rsa-sha256; cv=none; b=RFpuKDPHtrFTx9dxieBZ53VlxU0lWI9mosiBLF76iKgOdlssYYADmWYnc9npQenepHE3G0 my0Ay0fGk5ZItaz+eQ/igPoVpA3VQi9CLlRtKKNsjjFQZXZtkBMUDO0ygccmNcLP2nSA3C xsDD6XNcFhXFtXYf1rW5NKNbQCtcDY1Tr7CTRJg0xWmlDqDBQ4Xp07KD8KncERHGaZjgNT q9qqeiRC6uUa1lSj8+Kndr7enawRa37NtuIbKWgCqhYuNwEHlTqimmjNfOJj3u6QJa49hi hQfpNyXxdRA7z/qNIorLMulsH7q2byEyox/OsskDz0025kpP7XGgmcsHxSn0Tw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pantherx.org header.s=fm2 header.b=ah5JDnKG; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="S dCtQoz"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 0.06 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pantherx.org header.s=fm2 header.b=ah5JDnKG; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="S dCtQoz"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C207179CD X-Spam-Score: 0.06 X-Migadu-Scanner: scn0.migadu.com X-TUID: /pfufkFSe0vO --Apple-Mail=_3E4E0DCA-B609-474E-A9E2-3E49666CC6CC Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii This patch fixes GPT support for fat partitions. Should be applied after = gpt-support-vfat-partitions.patch --Apple-Mail=_3E4E0DCA-B609-474E-A9E2-3E49666CC6CC Content-Disposition: attachment; filename=gpt-support-vfat-partitions.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="gpt-support-vfat-partitions.patch" Content-Transfer-Encoding: 7bit diff --git a/gnu/system/image.scm b/gnu/system/image.scm index a83f844682..a6267feab2 100644 --- a/gnu/system/image.scm +++ b/gnu/system/image.scm @@ -317,10 +317,15 @@ (define (partition->dos-type partition) (define (partition->gpt-type partition) ;; Return the genimage GPT partition type code corresponding to PARTITION. ;; See https://github.com/pengutronix/genimage/blob/master/README.rst - (let ((flags (partition-flags partition))) + (let ((flags (partition-flags partition)) (file-system (partition-file-system partition))) (cond ((member 'esp flags) "U") - (else "L")))) + ((string-prefix? "ext" file-system) "L") + ((string=? file-system "vfat") "F") + (else + (raise (condition + (&message + (message "unsupported partition type")))))))) (define (partition-image partition) ;; Return as a file-like object, an image of the given PARTITION. A --Apple-Mail=_3E4E0DCA-B609-474E-A9E2-3E49666CC6CC--