unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / Atom feed
* bug#45645: Please revoke this commit: 7dd1a2174a8376c521dcf271e3b76f64096074fe
@ 2021-01-04  1:52 luhux
  2021-01-04 14:14 ` Efraim Flashner
  2021-06-10  6:47 ` Leo Prikler
  0 siblings, 2 replies; 6+ messages in thread
From: luhux @ 2021-01-04  1:52 UTC (permalink / raw)
  To: 45645



Sorry for submitting the wrong patch.

Recently, when I checked the sdcv source code, I found that this environment variable does not support multiple paths and is separated by colons.


```
    const gchar *stardict_data_dir = g_getenv("STARDICT_DATA_DIR");
    std::string data_dir;
    if (!opt_data_dir) {
        if (!only_data_dir) {
            if (stardict_data_dir)
                data_dir = stardict_data_dir;
            else
                data_dir = "/usr/share/stardict/dic";
        }
    } else {
        data_dir = get_impl(opt_data_dir);
    }

```

Please revoke the content of this commit.

luhux




^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#45645: Please revoke this commit: 7dd1a2174a8376c521dcf271e3b76f64096074fe
  2021-01-04  1:52 bug#45645: Please revoke this commit: 7dd1a2174a8376c521dcf271e3b76f64096074fe luhux
@ 2021-01-04 14:14 ` Efraim Flashner
  2021-03-26  9:21   ` zimoun
  2021-06-10  6:47 ` Leo Prikler
  1 sibling, 1 reply; 6+ messages in thread
From: Efraim Flashner @ 2021-01-04 14:14 UTC (permalink / raw)
  To: luhux; +Cc: 45645

[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]

On Mon, Jan 04, 2021 at 09:52:38AM +0800, luhux wrote:
> 
> 
> Sorry for submitting the wrong patch.
> 
> Recently, when I checked the sdcv source code, I found that this environment variable does not support multiple paths and is separated by colons.
> 
> 
> ```
>     const gchar *stardict_data_dir = g_getenv("STARDICT_DATA_DIR");
>     std::string data_dir;
>     if (!opt_data_dir) {
>         if (!only_data_dir) {
>             if (stardict_data_dir)
>                 data_dir = stardict_data_dir;
>             else
>                 data_dir = "/usr/share/stardict/dic";
>         }
>     } else {
>         data_dir = get_impl(opt_data_dir);
>     }
> 
> ```
> 
> Please revoke the content of this commit.
> 
> luhux
> 

Do you have an easy test case? Something like 'guix environment --ad-hoc
sdvc stardict-en stardict-es -- sdvc'? I'd like to get it working. What
is it looking for, just one directory?

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#45645: Please revoke this commit: 7dd1a2174a8376c521dcf271e3b76f64096074fe
  2021-01-04 14:14 ` Efraim Flashner
@ 2021-03-26  9:21   ` zimoun
  2021-03-29 13:15     ` Efraim Flashner
  0 siblings, 1 reply; 6+ messages in thread
From: zimoun @ 2021-03-26  9:21 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: 45645

Hi,

On Mon, 04 Jan 2021 at 16:14, Efraim Flashner <efraim@flashner.co.il> wrote:
> On Mon, Jan 04, 2021 at 09:52:38AM +0800, luhux wrote:

>> ```
>>     const gchar *stardict_data_dir = g_getenv("STARDICT_DATA_DIR");
>>     std::string data_dir;
>>     if (!opt_data_dir) {
>>         if (!only_data_dir) {
>>             if (stardict_data_dir)
>>                 data_dir = stardict_data_dir;
>>             else
>>                 data_dir = "/usr/share/stardict/dic";
>>         }
>>     } else {
>>         data_dir = get_impl(opt_data_dir);
>>     }
>>
>> ```
>>
>> Please revoke the content of this commit.

I am not seeing a commit reverting
7dd1a2174a8376c521dcf271e3b76f64096074fe.  Am I correct?

> Do you have an easy test case? Something like 'guix environment --ad-hoc
> sdvc stardict-en stardict-es -- sdvc'? I'd like to get it working. What
> is it looking for, just one directory?

Should 7dd1a2174a8376c521dcf271e3b76f64096074fe be reverted waiting a
proper fix or is it let as it is?

In order to close this. :-)

Cheers,
simon




^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#45645: Please revoke this commit: 7dd1a2174a8376c521dcf271e3b76f64096074fe
  2021-03-26  9:21   ` zimoun
@ 2021-03-29 13:15     ` Efraim Flashner
  2021-06-09 21:48       ` zimoun
  0 siblings, 1 reply; 6+ messages in thread
From: Efraim Flashner @ 2021-03-29 13:15 UTC (permalink / raw)
  To: zimoun; +Cc: 45645

[-- Attachment #1: Type: text/plain, Size: 1821 bytes --]

On Fri, Mar 26, 2021 at 10:21:35AM +0100, zimoun wrote:
> Hi,
> 
> On Mon, 04 Jan 2021 at 16:14, Efraim Flashner <efraim@flashner.co.il> wrote:
> > On Mon, Jan 04, 2021 at 09:52:38AM +0800, luhux wrote:
> 
> >> ```
> >>     const gchar *stardict_data_dir = g_getenv("STARDICT_DATA_DIR");
> >>     std::string data_dir;
> >>     if (!opt_data_dir) {
> >>         if (!only_data_dir) {
> >>             if (stardict_data_dir)
> >>                 data_dir = stardict_data_dir;
> >>             else
> >>                 data_dir = "/usr/share/stardict/dic";
> >>         }
> >>     } else {
> >>         data_dir = get_impl(opt_data_dir);
> >>     }
> >>
> >> ```
> >>
> >> Please revoke the content of this commit.
> 
> I am not seeing a commit reverting
> 7dd1a2174a8376c521dcf271e3b76f64096074fe.  Am I correct?

That's right, I didn't end up reverting it.

> > Do you have an easy test case? Something like 'guix environment --ad-hoc
> > sdvc stardict-en stardict-es -- sdvc'? I'd like to get it working. What
> > is it looking for, just one directory?
> 
> Should 7dd1a2174a8376c521dcf271e3b76f64096074fe be reverted waiting a
> proper fix or is it let as it is?
> 
> In order to close this. :-)

I suppose we could revert it for now. I don't know of any dictionaries
that it would currently use and according to the bug report it isn't
working as expected. I was hoping to get it working but moved on to
other things.

> 
> Cheers,
> simon

Thanks for finding this forgotten bug. luhux, if you have any
suggestions I'd be happy to continue working on it.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#45645: Please revoke this commit: 7dd1a2174a8376c521dcf271e3b76f64096074fe
  2021-03-29 13:15     ` Efraim Flashner
@ 2021-06-09 21:48       ` zimoun
  0 siblings, 0 replies; 6+ messages in thread
From: zimoun @ 2021-06-09 21:48 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: 45645

Hi,

On Mon, 29 Mar 2021 at 16:15, Efraim Flashner <efraim@flashner.co.il> wrote:
> On Fri, Mar 26, 2021 at 10:21:35AM +0100, zimoun wrote:
>> On Mon, 04 Jan 2021 at 16:14, Efraim Flashner <efraim@flashner.co.il> wrote:
>> > On Mon, Jan 04, 2021 at 09:52:38AM +0800, luhux wrote:
>>
>> >> ```
>> >>     const gchar *stardict_data_dir = g_getenv("STARDICT_DATA_DIR");
>> >>     std::string data_dir;
>> >>     if (!opt_data_dir) {
>> >>         if (!only_data_dir) {
>> >>             if (stardict_data_dir)
>> >>                 data_dir = stardict_data_dir;
>> >>             else
>> >>                 data_dir = "/usr/share/stardict/dic";
>> >>         }
>> >>     } else {
>> >>         data_dir = get_impl(opt_data_dir);
>> >>     }
>> >>
>> >> ```
>> >>
>> >> Please revoke the content of this commit.
>>
>> I am not seeing a commit reverting
>> 7dd1a2174a8376c521dcf271e3b76f64096074fe.  Am I correct?
>
> That's right, I didn't end up reverting it.
>
>> > Do you have an easy test case? Something like 'guix environment --ad-hoc
>> > sdvc stardict-en stardict-es -- sdvc'? I'd like to get it working. What
>> > is it looking for, just one directory?
>>
>> Should 7dd1a2174a8376c521dcf271e3b76f64096074fe be reverted waiting a
>> proper fix or is it let as it is?
>>
>> In order to close this. :-)
>
> I suppose we could revert it for now. I don't know of any dictionaries
> that it would currently use and according to the bug report it isn't
> working as expected. I was hoping to get it working but moved on to
> other things.

The commit 7dd1a2174a8376c521dcf271e3b76f64096074fe is not reverted.
Let revert and close this bug report.  Or add a comment in
gnu/packages/dictionaries.scm and close this bug report. :-)


Cheers,
simon




^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#45645: Please revoke this commit: 7dd1a2174a8376c521dcf271e3b76f64096074fe
  2021-01-04  1:52 bug#45645: Please revoke this commit: 7dd1a2174a8376c521dcf271e3b76f64096074fe luhux
  2021-01-04 14:14 ` Efraim Flashner
@ 2021-06-10  6:47 ` Leo Prikler
  1 sibling, 0 replies; 6+ messages in thread
From: Leo Prikler @ 2021-06-10  6:47 UTC (permalink / raw)
  To: 45645-done

Commit has successfully been revoked.
Thanks!





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-06-10  6:55 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-04  1:52 bug#45645: Please revoke this commit: 7dd1a2174a8376c521dcf271e3b76f64096074fe luhux
2021-01-04 14:14 ` Efraim Flashner
2021-03-26  9:21   ` zimoun
2021-03-29 13:15     ` Efraim Flashner
2021-06-09 21:48       ` zimoun
2021-06-10  6:47 ` Leo Prikler

unofficial mirror of bug-guix@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-bugs/0 guix-bugs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-bugs guix-bugs/ https://yhetil.org/guix-bugs \
		bug-guix@gnu.org
	public-inbox-index guix-bugs

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.bugs
	nntp://news.gmane.io/gmane.comp.gnu.guix.bugs


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git