From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Simon Tournier <zimon.toutoune@gmail.com>, 72333@debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
Andrew Tropin <andrew@trop.in>
Subject: bug#72333: [PATCH] gnu: emacs-minimal: Do not native-compile lisp/transient.el.
Date: Tue, 03 Sep 2024 18:49:49 +0200 [thread overview]
Message-ID: <9c3737160558822cb90fabe516d78ed82853f4ca.camel@gmail.com> (raw)
In-Reply-To: <fae9eb4815d3d4867a2cc48795bd30f0ec4b84c7.1725374463.git.zimon.toutoune@gmail.com>
Am Dienstag, dem 03.09.2024 um 16:57 +0200 schrieb Simon Tournier:
> Fixes <https://issues.guix.gnu.org/72333>.
> Reported by daniel szmulewicz <daniel.szmulewicz@gmail.com>.
I think those belong in the trailer, but I can fix that myself.
> * gnu/packages/emacs.scm (emacs-minimal)[arguments]<phases>: Turn off
> native-compilation for the file lisp/transient.el.
>
> Change-Id: I27c9d660cbad46be66df641816e4596346969dfc
> ---
> gnu/packages/emacs.scm | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index f1ea4fe061..c555ca09f7 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -233,6 +233,16 @@ (define-public emacs-minimal
> (("\\(tramp-compat-process-running-p \"(.*)\"\\)"
> all process)
> (format #f "(or ~a (tramp-compat-process-running-p
> ~s))"
> all (string-append "." process "-
> real"))))))
> + (add-after 'unpack 'do-not-native-compile
> + (lambda _
> + ;; Fixes <https://issues.guix.gnu.org/72333>.
> Temporary
> + ;; workaround for native-compilation bug of
> transient.el.
> + ;; Please remove once the native-compilation for Emacs
> packages
> + ;; is fully supported.
> + (substitute* "lisp/transient.el"
> + ((";; End:")
> + ";; no-native-compile: t
> +;; End:"))))
Should we do this in a snippet instead? Otherwise LGTM.
Cheers
next prev parent reply other threads:[~2024-09-03 16:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-28 12:41 bug#72333: Magit/Transient error message daniel szmulewicz
2024-07-30 22:20 ` Alvin Hsu
2024-07-30 22:50 ` aurtzy
2024-07-31 16:52 ` Richard Sent
2024-07-31 12:04 ` bug#72333: [PATCH] gnu: emacs-transient: Prioritise loading over built-in gemmaro
2024-07-31 17:10 ` Liliana Marie Prikler
2024-08-17 9:26 ` Tomas Volf
2024-08-17 11:21 ` Liliana Marie Prikler
[not found] ` <87ikvias2d.fsf@gmail.com>
2024-09-02 18:55 ` bug#72333: builtin native-compiled is loaded instead of emacs-packages Simon Tournier
2024-09-02 19:00 ` Simon Tournier
2024-09-02 19:22 ` Liliana Marie Prikler
2024-09-03 15:05 ` Simon Tournier
2024-09-03 14:57 ` bug#72333: [PATCH] gnu: emacs-minimal: Do not native-compile lisp/transient.el Simon Tournier
2024-09-03 16:49 ` Liliana Marie Prikler [this message]
2024-09-03 19:47 ` Liliana Marie Prikler
2024-09-03 21:00 ` Simon Tournier
2024-09-14 17:53 ` bug#72333: Magit/Transient error message Rutherther via Bug reports for GNU Guix
2024-09-14 19:12 ` Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c3737160558822cb90fabe516d78ed82853f4ca.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=72333@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=cox.katherine.e+guix@gmail.com \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).