From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Geerinckx-Rice Subject: bug#30006: bzip2 does not provide libbz2.so Date: Sat, 24 Mar 2018 02:17:54 +0100 Message-ID: <99e250aee52d4a4fdce7a7d98d94c5ea@tobias.gr> References: <87incft8tf.fsf@gnu.org> <877eq3knk0.fsf@fastmail.com> <718583be2617e43743e8ee40397bb0b4@tobias.gr> <87woy234a9.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezXpq-0006Ly-M4 for bug-guix@gnu.org; Fri, 23 Mar 2018 21:19:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezXpm-0000Jf-Mm for bug-guix@gnu.org; Fri, 23 Mar 2018 21:19:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:42373) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ezXpm-0000JB-A0 for bug-guix@gnu.org; Fri, 23 Mar 2018 21:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ezXpm-0001Bg-1c for bug-guix@gnu.org; Fri, 23 Mar 2018 21:19:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87woy234a9.fsf@netris.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Marius Bakke Cc: 30006@debbugs.gnu.org Marius, Mark, On 2018-03-23 21:50, Mark H Weaver wrote: > Hi, > > Tobias Geerinckx-Rice writes: > >> On 2018-03-23 13:02, Marius Bakke wrote: >>> diff --git a/gnu/packages/compression.scm >>> b/gnu/packages/compression.scm >>> index b158feac4..fd111e579 100644 >>> --- a/gnu/packages/compression.scm >>> +++ b/gnu/packages/compression.scm >>> @@ -272,6 +272,9 @@ file; as a result, it is often used in >>> conjunction with \"tar\", resulting in >>> (lambda* (#:key outputs #:allow-other-keys) >>> (let* ((out (assoc-ref outputs "out")) >>> (libdir (string-append out "/lib"))) >>> + ;; The Make target above does not create "libbz2.so", >>> only >>> + ;; the versioned libs, so we have to create it >>> ourselves. >>> + (symlink "libbz2.so.1.0" "libbz2.so") >> >> How about symlinking to (string-append ... version) directly? >> Seems more robust & worked fine when I tried it, I think.™ > > In general, the version numbers at the end of shared library names like > "libbz2.so.1.0" do not necessarily match the version number of the > corresponding source release. Therefore, I don't think we should write > code that assumes that those two versions will coincide. Do note that I'm not suggesting doing so in general; just in the case of bzip2 where that rule does historically hold. If that ever changes, so will the ‘1.0’ assumption. (I did substitute ‘version’ for the ‘version-major+minor’ I actually used for... simplicity, I guess, which was probably ill advised.) > However, I agree that it would be better not to hardcode the "1.0". I > would suggest using 'find-files' to find the versioned shared library, > and to verify that there is exactly one match. (ice-9 match) provides > an elegant way to check for a singleton list while matching its > element. I wasn't aware of such an elegant possibility. A perfect fit IMO :-) Thanks, T G-R Sent from a Web browser. Excuse or enjoy my brevity.