From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0PyRI6G1y1+AYgAA0tVLHw (envelope-from ) for ; Sat, 05 Dec 2020 16:30:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id OHhiH6G1y1+lXQAA1q6Kng (envelope-from ) for ; Sat, 05 Dec 2020 16:30:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 34EC894023A for ; Sat, 5 Dec 2020 16:30:25 +0000 (UTC) Received: from localhost ([::1]:40802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klaRz-0007Ma-6A for larch@yhetil.org; Sat, 05 Dec 2020 11:30:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klaRg-0007Ji-50 for bug-guix@gnu.org; Sat, 05 Dec 2020 11:30:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36563) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klaRe-0004c3-Q2 for bug-guix@gnu.org; Sat, 05 Dec 2020 11:30:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1klaRe-00048q-MO for bug-guix@gnu.org; Sat, 05 Dec 2020 11:30:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#23874: [PATCH 1/2] profiles: Remove duplicates in manifest transactions. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 05 Dec 2020 16:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23874 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 23874-submit@debbugs.gnu.org id=B23874.160718577215861 (code B ref 23874); Sat, 05 Dec 2020 16:30:02 +0000 Received: (at 23874) by debbugs.gnu.org; 5 Dec 2020 16:29:32 +0000 Received: from localhost ([127.0.0.1]:48109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klaR9-00047l-VX for submit@debbugs.gnu.org; Sat, 05 Dec 2020 11:29:32 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:60422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klaR8-00047c-CW for 23874@debbugs.gnu.org; Sat, 05 Dec 2020 11:29:31 -0500 Received: from nijino.local (217-149-166-73.nat.highway.telekom.at [217.149.166.73]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4CpFQc0csKz1LLyX; Sat, 5 Dec 2020 17:29:27 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4CpFQc0csKz1LLyX DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1607185768; bh=wWvbrqOc+1k1e2IKlde/1vNo7vA1iSabhiQkPpxWwbs=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=mPQF4PqcrA5xsLPImLk54HYvJZQVfi44jcY/2eqOYsGM0sf1JQyEMScshuLAbvtRH Nkmaul/0J2Saoim2Orqy6C/CBHNajeemlvGYGLND3Jcyb8/u19NvIy/iScOX1JmIJD 9nGLCWUnLAaH1j9H15ApzSv2gzd4fWsbfJ+x/5js= Message-ID: <99b77520efe23cd4ed7188c6dfcbcc4788644689.camel@student.tugraz.at> From: Leo Prikler Date: Sat, 05 Dec 2020 17:29:27 +0100 In-Reply-To: <87360k5kku.fsf@gnu.org> References: <20201202132244.30694-1-leo.prikler@student.tugraz.at> <87ft4oeyyl.fsf@netris.org> <87360k5kku.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 23874@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.20 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=tugraz.at header.s=mailrelay header.b=mPQF4Pqc; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 34EC894023A X-Spam-Score: -1.20 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: Onao5fAnDi7b Hi Ludo Am Samstag, den 05.12.2020, 16:38 +0100 schrieb Ludovic Courtès: > Hi Leo, > > Could you explain what each patch fixes, and perhaps add a test case > for > each that illustrates that? > > Thanks, > Ludo’. Tests sent along with v3. These patches remove duplicates from manifests constructed by packages->manifest and manifest-transaction- effects, so that the UI reports them only once even if they're specified multiple times (e.g. by "guix package -i stress stress stress" or by more accidental copying of package names). The first patch does so for computing transactions (i.e. when using -i, -u and -r), the second for manifests (-m). Regards, Leo