From: Dariqq <dariqq@posteo.net>
To: 71360@debbugs.gnu.org
Subject: bug#71360: large manifests when adding packages
Date: Tue, 4 Jun 2024 17:35:28 +0000 [thread overview]
Message-ID: <946c8da8-e70f-4c9a-b4e0-1c070be15ac1@posteo.net> (raw)
In-Reply-To: <253771a3-f41d-4888-9fa1-0b4ac761c59e@posteo.net>
I think (maybe part of) the problem is that inside entry->gexp in
manifest->gexp things get compared using (the hash of)
(manifest-entry-item entry) which will be a package object for the new
entries but a store path "/gnu/store/*" for packages already present in
the profile.
Also right afterwards we test if the visited previous-entry is
'manifest-entry=?' to entry again causing a potential problem if one has
a string and one a package as item entry.
Would this be worth fixing?
On 04.06.24 13:38, Dariqq wrote:
> Hi Guix,
>
> I was trying to figure out if the "repeated" tag inside a profiles
> manifest file is reliable to detect duplicate entries in a profile.
> While it was working fine for my home and system profile for the normal
> .guix-profile it was not:
>
> This is related to https://issues.guix.gnu.org/55499#0 resp.
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=4ff12d1de7cd617b791996ee7ca1240660b4c20e which marks duplicate entries in a profiles as repeated inside the profile manifest file.
>
> * Steps to reproduce
>
> To stick with the original example: Instead of adding the r packages all
> in one add them one by one
>
> #+begin_example
> guix package -p /tmp/wrong -i r-cicero-monocle3
> guix package -p /tmp/wrong -i r-monocle3
> #+end_example
>
> The resulting manifest file at /tmp/wrong/manifest has the huge tree for
> r-monocle3 twice.
>
> So the lookup mechanism in manifest->gexp does not seem to work with the
> install mechanism of profiles. I haven't looked more deeply into it yet.
>
> An smaller example is using zlib and glib (which propagates zlib).
>
> * Expected Behaviour
>
> It should not matter whether you install things in multiple transactions
> or in one.
>
> Thanks.
prev parent reply other threads:[~2024-06-04 19:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 11:38 bug#71360: large manifests when adding packages Dariqq
2024-06-04 17:35 ` Dariqq [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=946c8da8-e70f-4c9a-b4e0-1c070be15ac1@posteo.net \
--to=dariqq@posteo.net \
--cc=71360@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).