From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sMaGOU64kmFBPQEAgWs5BA (envelope-from ) for ; Mon, 15 Nov 2021 20:43:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UFg2NU64kmH9WQAA1q6Kng (envelope-from ) for ; Mon, 15 Nov 2021 19:43:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 87739138D2 for ; Mon, 15 Nov 2021 20:43:10 +0100 (CET) Received: from localhost ([::1]:34372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmhsj-0006Hg-53 for larch@yhetil.org; Mon, 15 Nov 2021 14:43:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmhsc-0006HW-Dy for bug-guix@gnu.org; Mon, 15 Nov 2021 14:43:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44673) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmhsc-00060k-5Q for bug-guix@gnu.org; Mon, 15 Nov 2021 14:43:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mmhsb-0007EN-Pv for bug-guix@gnu.org; Mon, 15 Nov 2021 14:43:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#51869: [PATCH] Add emacs-vala-mode Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 15 Nov 2021 19:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51869 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Vivien Kraus , 51869@debbugs.gnu.org Received: via spool by 51869-submit@debbugs.gnu.org id=B51869.163700534827746 (code B ref 51869); Mon, 15 Nov 2021 19:43:01 +0000 Received: (at 51869) by debbugs.gnu.org; 15 Nov 2021 19:42:28 +0000 Received: from localhost ([127.0.0.1]:56219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmhs4-0007DR-LH for submit@debbugs.gnu.org; Mon, 15 Nov 2021 14:42:28 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:42536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmhrz-0007D8-Ne for 51869@debbugs.gnu.org; Mon, 15 Nov 2021 14:42:27 -0500 Received: by mail-wr1-f65.google.com with SMTP id c4so32791400wrd.9 for <51869@debbugs.gnu.org>; Mon, 15 Nov 2021 11:42:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=Q5AE7LtrryorBwR6XQ28OWlA0wE2v8FevAk7XU0QJ2o=; b=MFEwzhP76R3NsJBW+uE6QAJpWPFJjNVDtXha0O05MBgkLWcjZpBkJ7mrT78ib644zt Lt6ReyPSjHiHUSOePNvdFW3HF1/Fy26mJFX92lGLHTr2boeBeTRmswH+caDGYwqgVtvm OQbk9AYD4XuO6xkzo/XrOuQYxfwd/Lo7BfV5Mbllz409sgXXScCbgu1/KfCu5UX+K2BN kc9QPUc6lIdRtwVH7KE5iyJIXIQMTRbp6M9G/yrEP8yAAPjh/Q5PYShlq3Eferr4DdpE SeMW+9GZQ6SlSoHvhBIRc0COViaH82KuhWmIoCX0TQZGU2t/9HEDAqXSOmMeVFd5ulfy +VWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=Q5AE7LtrryorBwR6XQ28OWlA0wE2v8FevAk7XU0QJ2o=; b=ZrxK9NxSXdZXbFOzqG7PQcn5EjOu0iAFxuKgrvNL7KU4E/6A2HZ0uDrPQhuvXmh67Q 522MlRDwpp4L+lA86kkMyDvfd0oZevF/aJS3xzcPz7hyS7qAz4bydX+CSWgKNECNcnS7 hmGUETHx+0UqtA1BYuJWwLH8oFW3WGSy0BjYXfHSRzfUSe1bklmQIlQ+EhptWbogssZu N99WWq8Ru9YQU5DrjvSkb38a9BEXAdeFZJf6kr+2dhb3oRIU3OdFYEPOGZUnBWCPz2ae sMHiNOOnD0Fpc/EXXgvQ8nh4JZ8C3Z6ywO+RWJ8ENRtj9VSZolhJr9mV0pu6p1YfeO++ 6pVQ== X-Gm-Message-State: AOAM531kd0Tu3zg4nNK0RBDQdLhB2UohkE5E57KZrw2/tgjYdJvcH1ro acHS+yb70qTPz8GJoLm/gyM= X-Google-Smtp-Source: ABdhPJzgQwPJwcJ6mjpmeIWVy+i0bp44SuYyUaiPEtGLNJun3wUN0WLDyMbd8gCU/zJ5TsOqIV0ZLA== X-Received: by 2002:adf:fe4f:: with SMTP id m15mr1876365wrs.81.1637005337877; Mon, 15 Nov 2021 11:42:17 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id j8sm14829453wrh.16.2021.11.15.11.42.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Nov 2021 11:42:17 -0800 (PST) Message-ID: <93b000a9d4d893e23e7b55d306aa385eeca19c78.camel@gmail.com> From: Liliana Marie Prikler Date: Mon, 15 Nov 2021 20:42:16 +0100 In-Reply-To: <87pmr14ipx.fsf@planete-kraus.eu> References: <87pmr14ipx.fsf@planete-kraus.eu> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637005390; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Q5AE7LtrryorBwR6XQ28OWlA0wE2v8FevAk7XU0QJ2o=; b=pW6UqStDBeMmTpWpgixjaJ/JiKS5pUDq4TIi9SSn37qS1XwWbKRswq15nQ/n3E0jhx4jku c8+UUMoXn4z8AvsnPic3Et8zk4lwGvDZWR/JiTXo5oDfe8RrJ+NS6EoyTT3OuuTKmXSk2C pFgOoNfXqVlGJ+Zw2b5d+9WZyI7E4xCl115H3OZFouc4QQTaB1/PB01lr13FL8P1nToKDy qFsGKDZC6EVrcIG9qCwhXbz6WjIHWfOOIBvDZ8hmSBUQ0+/y28KkYFj89vR2sYsQOdpe4t V8N4nQUhn/8SSNkMDrgas8LKizfK4nGEP+BW6bUpd3yqOzNiMGYywKI3OF8YAQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637005390; a=rsa-sha256; cv=none; b=Atr4qZ42yNt+Pl3JFq2ZplEfAQ5gcRvwoVsUSrLT4E6rHWfRvUBcIeydq2YrfJsVJl4kzL h/EbHgWrlJwNXScFiM3mb2P3KsHh7kGHowSNFMTtXh1x0pDOnpsSGp+h/ssBH9CFHTKSmO laVOxx1/qx5nZ+T6xTf/1YZGDDBINAz6xyTZrofiMSobtmtwsuLtnGAtVFSQ2+EiEZJh2E bpJ3J/0MKR/s1sPINFaADYu5kK0GNNtVTphomvy3Wzs5+CA3LJepvIaHqFFPK8QAk/kiCa eq/u9BNjB/6FFynnfAuPHH6DusopNJy8ERdOksB9MeKt4UKEK+dLiCEkEC5SHA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=MFEwzhP7; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.84 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=MFEwzhP7; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 87739138D2 X-Spam-Score: -1.84 X-Migadu-Scanner: scn0.migadu.com X-TUID: TyRA3ukQxdoS Hi Vivien, Am Montag, den 15.11.2021, 14:05 +0000 schrieb Vivien Kraus: > Dear guix, > > There’s a vala mode for emacs. It is not very useful I'd beg to differ. Not opening Vala files in fundamental-mode is very useful. > The project is not very well maintained I've experienced the same. I previously used the melpa importer, so as to not pollute upstream with it, but given that a patch is needed, we might as well add it properly. > Since I don’t have a solution to fix this issue, I went away and > reverted the multiline support. It builds and is useful enough for > LSP to kick in, so I consider it fixed. > > What do you think? Do you have a better fix? Given my superior knowledge of Emacs Lisp (just kidding), I'd guess the order of declarations is wrong. Pull the defcustom before the other thing and it ought to work. > + (version "20201218.2109") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/rrthomas/vala-mode.git") > + (commit "d696a8177e94c81ea557ad364a3b3dcc3abbc50f"))) Use the (let ((revision ...) (commit ...)) (package ...)) convention, adding a note that upstream has no tagged release. Base version appears to be "0.1" Cheers