* bug#69682: Opam should be using a minimal version of extlib
@ 2024-03-09 19:45 Vivien Kraus via Bug reports for GNU Guix
2024-03-09 21:03 ` bug#69682: [PATCH v2] gnu: ocaml-extlib: Convert to dune-build-system Vivien Kraus via Bug reports for GNU Guix
2024-03-09 21:19 ` bug#69682: [PATCH 0/1] ocaml-extlib: Build with minimal=1 Vivien Kraus via Bug reports for GNU Guix
0 siblings, 2 replies; 6+ messages in thread
From: Vivien Kraus via Bug reports for GNU Guix @ 2024-03-09 19:45 UTC (permalink / raw)
To: 69682
Dear OCaml-aware Guix,
opam seems to imply that we have to use a minimal variant of ocaml-
extlib to build opam:
https://github.com/ocaml/opam/issues/5694
This is likely related to a build failure we are experiencing on the
gnome-team branch:
https://issues.guix.gnu.org/69677
http://ci.guix.gnu.org/build/3415343/log/raw
Best regards,
Vivien
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#69682: [PATCH v2] gnu: ocaml-extlib: Convert to dune-build-system.
2024-03-09 19:45 bug#69682: Opam should be using a minimal version of extlib Vivien Kraus via Bug reports for GNU Guix
@ 2024-03-09 21:03 ` Vivien Kraus via Bug reports for GNU Guix
2024-03-24 7:12 ` pukkamustard
2024-03-09 21:19 ` bug#69682: [PATCH 0/1] ocaml-extlib: Build with minimal=1 Vivien Kraus via Bug reports for GNU Guix
1 sibling, 1 reply; 6+ messages in thread
From: Vivien Kraus via Bug reports for GNU Guix @ 2024-03-09 21:03 UTC (permalink / raw)
To: 69682; +Cc: pukkamustard, julien
* gnu/packages/ocaml.scm (ocaml-extlib) [build-system]: Convert to
dune-build-system.
[arguments]: Remove '#:phases' and add '#:package'.
Change-Id: Ia50c05423f3062200704fbcbb0680f2b326a7ca4
---
Opam still builds on gnome-team.
gnu/packages/ocaml.scm | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index 0f4c351141..b70e925d51 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -644,11 +644,9 @@ (define-public ocaml-extlib
(sha256
(base32
"1jydzw2n84cfiz9y6lk4gih4wbr8jybanmiryfs01svd07g4vpjq"))))
- (build-system ocaml-build-system)
+ (build-system dune-build-system)
(arguments
- `(#:phases
- (modify-phases %standard-phases
- (delete 'configure))))
+ (list #:package "extlib"))
(native-inputs
(list ocaml-cppo))
(home-page "https://github.com/ygrek/ocaml-extlib")
base-commit: 2f441fc738976175d438f7942211b1894e2eb416
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#69682: [PATCH v2] gnu: ocaml-extlib: Convert to dune-build-system.
2024-03-09 21:03 ` bug#69682: [PATCH v2] gnu: ocaml-extlib: Convert to dune-build-system Vivien Kraus via Bug reports for GNU Guix
@ 2024-03-24 7:12 ` pukkamustard
0 siblings, 0 replies; 6+ messages in thread
From: pukkamustard @ 2024-03-24 7:12 UTC (permalink / raw)
To: Vivien Kraus; +Cc: 69682, julien
Sorry for being late to the party. But the conversion to use
dune-build-system looks good to me!
I ran into the same issue when updating opam to 2.1.5 but never managed
to get to the bottom of it. Thanks for figuring this out!
-pukkamustard
Vivien Kraus <vivien@planete-kraus.eu> writes:
> * gnu/packages/ocaml.scm (ocaml-extlib) [build-system]: Convert to
> dune-build-system.
> [arguments]: Remove '#:phases' and add '#:package'.
>
> Change-Id: Ia50c05423f3062200704fbcbb0680f2b326a7ca4
> ---
> Opam still builds on gnome-team.
>
> gnu/packages/ocaml.scm | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
> index 0f4c351141..b70e925d51 100644
> --- a/gnu/packages/ocaml.scm
> +++ b/gnu/packages/ocaml.scm
> @@ -644,11 +644,9 @@ (define-public ocaml-extlib
> (sha256
> (base32
> "1jydzw2n84cfiz9y6lk4gih4wbr8jybanmiryfs01svd07g4vpjq"))))
> - (build-system ocaml-build-system)
> + (build-system dune-build-system)
> (arguments
> - `(#:phases
> - (modify-phases %standard-phases
> - (delete 'configure))))
> + (list #:package "extlib"))
> (native-inputs
> (list ocaml-cppo))
> (home-page "https://github.com/ygrek/ocaml-extlib")
>
> base-commit: 2f441fc738976175d438f7942211b1894e2eb416
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#69682: [PATCH 0/1] ocaml-extlib: Build with minimal=1.
2024-03-09 19:45 bug#69682: Opam should be using a minimal version of extlib Vivien Kraus via Bug reports for GNU Guix
2024-03-09 21:03 ` bug#69682: [PATCH v2] gnu: ocaml-extlib: Convert to dune-build-system Vivien Kraus via Bug reports for GNU Guix
@ 2024-03-09 21:19 ` Vivien Kraus via Bug reports for GNU Guix
2024-03-09 21:03 ` bug#69682: [PATCH 1/1] gnu: " Vivien Kraus via Bug reports for GNU Guix
1 sibling, 1 reply; 6+ messages in thread
From: Vivien Kraus via Bug reports for GNU Guix @ 2024-03-09 21:19 UTC (permalink / raw)
To: 69682; +Cc: pukkamustard, julien
Dear Guix, brave ocaml-team members,
According to https://github.com/ocaml/opam/issues/5694
it looks like ocaml-extlib should build with minimal=1.
This also fixes a build failure on gnome-team.
What do you think?
Best regards,
Vivien
Vivien Kraus (1):
gnu: ocaml-extlib: Build with minimal=1.
gnu/packages/ocaml.scm | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
base-commit: 2f441fc738976175d438f7942211b1894e2eb416
--
2.41.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#69682: [PATCH 1/1] gnu: ocaml-extlib: Build with minimal=1.
2024-03-09 21:19 ` bug#69682: [PATCH 0/1] ocaml-extlib: Build with minimal=1 Vivien Kraus via Bug reports for GNU Guix
@ 2024-03-09 21:03 ` Vivien Kraus via Bug reports for GNU Guix
2024-03-09 21:37 ` Julien Lepiller
0 siblings, 1 reply; 6+ messages in thread
From: Vivien Kraus via Bug reports for GNU Guix @ 2024-03-09 21:03 UTC (permalink / raw)
To: 69682; +Cc: pukkamustard, julien
* gnu/packages/ocaml.scm (ocaml-extlib) [arguments]: Convert to list of
G-Expressions. Add #:make-flags.
Change-Id: I42ee3c21a52788f20ddc3381927ef6ef40b2a354
---
gnu/packages/ocaml.scm | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index 0f4c351141..b911da8e5b 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -646,9 +646,11 @@ (define-public ocaml-extlib
"1jydzw2n84cfiz9y6lk4gih4wbr8jybanmiryfs01svd07g4vpjq"))))
(build-system ocaml-build-system)
(arguments
- `(#:phases
- (modify-phases %standard-phases
- (delete 'configure))))
+ (list
+ #:make-flags #~'("minimal=1")
+ #:phases
+ #~(modify-phases %standard-phases
+ (delete 'configure))))
(native-inputs
(list ocaml-cppo))
(home-page "https://github.com/ygrek/ocaml-extlib")
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#69682: [PATCH 1/1] gnu: ocaml-extlib: Build with minimal=1.
2024-03-09 21:03 ` bug#69682: [PATCH 1/1] gnu: " Vivien Kraus via Bug reports for GNU Guix
@ 2024-03-09 21:37 ` Julien Lepiller
0 siblings, 0 replies; 6+ messages in thread
From: Julien Lepiller @ 2024-03-09 21:37 UTC (permalink / raw)
To: Vivien Kraus, 69682; +Cc: pukkamustard
Ah, you sent this while I was writing to the other bug. Would it be possible to convert the recipe to use the dune-build-system instead? It sounds like it would be more future-proof, and it's also prefered by opam people.
Le 9 mars 2024 22:03:15 GMT+01:00, Vivien Kraus <vivien@planete-kraus.eu> a écrit :
>* gnu/packages/ocaml.scm (ocaml-extlib) [arguments]: Convert to list of
>G-Expressions. Add #:make-flags.
>
>Change-Id: I42ee3c21a52788f20ddc3381927ef6ef40b2a354
>---
> gnu/packages/ocaml.scm | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
>index 0f4c351141..b911da8e5b 100644
>--- a/gnu/packages/ocaml.scm
>+++ b/gnu/packages/ocaml.scm
>@@ -646,9 +646,11 @@ (define-public ocaml-extlib
> "1jydzw2n84cfiz9y6lk4gih4wbr8jybanmiryfs01svd07g4vpjq"))))
> (build-system ocaml-build-system)
> (arguments
>- `(#:phases
>- (modify-phases %standard-phases
>- (delete 'configure))))
>+ (list
>+ #:make-flags #~'("minimal=1")
>+ #:phases
>+ #~(modify-phases %standard-phases
>+ (delete 'configure))))
> (native-inputs
> (list ocaml-cppo))
> (home-page "https://github.com/ygrek/ocaml-extlib")
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-03-24 7:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-09 19:45 bug#69682: Opam should be using a minimal version of extlib Vivien Kraus via Bug reports for GNU Guix
2024-03-09 21:03 ` bug#69682: [PATCH v2] gnu: ocaml-extlib: Convert to dune-build-system Vivien Kraus via Bug reports for GNU Guix
2024-03-24 7:12 ` pukkamustard
2024-03-09 21:19 ` bug#69682: [PATCH 0/1] ocaml-extlib: Build with minimal=1 Vivien Kraus via Bug reports for GNU Guix
2024-03-09 21:03 ` bug#69682: [PATCH 1/1] gnu: " Vivien Kraus via Bug reports for GNU Guix
2024-03-09 21:37 ` Julien Lepiller
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).