From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 2HrBEwT8ZWb7fgAAe85BDQ:P1 (envelope-from ) for ; Sun, 09 Jun 2024 21:01:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 2HrBEwT8ZWb7fgAAe85BDQ (envelope-from ) for ; Sun, 09 Jun 2024 21:01:24 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lostca.se header.s=anamika header.b=XW8Aw3oo; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1717959683; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pDrzKV624eJ3Yw2Bwrt4LRRbcXBXlqoD8MYjUwd0EiM=; b=AYh9EO9pnoa6h09Y886cDLzj/mspxEiPba169DWw/SxGUv9yLI24Ma8ah9CUlxBOy4hyXT y+OZImRaxww876WF6n9io2dc0vuz6nNDcRhsZdY0T385KwJp0D++s+0y6zvPDqmzUGDmry HLSKS2ik1Xf7FlGF5ssi6pGeeFtwzeNh32bKVVpP9HQtAqGfyDTUb/E0NYScG6zT+GJoc8 bvhLxy0Sz/2kf6AysXeVJxmNdPR8cmrmRnJpUks9d1wBXERU7P1fD8UNRs0buthFrZPH/4 ZhxkwVr+8KYV+Joql7ughK3LFbTcZrQ0V6ZC5Ye+az99HZPnH3AhYSK/PhYBuQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lostca.se header.s=anamika header.b=XW8Aw3oo; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1717959683; a=rsa-sha256; cv=none; b=S0M9lnYViR/VA6964I4I7kqPjiT2jl+VAxb9DjSnuWxazteIWYx3fstj29aZoKX7dNuRCs +HzTQt7rrRZqghtMTbEmvQofLokQTuYnjw0lb3I0SQOUzDARzmtrv0ay6kyMGNKFZNGqRl DnGDPX90iEdws5NWmXrj+oDkFpk2lNHK4wiu9eA8ybP0QCz5BpfIAcayuNp8lolwTE4Uu2 L1A6xFQio6qAuqbSUAvE7mk7Eibx/oHuHPZP5Dam55xmupCWqBQ7dA0VC9/plh0IS0e+pp 3ake9SyfRQRn6ZQLjnHr5GS7kWgg78CXdX2aI/7PBmkiia2vRjZjgV2CiiRHfQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DA9023DF40 for ; Sun, 9 Jun 2024 21:01:23 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGNOi-0000VM-51; Sun, 09 Jun 2024 14:36:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFymE-00009M-Hz for bug-guix@gnu.org; Sat, 08 Jun 2024 12:18:48 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sFymE-0000Pk-AH for bug-guix@gnu.org; Sat, 08 Jun 2024 12:18:46 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sFymU-0002G5-45 for bug-guix@gnu.org; Sat, 08 Jun 2024 12:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#44877: [PATCH] gnu: grub: load lvm grub module. References: <31b2cc61-04ab-6d2b-880e-a22af5677d3f@gmail.com> In-Reply-To: <31b2cc61-04ab-6d2b-880e-a22af5677d3f@gmail.com> Resent-From: ashish.is@lostca.se Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 08 Jun 2024 16:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44877 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 44877@debbugs.gnu.org Cc: Ashish SHUKLA Received: via spool by 44877-submit@debbugs.gnu.org id=B44877.17178635028627 (code B ref 44877); Sat, 08 Jun 2024 16:19:02 +0000 Received: (at 44877) by debbugs.gnu.org; 8 Jun 2024 16:18:22 +0000 Received: from localhost ([127.0.0.1]:39289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFylm-0002F0-FF for submit@debbugs.gnu.org; Sat, 08 Jun 2024 12:18:22 -0400 Received: from anamika.lostca.se ([65.21.75.227]:49950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFylk-0002Eg-DN for 44877@debbugs.gnu.org; Sat, 08 Jun 2024 12:18:17 -0400 Received: from sofia.home.inet6.fi (62.red-81-34-40.dynamicip.rima-tde.net [81.34.40.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: abbe) by anamika.lostca.se (Postfix) with ESMTPSA id 14C70FF4C; Sat, 8 Jun 2024 16:17:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lostca.se; s=anamika; t=1717863443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=pDrzKV624eJ3Yw2Bwrt4LRRbcXBXlqoD8MYjUwd0EiM=; b=XW8Aw3oo04krihPq8wW20g4gN6pcfriGcK/TeEXmlm/OAcdHaeQ1r9CG0v14TEUrIpr5Nh zfdfRdrAYVwBQFd8H8BbuBekaPEKxnVCRp8sdTZld0mJrPElQEg9aK9e4mfOQyXxpGNhqk wG9TnXv5LYv37Lj18U7T8/ZcDiiA/N0= Date: Sat, 8 Jun 2024 18:13:36 +0200 Message-ID: <8eb817a7e3e7a6033b2f102d55c0095f2b7a075a.1717863216.git.ashish.is@lostca.se> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Sun, 09 Jun 2024 14:36:05 -0400 X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: ashish.is@lostca.se From: ashish.is--- via Bug reports for GNU Guix Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.34 X-Spam-Score: -5.34 X-Migadu-Queue-Id: DA9023DF40 X-Migadu-Scanner: mx13.migadu.com X-TUID: yBaK2xpvfCAj From: Ashish SHUKLA * gnu/bootloader/grub.scm (make-grub-configuration): load lvm grub module when generating configuration for cryptodisks setup. Change-Id: I1dbb0c7dbf68a5f93db76dc29793a1f73be49ee2 --- Hi, I have a Guix setup which has a LUKS2 partition containing a LVM volume group on which kernels and initrds reside. I think this is one of the common setups in which folks uses disk-encryption on GNU/Linux. Since in Guix the kernels/initrd don't get copied to /boot it requires GRUB to be able to unlock the LUKS2 volume, and look inside the LVM partitions to find initrd, and kernel. The former part is already there, this patch enables the latter part, so folks like me who use LVM on top of LUKS be able to boot, otherwise it requires going to grub command-line, and running "insmod lvm" prior to selecting a boot option. Thanks, Ashish gnu/bootloader/grub.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm index 2723eda5f4..a4ca0bc217 100644 --- a/gnu/bootloader/grub.scm +++ b/gnu/bootloader/grub.scm @@ -445,7 +445,7 @@ (define* (make-grub-configuration grub config entries ;; Other type of devices aren't implemented. #~())) (let ((devices (map crypto-device->cryptomount store-crypto-devices)) - (modules #~(format port "insmod luks~%insmod luks2~%"))) + (modules #~(format port "insmod luks~%insmod luks2~%insmod lvm~%"))) (if (null? devices) devices (cons modules devices)))) base-commit: 580d77d0fb12448ef1621699cc0c56e787e2aadb -- 2.45.2