unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: ashish.is--- via Bug reports for GNU Guix <bug-guix@gnu.org>
To: 44877@debbugs.gnu.org
Cc: Ashish SHUKLA <ashish.is@lostca.se>
Subject: bug#44877: [PATCH] gnu: grub: load lvm grub module.
Date: Sat,  8 Jun 2024 18:13:36 +0200	[thread overview]
Message-ID: <8eb817a7e3e7a6033b2f102d55c0095f2b7a075a.1717863216.git.ashish.is@lostca.se> (raw)
In-Reply-To: <31b2cc61-04ab-6d2b-880e-a22af5677d3f@gmail.com>

From: Ashish SHUKLA <ashish.is@lostca.se>

* gnu/bootloader/grub.scm (make-grub-configuration): load lvm grub module
  when generating configuration for cryptodisks setup.

Change-Id: I1dbb0c7dbf68a5f93db76dc29793a1f73be49ee2
---
Hi,

I have a Guix setup which has a LUKS2 partition containing a LVM
volume group on which kernels and initrds reside. I think this is one
of the common setups in which folks uses disk-encryption on
GNU/Linux. Since in Guix the kernels/initrd don't get copied to /boot
it requires GRUB to be able to unlock the LUKS2 volume, and look
inside the LVM partitions to find initrd, and kernel. The former part
is already there, this patch enables the latter part, so folks like me
who use LVM on top of LUKS be able to boot, otherwise it requires
going to grub command-line, and running "insmod lvm" prior to
selecting a boot option.

Thanks,
Ashish

 gnu/bootloader/grub.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm
index 2723eda5f4..a4ca0bc217 100644
--- a/gnu/bootloader/grub.scm
+++ b/gnu/bootloader/grub.scm
@@ -445,7 +445,7 @@ (define* (make-grub-configuration grub config entries
           ;; Other type of devices aren't implemented.
           #~()))
     (let ((devices (map crypto-device->cryptomount store-crypto-devices))
-          (modules #~(format port "insmod luks~%insmod luks2~%")))
+          (modules #~(format port "insmod luks~%insmod luks2~%insmod lvm~%")))
       (if (null? devices)
           devices
           (cons modules devices))))

base-commit: 580d77d0fb12448ef1621699cc0c56e787e2aadb
-- 
2.45.2





      reply	other threads:[~2024-06-09 19:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 23:53 bug#44877: Root on LVM support Mikhail Tsykalov
2024-06-08 16:13 ` ashish.is--- via Bug reports for GNU Guix [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8eb817a7e3e7a6033b2f102d55c0095f2b7a075a.1717863216.git.ashish.is@lostca.se \
    --to=bug-guix@gnu.org \
    --cc=44877@debbugs.gnu.org \
    --cc=ashish.is@lostca.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).