Guile reader package names are problematic

Guile reader package names are problematic

[Mark H Weaver]

Hi Ludovic,

In commit d9d466ddff2091f4b1f94599335b5947a17def2c, you added the
following packages:

  guile-reader-for-guile-1.8.8
  guile-reader-for-guile-2.0.7

The "1.8.8" and "2.0.7" are actually part of the package names (both of
these packages are at version 0.6).

Unfortunately, this means that these packages cannot be referenced using
the guix command-line tools, because 'package-name->name+version'
assumes that "1.8.8" or "2.0.7" is the version number, and that the
package name is "guile-reader-for-guile".  It then fails to find any
package of that name.

How do you suppose this should be fixed?

      Mark

Re: Guile reader package names are problematic

[Andreas Enge]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

Am Donnerstag, 14. Februar 2013 schrieb Mark H Weaver:
>   guile-reader-for-guile-1.8.8
>   guile-reader-for-guile-2.0.7
> 
> The "1.8.8" and "2.0.7" are actually part of the package names (both of
> these packages are at version 0.6).

How about naming them "guile-reader" with a version number of 0.6-1.8.8 and 
0.6-2.0.7, or the other way round 1.8.8-0.6 and 2.0.7-0.6?

Andreas

[-- Attachment #2: Type: text/html, Size: 2348 bytes --]

Re: Guile reader package names are problematic

[Ludovic Courtès]

Mark H Weaver <mhw@netris.org> skribis:

> In commit d9d466ddff2091f4b1f94599335b5947a17def2c, you added the
> following packages:
>
>   guile-reader-for-guile-1.8.8
>   guile-reader-for-guile-2.0.7
>
> The "1.8.8" and "2.0.7" are actually part of the package names (both of
> these packages are at version 0.6).

Yes, the ‘guile-reader’ procedure was mostly added for illustrative
reasons, at the beginning.

In today’s real world, I would just get rid of the one for 1.8, and keep
only the one for 2.0.  Someone really wanting 1.8 can still inherit from
the other one and just change the “guile” input.

Would you like to change that?

Ludo’.

Re: Guile reader package names are problematic

[Mark H Weaver]

Andreas Enge <andreas@enge.fr> writes:
> How about naming them "guile-reader" with a version number of
> 0.6-1.8.8 and 0.6-2.0.7, or the other way round 1.8.8-0.6 and
> 2.0.7-0.6?

We can't do this, because it would break the version-number comparison
logic.  One option would be to change the dash to something else.
Maybe tilde?

  guile-reader-for-guile~1.8.8
  guile-reader-for-guile~2.0.7

Even if we decide to remove 'guile-reader-for-guile-1.8.8', there will
surely be other cases like this, so it would be useful to decide on a
policy.

     Mark

Re: Guile reader package names are problematic

[Ludovic Courtès]

Mark H Weaver <mhw@netris.org> skribis:

> Andreas Enge <andreas@enge.fr> writes:
>> How about naming them "guile-reader" with a version number of
>> 0.6-1.8.8 and 0.6-2.0.7, or the other way round 1.8.8-0.6 and
>> 2.0.7-0.6?
>
> We can't do this, because it would break the version-number comparison
> logic.  One option would be to change the dash to something else.
> Maybe tilde?
>
>   guile-reader-for-guile~1.8.8
>   guile-reader-for-guile~2.0.7

Good idea.

> Even if we decide to remove 'guile-reader-for-guile-1.8.8', there will
> surely be other cases like this, so it would be useful to decide on a
> policy.

Yes, so maybe we can keep it as an illustrative example, but with tilde.
Feel free to commit a patch that does that.

Thanks!

Ludo’.

Re: Guile reader package names are problematic

[Mark H Weaver]

ludo@gnu.org (Ludovic Courtès) writes:

> Mark H Weaver <mhw@netris.org> skribis:
>
>> Andreas Enge <andreas@enge.fr> writes:
>>> How about naming them "guile-reader" with a version number of
>>> 0.6-1.8.8 and 0.6-2.0.7, or the other way round 1.8.8-0.6 and
>>> 2.0.7-0.6?
>>
>> We can't do this, because it would break the version-number comparison
>> logic.  One option would be to change the dash to something else.
>> Maybe tilde?
>>
>>   guile-reader-for-guile~1.8.8
>>   guile-reader-for-guile~2.0.7
>
> Good idea.

Unfortunately, tilde seems to be forbidden in package names.

  mhw@tines:~/guix$ ./pre-inst-env guix package -i guile-reader-for-guile~2.0.7
  error: build failed: invalid character `~' in name `guile-reader-for-guile~2.0.7-0.6-guile-builder'

How about using underscore instead?  That seems to be allowed.

   guile-reader-for-guile_1.8.8
   guile-reader-for-guile_2.0.7

       Mark

Re: Guile reader package names are problematic

[Ludovic Courtès]

Mark H Weaver <mhw@netris.org> skribis:

> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Mark H Weaver <mhw@netris.org> skribis:
>>
>>> Andreas Enge <andreas@enge.fr> writes:
>>>> How about naming them "guile-reader" with a version number of
>>>> 0.6-1.8.8 and 0.6-2.0.7, or the other way round 1.8.8-0.6 and
>>>> 2.0.7-0.6?
>>>
>>> We can't do this, because it would break the version-number comparison
>>> logic.  One option would be to change the dash to something else.
>>> Maybe tilde?
>>>
>>>   guile-reader-for-guile~1.8.8
>>>   guile-reader-for-guile~2.0.7
>>
>> Good idea.
>
> Unfortunately, tilde seems to be forbidden in package names.

Arrgh, yes.  I don’t know why, seems like a silly restriction.

> How about using underscore instead?  That seems to be allowed.

Well yes, why not.

Ludo’.