From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#19402: Already-applied patches in 'origin' are automatically reversed Date: Thu, 18 Dec 2014 12:05:25 +0100 Message-ID: <87zjal1ami.fsf@gnu.org> References: <87fvcd25cr.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1YuH-0004m8-1D for bug-guix@gnu.org; Thu, 18 Dec 2014 06:06:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1YuA-0002rU-O7 for bug-guix@gnu.org; Thu, 18 Dec 2014 06:06:08 -0500 Received: from debbugs.gnu.org ([140.186.70.43]:40120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1YuA-0002qu-KK for bug-guix@gnu.org; Thu, 18 Dec 2014 06:06:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Y1YuA-00025J-2c for bug-guix@gnu.org; Thu, 18 Dec 2014 06:06:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87fvcd25cr.fsf@netris.org> (Mark H. Weaver's message of "Wed, 17 Dec 2014 19:01:40 -0500") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: Mark H Weaver Cc: 19402@debbugs.gnu.org Mark H Weaver skribis: > Currently, if a patch that we carry in Guix is taken upstream, and then > we update the package, Guix will automatically reverse the patch without > error. > > This behavior delayed my xorg-update work for several hours today (I was > stumped and took a break), and I worry that patches that aren't needed > for successful compilation (e.g. security fixes) could be automatically > undone without anyone noticing. > > Perhaps the solution is to pass --force (not --batch) to 'patch'. I=E2=80=99ve re-read patch(1) and yes, definitely. Would you like to make this change in =E2=80=98core-updates=E2=80=99? Thanks, Ludo=E2=80=99.